unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Confusing "bzr log" as result of merges
Date: Mon, 23 May 2011 08:58:18 -0400	[thread overview]
Message-ID: <E1QOUiA-0000Ws-P9@fencepost.gnu.org> (raw)
In-Reply-To: <jwvk4dhy6af.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Mon, 23 May 2011 09:02:37 -0300)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Mon, 23 May 2011 09:02:37 -0300
> 
> >> > tool.  The discrepancy here happens because bzrmerge.el plays unholy
> >> > games with the metadata as opposed to the sources.  If we need to do
> >> You are confused: the metadata resulting from bzrmerge.el is 100%
> >> identical to the metadata resulting from "bzr merge".
> > I don't think I'm confused that much: I said "metadata as opposed to
> > the sources".
> 
> Merging with bzrmerge.el instead of with "bzr merge" should result in
> an absolutely identical result, except for the fact that the guy doing
> the merge will have to do a bit less work.

The problem is not that we are merging, but that we merge revisions we
don't need.  We then revert the effect of the merge in the sources,
but the metadata "remembers" that the reverted revision is in the
trunk.

Doing the same manually will obviously produce the same result, but my
point was why do it at all.

IOW, I'm not saying that bzrmerge.el is the culprit.  I'm saying that
the method we use to merge from emacs-23 (which is implemented by
bzrmerge.el) is the culprit.



      reply	other threads:[~2011-05-23 12:58 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  7:33 Confusing "bzr log" as result of merges Eli Zaretskii
2011-05-21  8:36 ` Andreas Schwab
2011-05-21  8:44   ` Eli Zaretskii
2011-05-21  8:48     ` Eli Zaretskii
2011-05-21  9:01     ` Sven Joachim
2011-05-21  9:16       ` Eli Zaretskii
2011-05-21  9:27         ` Sven Joachim
2011-05-21  9:30           ` Eli Zaretskii
2011-05-21 10:27             ` Sven Joachim
2011-05-21  9:02     ` Andreas Schwab
2011-05-21  9:20       ` Eli Zaretskii
2011-05-21  9:38         ` Andreas Schwab
2011-05-21 10:33           ` Eli Zaretskii
2011-05-21 10:54             ` Andreas Schwab
2011-05-21 10:38 ` Eli Zaretskii
2011-05-21 10:56   ` Andreas Schwab
2011-05-21 11:27     ` Eli Zaretskii
2011-05-21 12:23       ` Andreas Schwab
2011-05-21 12:28         ` Eli Zaretskii
2011-05-21 10:57   ` Sven Joachim
2011-05-21 13:04   ` Eli Zaretskii
2011-05-21 13:37     ` Andreas Schwab
2011-05-21 14:46       ` Eli Zaretskii
2011-05-21 15:18         ` Andreas Schwab
2011-05-21 15:51           ` Eli Zaretskii
2011-05-21 16:39             ` Andreas Schwab
2011-05-21 16:21 ` Óscar Fuentes
2011-05-21 16:42   ` Andreas Schwab
2011-05-21 17:00     ` Óscar Fuentes
2011-05-21 17:06       ` Andreas Schwab
2011-05-21 17:19         ` Óscar Fuentes
2011-05-21 17:52           ` Andreas Schwab
2011-05-22 11:33           ` Juanma Barranquero
2011-05-21 16:48   ` Eli Zaretskii
2011-05-21 17:09     ` Óscar Fuentes
2011-05-21 18:56       ` Eli Zaretskii
2011-05-21 17:27 ` Glenn Morris
2011-05-21 19:02   ` Eli Zaretskii
2011-05-22  1:46     ` Glenn Morris
2011-05-22 14:14 ` Stefan Monnier
2011-05-22 17:28   ` Eli Zaretskii
2011-05-22 19:15     ` Stefan Monnier
2011-05-23  3:01       ` Eli Zaretskii
2011-05-23 12:02         ` Stefan Monnier
2011-05-23 12:58           ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1QOUiA-0000Ws-P9@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).