From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Tue, 03 May 2011 00:19:13 -0400 Message-ID: References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87wrjquacf.fsf@lifelogs.com> <87lj05svwh.fsf@lifelogs.com> <87bp11imgb.wl%claudio.bley@gmail.com> <8739mc5nes.fsf@lifelogs.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1304396361 22537 80.91.229.12 (3 May 2011 04:19:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 May 2011 04:19:21 +0000 (UTC) Cc: tzz@lifelogs.com, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 06:19:17 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QH74v-0002yZ-1r for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 06:19:17 +0200 Original-Received: from localhost ([::1]:48971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH74u-0006aT-IW for ged-emacs-devel@m.gmane.org; Tue, 03 May 2011 00:19:16 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:57770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH74s-0006a9-AF for emacs-devel@gnu.org; Tue, 03 May 2011 00:19:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QH74r-00058b-8W for emacs-devel@gnu.org; Tue, 03 May 2011 00:19:14 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:55575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH74r-00058X-5u for emacs-devel@gnu.org; Tue, 03 May 2011 00:19:13 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QH74r-0004GY-1F; Tue, 03 May 2011 00:19:13 -0400 In-reply-to: (message from Juanma Barranquero on Tue, 3 May 2011 04:27:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139043 Archived-At: > From: Juanma Barranquero > Date: Tue, 3 May 2011 04:27:55 +0200 > Cc: emacs-devel@gnu.org > > Please take a look at the attached patch, which is a rough cut It's mostly a mechanical change, and looks fine to me upon first reading. However, this: > --- src/w32.h 2011-04-25 01:30:51 +0000 > +++ src/w32.h 2011-05-02 01:47:27 +0000 > @@ -1,6 +1,8 @@ > #ifndef EMACS_W32_H > #define EMACS_W32_H > > +#include "lisp.h" is bad: lisp.h is already included in too many places. Why did you need this? Also, this: > +/* The argument LIBRARIES is usually the variable > + `dynamic-library-alist', which associates a symbol, identifying > + an external DLL library, to a list of possible filenames. > + The function returns NULL if no library could be loaded for > + the given symbol, or if the library was previously loaded; > + else the handle of the DLL. */ > +HMODULE > +w32_delayed_load (Lisp_Object libraries, Lisp_Object library_id) has a couple of problems in the commentary: . it should describe the structure of the LIBRARIES alist explicitly, like you'd do in a doc string, not just refer to `dynamic-library-alist' . it says nothing about the second argument (and IIUC what it means, the "_id" part of the variable name is misleading) Btw, why is it a good idea to return NULL if the library is already loaded? Why not return its handle instead?