From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: oops? read/write vs type of length parameter
Date: Tue, 12 Apr 2011 01:46:12 -0400 [thread overview]
Message-ID: <E1Q9WQW-0004lG-8K@fencepost.gnu.org> (raw)
In-Reply-To: <4DA3DDCD.10700@cs.ucla.edu> (message from Paul Eggert on Mon, 11 Apr 2011 22:06:21 -0700)
> Date: Mon, 11 Apr 2011 22:06:21 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
>
> On 04/11/2011 08:01 PM, Eli Zaretskii wrote:
> > When Emacs saves a buffer or some its portion,
> > write-region can call emacs_write (though a_write and e_write) with
> > the full extent of the region to be saved.
>
> Ah, sorry, I missed that one. In that case 'int'
> clearly won't do for the size.
The same is true for emacs_read, btw; see insert-file-contents.
> > The issue here is that emacs_write and emacs_read are on the boundary:
> > they accept Emacs Lisp integers, but then call a system API.
>
> No, they are regularly passed size_t values as sizes,
> in other sections of the code. I just now counted,
> and the 16 calls to emacs_write use int constants
> 6 times, size_t 5 times, EMACS_INT 3 times, and an
> int variable once. So, judging by the caller's usages,
> size_t would seem more appropriate.
Granted, I reviewed all those other callers when I made my change.
All those I left at their original form are passing small values in
this argument. In particular, all the callers that use size_t get
those values by calling strlen on short strings. And int is obviously
not a problem at all.
So this theoretical issue has no practical consequences in the case in
point.
However, if it's deemed good practice to make them 100% bulletproof,
I'm not opposed to change them all use EMACS_INT or ssize_t, although
that would require type casts that I deplore.
> Furthermore, the API for emacs_write should be designed
> to let callers know what emacs_write should do. Since emacs_write
> operates on size values that fit into size_t, that would
> seem to be the more appropriate type for its size argument.
As was already explained here, this has downsides that are more
serious than the current use of ssize_t (as long as programming
mistakes are concerned). So this suggestion I do oppose.
next prev parent reply other threads:[~2011-04-12 5:46 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 8:55 oops? read/write vs type of length parameter Jim Meyering
2011-04-11 9:44 ` Eli Zaretskii
2011-04-11 11:08 ` Jim Meyering
2011-04-11 11:28 ` David Kastrup
2011-04-11 11:52 ` Eli Zaretskii
2011-04-11 12:27 ` Jim Meyering
2011-04-11 12:31 ` David Kastrup
2011-04-11 21:54 ` Jim Meyering
2011-04-12 4:44 ` Eli Zaretskii
2011-04-12 13:24 ` Ted Zlatanov
2011-04-12 13:29 ` Eli Zaretskii
2011-04-12 14:47 ` Ted Zlatanov
2011-04-12 17:00 ` Large file support (was: oops? read/write vs type of length parameter) Eli Zaretskii
2011-04-14 20:57 ` oops? read/write vs type of length parameter Michael Welsh Duggan
2011-04-11 14:02 ` Eli Zaretskii
2011-04-11 11:40 ` Stephen J. Turnbull
2011-04-11 13:58 ` Eli Zaretskii
2011-04-12 1:16 ` Paul Eggert
2011-04-12 3:01 ` Eli Zaretskii
2011-04-12 5:06 ` Paul Eggert
2011-04-12 5:46 ` Eli Zaretskii [this message]
2011-04-12 8:19 ` Paul Eggert
2011-04-12 9:41 ` Eli Zaretskii
2011-04-12 15:53 ` Paul Eggert
2011-04-12 16:56 ` Eli Zaretskii
2011-04-12 23:55 ` Juanma Barranquero
2011-04-13 5:14 ` Paul Eggert
2011-04-13 6:31 ` Jim Meyering
2011-04-13 6:37 ` Eli Zaretskii
2011-04-13 8:15 ` Paul Eggert
2011-04-13 9:46 ` Eli Zaretskii
2011-04-13 16:06 ` Paul Eggert
2011-04-13 17:22 ` Eli Zaretskii
2011-04-13 19:31 ` Paul Eggert
2011-04-13 19:59 ` PJ Weisberg
2011-04-14 4:49 ` Eli Zaretskii
2011-04-13 20:02 ` Paul Eggert
2011-04-13 6:49 ` Eli Zaretskii
2011-04-13 14:35 ` Ted Zlatanov
2011-04-15 13:13 ` Ted Zlatanov
2011-04-15 16:34 ` Paul Eggert
2011-04-15 18:20 ` Ted Zlatanov
2011-04-15 1:29 ` Stefan Monnier
2011-04-15 8:55 ` Paul Eggert
2011-04-15 9:41 ` Eli Zaretskii
2011-04-15 10:24 ` Paul Eggert
2011-04-12 12:32 ` Davis Herring
2011-04-12 13:38 ` Eli Zaretskii
2011-04-12 15:43 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Q9WQW-0004lG-8K@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).