[patch] emacsclient vs SIGWINCH

[patch] emacsclient vs SIGWINCH

[Karl Chen]

On Solaris (but not Linux), emacsclient dies upon SIGWINCH.

The problem is that recv() gets interrupted and returns EINTR.

The patch below works for me.

Karl


diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
index e5484b9..17945aa 100644
--- a/lib-src/emacsclient.c
+++ b/lib-src/emacsclient.c
@@ -1708,10 +1708,21 @@ main (int argc, char **argv)
   fsync (1);
 
   /* Now, wait for an answer and print any messages.  */
-  while (exit_status == EXIT_SUCCESS
-	 && (rl = recv (emacs_socket, string, BUFSIZ, 0)) > 0)
+  while (exit_status == EXIT_SUCCESS)
     {
       char *p;
+      do 
+        {
+          errno = 0; 
+          rl = recv (emacs_socket, string, BUFSIZ, 0);
+          /* If we receive a signal (e.g. SIGWINCH, which we
+             pass through to emacs), on some OSes we get EINTR and
+             must retry. */
+        }
+      while (rl < 0 && errno == EINTR);
+      if (rl <= 0)
+        break;
+      
       string[rl] = '\0';
 
       p = string + strlen (string) - 1;

Re: [patch] emacsclient vs SIGWINCH

[Richard Stallman]

    On Solaris (but not Linux), emacsclient dies upon SIGWINCH.

Thanks for fixing a bug, but you really should not call our system
"Linux".

Solaris is an operating system, and you can run Emacs on it.  Linux is
not an operating system, and you can't run Emacs on it.  If you are
thinking of something that is a sufficient platform to run Emacs, you
must have in mind the GNU/Linux system.

To call the GNU/Linux system "Linux" is giving the credit for our work
to someone else who did less.  Now that you know, please make an
effort to treat us fairly.

See http://www.gnu.org/gnu/gnu-linux-faq.html.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org

Re: [patch] emacsclient vs SIGWINCH

[Stefan Monnier]

> On Solaris (but not Linux), emacsclient dies upon SIGWINCH.
> The problem is that recv() gets interrupted and returns EINTR.
> The patch below works for me.

Thanks, installed.


        Stefan