unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: importing getloadavg from gnulib
Date: Tue, 08 Feb 2011 05:28:40 -0500	[thread overview]
Message-ID: <E1PmkoK-0007bC-Ns@fencepost.gnu.org> (raw)
In-Reply-To: <4D510CC2.6080207@cs.ucla.edu> (message from Paul Eggert on Tue,  08 Feb 2011 01:28:34 -0800)

> Date: Tue, 08 Feb 2011 01:28:34 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
> 
> On 02/08/2011 01:02 AM, Eli Zaretskii wrote:
> 
> > However, this change in src/lisp.h:
> > 
> >> -#ifndef HAVE_GETLOADAVG
> >> -/* Defined in getloadavg.c */
> >> -extern int getloadavg (double *, int);
> >> -#endif
> > 
> > will cause the prototype of getloadavg to become unavailable in the
> > Windows build, because the Windows stdlib.h obviously does not declare
> > it.  So I think we should leave the declaration in place for the
> > Windows build at the least.
> 
> Since only Windows needs it now, how about if we move it
> to src/s/ms-w32.h?  That way, it's clearly localized to the
> Windows port.

That'd be fine.



      reply	other threads:[~2011-02-08 10:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  7:22 importing getloadavg from gnulib Paul Eggert
2011-02-08  8:31 ` Dan Nicolaescu
2011-02-08  9:01   ` Andreas Schwab
2011-02-10  7:54     ` Paul Eggert
2011-02-15  6:49       ` Paul Eggert
2011-02-15 18:13         ` Eli Zaretskii
2011-02-15 18:55           ` Paul Eggert
2011-02-15 19:21             ` Eli Zaretskii
2011-02-15 20:41               ` Paul Eggert
2011-02-16  0:38                 ` Paul Eggert
2011-02-16 18:50             ` Eli Zaretskii
2011-02-08  9:02 ` Eli Zaretskii
2011-02-08  9:28   ` Paul Eggert
2011-02-08 10:28     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PmkoK-0007bC-Ns@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).