From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug in 23.2.92 with anything Date: Sun, 16 Jan 2011 08:48:01 -0500 Message-ID: References: <87aaj2asy4.fsf@gmail.com> <4D31FDEC.9050508@gmx.at> <4D32D81B.5090905@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1295185699 30254 80.91.229.12 (16 Jan 2011 13:48:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 16 Jan 2011 13:48:19 +0000 (UTC) Cc: thierry.volpiatto@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 16 14:48:15 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PeSxq-0006uu-6R for ged-emacs-devel@m.gmane.org; Sun, 16 Jan 2011 14:48:14 +0100 Original-Received: from localhost ([127.0.0.1]:43956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeSxp-0000lL-Ji for ged-emacs-devel@m.gmane.org; Sun, 16 Jan 2011 08:48:13 -0500 Original-Received: from [140.186.70.92] (port=49613 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeSxj-0000l6-T0 for emacs-devel@gnu.org; Sun, 16 Jan 2011 08:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PeSxi-0007RF-CB for emacs-devel@gnu.org; Sun, 16 Jan 2011 08:48:07 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:41832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PeSxi-0007RB-9M for emacs-devel@gnu.org; Sun, 16 Jan 2011 08:48:06 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PeSxd-0007cc-T8; Sun, 16 Jan 2011 08:48:01 -0500 In-reply-to: <4D32D81B.5090905@gmx.at> (message from martin rudalics on Sun, 16 Jan 2011 12:35:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134602 Archived-At: > Date: Sun, 16 Jan 2011 12:35:55 +0100 > From: martin rudalics > CC: Stefan Monnier , emacs-devel@gnu.org, > thierry.volpiatto@gmail.com > > >> Could some one rename Fselect_window to something else, add a third > >> parameter to it and create a new Fselect_window that calls it (and let > >> Fset_window_configuration call the new function with the new param), so > >> as to get rid of this global var? > > > > This is what I intended to do (I thought it was pretty clear from the > > discussions that this is THE right solution), but I'm traveling now > > and will be back only a week from now. If no one beats me to it, I > > will make this change. > > I posted a patch along these lines - please tell me whether it is what > you had in mind. Yes, it is. Thanks. > I'm almost 100% convinced that it doesn't DTRT. That parameter would > have to be passed on to Fselect_frame and from there back to > Fselect_window. As I said earlier, the problem is that we temporarily > violate the invariant window_frame (selected_window) == selected_frame. IIUC, you are saying that there will be still additional problems left even after this change. If so, I might agree, but what we are trying to do here is to avoid the situation whereby selected_window is nil, because that bombs inside window_text_bottom_y. Using the parameter allows us to communicate to select-window that it should not swap out point, without setting selected_window to nil. Would you agree that this part of the problem is fixed by the change you posted? If not, please explain why not.