* Which test files should make-dist distribute?
@ 2011-01-14 19:03 Paul Eggert
2011-01-14 19:57 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggert @ 2011-01-14 19:03 UTC (permalink / raw)
To: emacs-devel
After recent changes to the trunk added some test files, the
resulting distributions broke "configure", which would complain
that a test Makefile.in was absent from the distribution. For now
I've fixed the problem by installing the patch enclosed below,
but it'd be nice if someone more conversant with the new test scheme
reviewed this to make sure that make-dist is distributing the right
set of files.
* make-dist: Distribute test/ files too.
Distribute every file under test/ that is under version control,
using patterns like *.el to capture files that are added later.
Without this change, "configure" would fail, because it would
attempt to build from a Makefile.in that was not distributed.
=== modified file 'make-dist'
--- make-dist 2011-01-14 17:18:41 +0000
+++ make-dist 2011-01-14 18:49:11 +0000
@@ -295,6 +295,7 @@
nt nt/inc nt/inc/sys nt/inc/arpa nt/inc/netinet nt/icons \
`find etc lisp -type d` \
doc doc/emacs doc/misc doc/man doc/lispref doc/lispintro \
+ test test/automated test/cedet test/cedet/tests test/indent \
info m4 msdos \
nextstep nextstep/Cocoa nextstep/Cocoa/Emacs.base \
nextstep/Cocoa/Emacs.base/Contents \
@@ -474,6 +475,26 @@
ln ChangeLog* *.1 ../../${tempdir}/doc/man
cd ../../${tempdir}/doc/man)
+echo "Making links to \`test'"
+(cd test
+ ln *.el ChangeLog README ../${tempdir}/test)
+
+echo "Making links to \`test/automated'"
+(cd test/automated
+ ln *.el Makefile.in ../../${tempdir}/test/automated)
+
+echo "Making links to \`test/cedet'"
+(cd test/cedet
+ ln *.el ../../${tempdir}/test/cedet)
+
+echo "Making links to \`test/cedet/tests'"
+(cd test/cedet/tests
+ ln *.c *.[ch]pp *.el *.hh *.java *.make ../../../${tempdir}/test/cedet/tests)
+
+echo "Making links to \`test/indent'"
+(cd test/indent
+ ln *.m *.mod *.prolog Makefile ../../${tempdir}/test/indent)
+
### It would be nice if they could all be symlinks to top-level copy, but
### you're not supposed to have any symlinks in distribution tar files.
echo "Making sure copying notices are all copies of \`COPYING'"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Which test files should make-dist distribute?
2011-01-14 19:03 Which test files should make-dist distribute? Paul Eggert
@ 2011-01-14 19:57 ` Glenn Morris
2011-01-14 20:23 ` Lennart Borgman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Glenn Morris @ 2011-01-14 19:57 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-devel
Paul Eggert wrote:
> After recent changes to the trunk added some test files, the
> resulting distributions broke "configure", which would complain
> that a test Makefile.in was absent from the distribution.
So the position has changed?
http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00197.html
> why Emacs currently has test/ as a separate top-level directory?
Because the test files are not to be distributed with the tarball.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Which test files should make-dist distribute?
2011-01-14 19:57 ` Glenn Morris
@ 2011-01-14 20:23 ` Lennart Borgman
2011-01-14 22:43 ` Eli Zaretskii
2011-01-14 20:34 ` Paul Eggert
2011-01-14 21:03 ` Stefan Monnier
2 siblings, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2011-01-14 20:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: Paul Eggert, emacs-devel
On Fri, Jan 14, 2011 at 8:57 PM, Glenn Morris <rgm@gnu.org> wrote:
> Paul Eggert wrote:
>
>> After recent changes to the trunk added some test files, the
>> resulting distributions broke "configure", which would complain
>> that a test Makefile.in was absent from the distribution.
>
> So the position has changed?
>
> http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00197.html
>
> > why Emacs currently has test/ as a separate top-level directory?
>
> Because the test files are not to be distributed with the tarball.
Was there really a consensus about that? Why shouldn't they be distributed?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Which test files should make-dist distribute?
2011-01-14 19:57 ` Glenn Morris
2011-01-14 20:23 ` Lennart Borgman
@ 2011-01-14 20:34 ` Paul Eggert
2011-01-14 21:03 ` Stefan Monnier
2 siblings, 0 replies; 6+ messages in thread
From: Paul Eggert @ 2011-01-14 20:34 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
On 01/14/11 11:57, Glenn Morris wrote:
> So the position has changed?
>
> http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00197.html
No, sorry, I wasn't aware of that position, and I don't know whether
it has changed. However, _something_ needed to be done; without the
change, "configure" doesn't work when you run "configure" out of a
fresh distribution, and that's a serious bug. If there's a better
approach for fixing the bug, please let me know, and I can implement it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Which test files should make-dist distribute?
2011-01-14 19:57 ` Glenn Morris
2011-01-14 20:23 ` Lennart Borgman
2011-01-14 20:34 ` Paul Eggert
@ 2011-01-14 21:03 ` Stefan Monnier
2 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-01-14 21:03 UTC (permalink / raw)
To: Glenn Morris; +Cc: Paul Eggert, emacs-devel
>> After recent changes to the trunk added some test files, the
>> resulting distributions broke "configure", which would complain
>> that a test Makefile.in was absent from the distribution.
> So the position has changed?
> http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00197.html
>> why Emacs currently has test/ as a separate top-level directory?
> Because the test files are not to be distributed with the tarball.
I still want to move the `test' outside of Emacs's tree into
a separate branch.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Which test files should make-dist distribute?
2011-01-14 20:23 ` Lennart Borgman
@ 2011-01-14 22:43 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2011-01-14 22:43 UTC (permalink / raw)
To: Lennart Borgman; +Cc: eggert, emacs-devel
> From: Lennart Borgman <lennart.borgman@gmail.com>
> Date: Fri, 14 Jan 2011 21:23:58 +0100
> Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
>
> > http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00197.html
> >
> > > why Emacs currently has test/ as a separate top-level directory?
> >
> > Because the test files are not to be distributed with the tarball.
>
>
> Was there really a consensus about that?
Yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-14 22:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-14 19:03 Which test files should make-dist distribute? Paul Eggert
2011-01-14 19:57 ` Glenn Morris
2011-01-14 20:23 ` Lennart Borgman
2011-01-14 22:43 ` Eli Zaretskii
2011-01-14 20:34 ` Paul Eggert
2011-01-14 21:03 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).