From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation. Date: Mon, 27 Sep 2010 04:40:44 -0400 Message-ID: References: <4C9FB21E.209@swipnet.se> <83k4m8qi8q.fsf@gnu.org> <4CA039F3.1050102@swipnet.se> <4CA0546E.40409@swipnet.se> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285577213 29004 80.91.229.12 (27 Sep 2010 08:46:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Sep 2010 08:46:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?UTF-8?B?SmFuIERqw6Rydg==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 27 10:46:51 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P09MJ-0005pX-4T for ged-emacs-devel@m.gmane.org; Mon, 27 Sep 2010 10:46:51 +0200 Original-Received: from localhost ([127.0.0.1]:53870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P09MH-0005LS-Ux for ged-emacs-devel@m.gmane.org; Mon, 27 Sep 2010 04:46:49 -0400 Original-Received: from [140.186.70.92] (port=40287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P09M8-0005KZ-6o for emacs-devel@gnu.org; Mon, 27 Sep 2010 04:46:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P09GP-0007kx-CG for emacs-devel@gnu.org; Mon, 27 Sep 2010 04:40:46 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:38179) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P09GP-0007kt-Az for emacs-devel@gnu.org; Mon, 27 Sep 2010 04:40:45 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P09GO-0003SE-NV; Mon, 27 Sep 2010 04:40:44 -0400 In-reply-to: <4CA0546E.40409@swipnet.se> (message from =?UTF-8?B?SmFuIERqw6Rydg==?= on Mon, 27 Sep 2010 10:23:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130976 Archived-At: > Date: Mon, 27 Sep 2010 10:23:10 +0200 > From: =?UTF-8?B?SmFuIERqw6Rydg==?= > CC: emacs-devel@gnu.org > > So why are there an #ifdef subprocesses in > add/delete_keyboard_wait_descriptor? The only thing they do is > manipulate data that goes to select. Because the variables they use are only defined under "#ifdef subprocesses", see the beginning of process.c. The alternative was to have more #ifdef's at the beginning of process.c or reshuffle the beginning some more, and I didn't feel at the time it was justified, given the possible breakage of various platforms I could never test on. There's too much unportable stuff in process.c, so I prefer not to mess with that unless strictly necessary.