From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Building Emacs with MSVC Date: Wed, 07 Apr 2010 03:22:03 -0400 Message-ID: References: <4BBBEFE2.5040003@gmail.com> <831vesx8d5.fsf@gnu.org> <4BBC0ED7.8070209@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1270624971 21918 80.91.229.12 (7 Apr 2010 07:22:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 7 Apr 2010 07:22:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 07 09:22:50 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NzPb7-0007of-Ka for ged-emacs-devel@m.gmane.org; Wed, 07 Apr 2010 09:22:50 +0200 Original-Received: from localhost ([127.0.0.1]:44359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzPb6-0003cW-Hd for ged-emacs-devel@m.gmane.org; Wed, 07 Apr 2010 03:22:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzPaS-0003C6-8B for emacs-devel@gnu.org; Wed, 07 Apr 2010 03:22:08 -0400 Original-Received: from [199.232.76.173] (port=47323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzPaR-0003BN-Mx for emacs-devel@gnu.org; Wed, 07 Apr 2010 03:22:07 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NzPaO-0001F1-NY for emacs-devel@gnu.org; Wed, 07 Apr 2010 03:22:07 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:51681) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NzPaO-0001Ew-Cs for emacs-devel@gnu.org; Wed, 07 Apr 2010 03:22:04 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NzPaN-0006jr-Rh; Wed, 07 Apr 2010 03:22:04 -0400 In-reply-to: <4BBC0ED7.8070209@gmail.com> (message from Christoph on Tue, 06 Apr 2010 22:49:27 -0600) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123305 Archived-At: > Date: Tue, 06 Apr 2010 22:49:27 -0600 > From: Christoph > CC: emacs-devel@gnu.org > > Also, maybe this is interesting for you Eli: bidi.c failed because MSVC > does not support the inline keyword for C files (only for C++ files). > __inline is the correct keyword for C files > (http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx) in MSVC. Right, I will look into this. Maybe I can just remove that attribute, since the reordering engine is fast enough even in a non-optimized build, and GCC will inline static functions anyway. Thanks for pointing this out. > The patch is actually for a bug in the existing MSVC makefile in > lib-src. I am pretty sure even older versions would not run with this, > since nmake fails right away: > > === modified file 'lib-src/makefile.w32-in' > --- lib-src/makefile.w32-in 2010-04-03 01:54:24 +0000 > +++ lib-src/makefile.w32-in 2010-04-06 03:06:03 +0000 > @@ -195,8 +195,8 @@ > $(lispsource)term/pc-win.elc \ > $(lispsource)x-dnd.elc \ > $(lispsource)term/x-win.elc \ > - ${lispsource}emacs-lisp/easymenu.elc \ > - ${lispsource}term/ns-win.elc > + $(lispsource)emacs-lisp/easymenu.elc \ > + $(lispsource)term/ns-win.elc Yes, braces are a no-no in Windows makefiles. In any case, we do still try to support Nmake, even though newer MSVC is not supported. > > Right. And since MinGW is available and in pretty good shape, we > > decided at the time not to invest any effort in MSVC. > > > I agree. MinGW works absolutely fine, so is there even any reason to > keep the MSVC stuff around? Probably not. > Was MSVC supported earlier than MinGW? I Yes.