unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: dann@ics.uci.edu, emacs-devel@gnu.org, miles@gnu.org
Subject: Re: turning on minor modes from hooks
Date: Tue, 01 Sep 2009 17:20:23 -0400	[thread overview]
Message-ID: <E1Miam7-0006fZ-3T@fencepost.gnu.org> (raw)
In-Reply-To: <jwvocpuhc46.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 01 Sep 2009 12:19:27 -0400)

    > When you call a major mode function, it selects that mode.
    > So when users call a minor mode function, they will expect it
    > to select that mode too.

    So you argue for "turn it on" rather than "toggle".

Not necessarily.  This case should't be considered in isolation but
rather as part of an overall design for minor modes.

One design that occurs to me is (foo-mode) turns it on, (foo-mode t)
turns it on, (foo-mode nil) turns it off, and the way you toggle is
(foo-mode (not foo-mode)).

Another is (foo-mode) toggles, (foo-mode t) turns it on, (foo-mode
nil) turns it off.

I am not sure which of those is better.  I don't think we should
reject either out of hand.

The current convention for interactive calls seems clear and natural
so I think it should be preserved, whatever we do with calls from Lisp.





  reply	other threads:[~2009-09-01 21:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-29 21:25 turning on minor modes from hooks Dan Nicolaescu
2009-08-29 23:18 ` Miles Bader
2009-08-30  0:14   ` Drew Adams
2009-08-30  2:11     ` Miles Bader
2009-08-30  3:01       ` Drew Adams
2009-08-30  3:58         ` Miles Bader
2009-08-30  3:59     ` Stefan Monnier
2009-08-30  4:00       ` Miles Bader
2009-08-31  3:33   ` Richard Stallman
2009-08-31 14:36     ` Stefan Monnier
2009-08-31 22:15       ` Miles Bader
2009-08-31 23:32         ` Stefan Monnier
2009-09-01  0:17           ` Miles Bader
2009-09-01 12:16       ` Richard Stallman
2009-09-01 16:19         ` Stefan Monnier
2009-09-01 21:20           ` Richard Stallman [this message]
2009-09-01 23:23             ` Stefan Monnier
2009-09-03 13:47               ` Richard Stallman
2009-09-04 21:23                 ` Geoff Gole
2009-08-31 15:30     ` Daniel Colascione
2009-08-31 18:54       ` Tassilo Horn
2009-09-01 12:16         ` Richard Stallman
2009-08-31 23:43       ` Stefan Monnier
2009-09-01  2:07       ` Stephen J. Turnbull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Miam7-0006fZ-3T@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).