* Bug fix needs to be put in release branch
@ 2009-07-16 16:18 Richard Stallman
2009-07-16 21:21 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2009-07-16 16:18 UTC (permalink / raw)
To: emacs-devel
I installed a bug fix in the trunk that makes auto-save
work properly in Rmail files. Would someone please install
it in the release branch? I don't have a checkout of that,
and it would not be feasible to check it out here even if I had time.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug fix needs to be put in release branch
2009-07-16 16:18 Bug fix needs to be put in release branch Richard Stallman
@ 2009-07-16 21:21 ` Chong Yidong
2009-07-18 0:29 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2009-07-16 21:21 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Richard Stallman <rms@gnu.org> writes:
> I installed a bug fix in the trunk that makes auto-save
> work properly in Rmail files. Would someone please install
> it in the release branch? I don't have a checkout of that,
> and it would not be feasible to check it out here even if I had time.
I don't think it's appropriate to make this change in the branch.
Could you describe the problem you are trying to fix, and do you have a
recipe for easily reproducing it? In Emacs 22, auto-save is also
disabled in Rmail. If I understand correctly, this behavior is
unchanged for Emacs 23---so what's the reason for changing it now?
It should be possible to get auto-save working in Rmail without
extending buffer-saved-size. For instance, we could change
rmail-swap-buffers-maybe to manage the auto-save variables
appropriately.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug fix needs to be put in release branch
2009-07-16 21:21 ` Chong Yidong
@ 2009-07-18 0:29 ` Richard Stallman
0 siblings, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2009-07-18 0:29 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-devel
> I installed a bug fix in the trunk that makes auto-save
> work properly in Rmail files. Would someone please install
> it in the release branch? I don't have a checkout of that,
> and it would not be feasible to check it out here even if I had time.
I don't think it's appropriate to make this change in the branch.
It fixes a bug. The bug ought to be fixed before the release,
so I wrote a fix.
Could you describe the problem you are trying to fix, and do you have a
recipe for easily reproducing it?
If you enable auto save mode in an Rmail buffer,
auto-save mode can get turned off because the view buffer
is a lot smaller than the whole file. The code which does this
doesn't know anything about swapping buffers, and has no hooks.
Users can enable auto save manually in an Rmail buffer.
If they do, it ought to work.
In addition, rmailout.el enables auto-save mode when it adds a message
to an Rmail file visited in a buffer.
It should be possible to get auto-save working in Rmail without
extending buffer-saved-size. For instance, we could change
rmail-swap-buffers-maybe to manage the auto-save variables
appropriately.
I wrote and tested one fix, which it works. I don't insist on using
this fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-18 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-16 16:18 Bug fix needs to be put in release branch Richard Stallman
2009-07-16 21:21 ` Chong Yidong
2009-07-18 0:29 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).