[PATCH] adjusting korean key bindings

[PATCH] adjusting korean key bindings

[Jihyun Cho]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

I adjusted a keymap.
Many korean people are using a `Hanja' key to convert Hangul to Hanja
and a `Hangul' key to toggle input method.
As a keymap was adjusted, I modified a `hangul-to-hanja-conversion' function.

[-- Attachment #2: emacs-hanja.patch --]
[-- Type: application/octet-stream, Size: 4025 bytes --]

? lisp/mail/subdirs.el
? lisp/nxml/char-name/subdirs.el
Index: leim/quail/hangul.el
===================================================================
RCS file: /sources/emacs/emacs/leim/quail/hangul.el,v
retrieving revision 1.27
diff -u -8 -p -r1.27 hangul.el
--- leim/quail/hangul.el	8 Jan 2009 04:00:28 -0000	1.27
+++ leim/quail/hangul.el	10 Jun 2009 01:19:26 -0000
@@ -86,16 +86,17 @@
       57 62 29 68 6 59 55 16 28 20 60 26 91 92 93 94 95 96 23 78 70 85 71
       65 83 90 109 115 87 116 122 113 118 121 21 66 4 69 99 73 9 1 101 17
       123 124 125 126])
 
 (defvar hangul-im-keymap
   (let ((map (make-sparse-keymap)))
     (define-key map "\d" 'hangul-delete-backward-char)
     (define-key map [f9] 'hangul-to-hanja-conversion)
+    (define-key map [Hangul_Hanja] 'hangul-to-hanja-conversion)
     map)
   "Keymap for Hangul method.  It is used by all Hangul input methods.")
 
 ;; Current input character buffer. Store separated hangul character.
 ;; The first and second are Choseong position.
 ;; The third and forth are Jungseong position.
 ;; The fifth and sixth are Jongseong position.
 ;; The second, forth and sixth are double Jamo position.
@@ -354,22 +355,28 @@ Other parts are the same as a `hangul3-i
     (delete-backward-char 1)))
 
 (defun hangul-to-hanja-conversion ()
   "Convert the previous hangul character to the corresponding hanja character."
   (interactive)
   (let ((echo-keystrokes 0)
         delete-func
         hanja-character)
-    (setq hanja-character (hangul-to-hanja-char (preceding-char)))
+    (if (and (overlayp quail-overlay) (overlay-start quail-overlay))
+        (progn
+          (setq hanja-character (hangul-to-hanja-char (preceding-char)))
+          (setq delete-func (lambda () (delete-backward-char 1))))
+      (setq hanja-character (hangul-to-hanja-char (following-char)))
+      (setq delete-func (lambda () (delete-char 1))))
     (when hanja-character
-      (delete-backward-char 1)
+      (funcall delete-func)
       (insert hanja-character)
       (setq hangul-queue (make-vector 6 0))
-      (move-overlay quail-overlay (point) (point)))))
+      (if (and (overlayp quail-overlay) (overlay-start quail-overlay))
+          (move-overlay quail-overlay (point) (point))))))
 
 ;; Support function for `hangul2-input-method'.  Actually, this
 ;; function handles the Hangul 2-Bulsik.  KEY is an entered key code
 ;; used for looking up `hangul2-keymap'."
 (defun hangul2-input-method-internal (key)
   (let ((char (+ (aref hangul2-keymap (1- (% key 32)))
                  (cond ((or (= key ?O) (= key ?P)) 2)
                        ((or (= key ?E) (= key ?Q) (= key ?R)
Index: lisp/language/korea-util.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/language/korea-util.el,v
retrieving revision 1.19
diff -u -8 -p -r1.19 korea-util.el
--- lisp/language/korea-util.el	5 Jan 2009 03:22:27 -0000	1.19
+++ lisp/language/korea-util.el	10 Jun 2009 01:19:27 -0000
@@ -92,19 +92,22 @@
   (setq isearch-input-method-function input-method-function
 	isearch-input-method-local-p t)
   (setq input-method-function nil)
   (isearch-update))
 
 ;; Information for setting and exiting Korean environment.
 (defvar korean-key-bindings
   `((global [?\S- ] toggle-korean-input-method nil)
+    (global [Hangul] toggle-korean-input-method nil)
     (global [C-f9] quail-hangul-switch-symbol-ksc nil)
-    (global [f9]  quail-hangul-switch-hanja nil)
+    (global [f9] hangul-to-hanja-conversion nil)
+    (global [Hangul_Hanja] hangul-to-hanja-conversion nil)
     (,isearch-mode-map [?\S- ] isearch-toggle-korean-input-method nil)
+    (,isearch-mode-map [Hangul] isearch-toggle-korean-input-method nil)
     (,isearch-mode-map [C-f9] isearch-hangul-switch-symbol-ksc nil)
     (,isearch-mode-map [f9] isearch-hangul-switch-hanja nil)))
 
 ;;;###autoload
 (defun setup-korean-environment-internal ()
   (let ((key-bindings korean-key-bindings))
     (while key-bindings
       (let* ((this (car key-bindings))

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <9d644d9b0906110727r7fc75080gf8f10ea47623db7f@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:

> I adjusted a keymap.
> Many korean people are using a `Hanja' key to convert Hangul to Hanja
> and a `Hangul' key to toggle input method.
> As a keymap was adjusted, I modified a `hangul-to-hanja-conversion' function.

Thank you.  Although the patch need subtle modifications, it
seems that it surely improves usability for Korean users.
But, this change breaks backward compatibility.

-    (global [f9]  quail-hangul-switch-hanja nil)
+    (global [f9] hangul-to-hanja-conversion nil)

The key-binding of F9 for quail-hangul-switch-hanja is what
suggested long ago by a Korean person (I forgot who was
that).  Has the usage of F9 in Korea been changed in these
days?

By the way, Yidong and Stefan, the change don't fit in the
criteria of what can be intalled now, but, for Korean users,
I think it's worth taking your time to consider whether or
not to install it.  Please decide it.  I believe the change
is quite safe.

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Jason Rumney]

Kenichi Handa wrote:
> By the way, Yidong and Stefan, the change don't fit in the
> criteria of what can be intalled now, but, for Korean users,
> I think it's worth taking your time to consider whether or
> not to install it.  Please decide it.  I believe the change
> is quite safe.
>   

One concern I have is that on Windows we currently generate kana and 
kanji key symbols for those keys (as the system keycodes are the same). 
If a change is made to make hangul and hanja keys useful, it would 
probably be best to make the symbol generated by the keys dependent on 
locale so that Korean users get the benefit of that change on Windows too.

Re: [PATCH] adjusting korean key bindings

[Jihyun Cho]

2009/6/12 Kenichi Handa <handa@m17n.org>:
> In article <9d644d9b0906110727r7fc75080gf8f10ea47623db7f@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:
>
>> I adjusted a keymap.
>> Many korean people are using a `Hanja' key to convert Hangul to Hanja
>> and a `Hangul' key to toggle input method.
>> As a keymap was adjusted, I modified a `hangul-to-hanja-conversion' function.
>
> Thank you.  Although the patch need subtle modifications, it
> seems that it surely improves usability for Korean users.
> But, this change breaks backward compatibility.
>
> -    (global [f9]  quail-hangul-switch-hanja nil)
> +    (global [f9] hangul-to-hanja-conversion nil)
>
> The key-binding of F9 for quail-hangul-switch-hanja is what
> suggested long ago by a Korean person (I forgot who was
> that).  Has the usage of F9 in Korea been changed in these
> days?

F9 was used in a 101-key keyboard layout in the past.
Currently, A 103-key keyboard layout or a 106-key keyboard layout is
used in Korea.
Both of them are added Hanja key and Hangul key.
But some people are still using F9 and Shift-Space.

A problem is a input method.
Generally, The input method for conversion of Hanja is converting a
completed Hangul letter to a Hanja letter.
Most of Korean IMEs are implemented these method.
The input method of emacs is little awkward.

> By the way, Yidong and Stefan, the change don't fit in the
> criteria of what can be intalled now, but, for Korean users,
> I think it's worth taking your time to consider whether or
> not to install it.  Please decide it.  I believe the change
> is quite safe.
>
> ---
> Kenichi Handa
> handa@m17n.org
>

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <9d644d9b0906111954m6cb49cb6pe61716bbe060c980@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:

> F9 was used in a 101-key keyboard layout in the past.
> Currently, A 103-key keyboard layout or a 106-key keyboard layout is
> used in Korea.
> Both of them are added Hanja key and Hangul key.
> But some people are still using F9 and Shift-Space.

If what you mean is that some are still using F9 for
switching hangul<->hanja input methods, I think it's not the
time to change the key binding of F9.  As your patch adds
Hangul_Hanja for converting the previous hangul to hanja,
there's no urgent need to change F9 too.

> A problem is a input method.
> Generally, The input method for conversion of Hanja is converting a
> completed Hangul letter to a Hanja letter.
> Most of Korean IMEs are implemented these method.
> The input method of emacs is little awkward.

Do you mean that we don't need the separate hanja input
method any more?

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Jihyun Cho]

2009/6/15 Kenichi Handa <handa@m17n.org>:
> In article <9d644d9b0906111954m6cb49cb6pe61716bbe060c980@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:
>
>> F9 was used in a 101-key keyboard layout in the past.
>> Currently, A 103-key keyboard layout or a 106-key keyboard layout is
>> used in Korea.
>> Both of them are added Hanja key and Hangul key.
>> But some people are still using F9 and Shift-Space.
>
> If what you mean is that some are still using F9 for
> switching hangul<->hanja input methods, I think it's not the
> time to change the key binding of F9.  As your patch adds
> Hangul_Hanja for converting the previous hangul to hanja,
> there's no urgent need to change F9 too.
>
>> A problem is a input method.
>> Generally, The input method for conversion of Hanja is converting a
>> completed Hangul letter to a Hanja letter.
>> Most of Korean IMEs are implemented these method.
>> The input method of emacs is little awkward.
>
> Do you mean that we don't need the separate hanja input
> method any more?

What do you mean the "separate hanja input method"?
If it means the method included in Emacs, we need it.

I agree that F9 should be maintained as conversion key of Hanja.
But the method `quail-hangul-switch-hanja' is not a general way in Korea.
Korean people don't switch the input mode to use Hanja.
We just input a Hangul Letter, then F9 will convert the Letter to Hanja.
I think it's more simple than the method 'quail-hangul-switch-hanja'
for Korean user.
You should know that 'one Hangul Letter' matches 'one Hanja'. and we
normally know the 'pronunciation of hanja', and we want to write hanja
with this.

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <9d644d9b0906150521o23e54620v779832cc8df8e12@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:

> > Do you mean that we don't need the separate hanja input
> > method any more?

> What do you mean the "separate hanja input method"?
> If it means the method included in Emacs, we need it.

I mean the file leim/quail/hanja.el.

> I agree that F9 should be maintained as conversion key of Hanja.
> But the method `quail-hangul-switch-hanja' is not a general way in Korea.
> Korean people don't switch the input mode to use Hanja.
> We just input a Hangul Letter, then F9 will convert the Letter to Hanja.
> I think it's more simple than the method 'quail-hangul-switch-hanja'
> for Korean user.

It seems that we are miscommunicating.  I'm not discussing
whether "F9 should be maintained as conversion key of
Hanja."  As your patch doesn't change the f9 binding in
hangul-im-keymap, I don't have to argue about it.

What I want to know is how important the change of f9
binding in korean-key-bindings is.

> -    (global [f9]  quail-hangul-switch-hanja nil)
> +    (global [f9] hangul-to-hanja-conversion nil)

I asked you:

> The key-binding of F9 for quail-hangul-switch-hanja is what
> suggested long ago by a Korean person (I forgot who was
> that).  Has the usage of F9 in Korea been changed in these
> days?

and you replied as this:

> But some people are still using F9 and Shift-Space.

But now you say:

> But the method `quail-hangul-switch-hanja' is not a general way in Korea.
> Korean people don't switch the input mode to use Hanja.

I'm now confused.

If no one use the facility of quail-hangul-switch-hanja
nowadays, there's no reason to keep the current f9 binding
in korean-key-bindings.  But if some people still uses it,
we should not change it now.

So, which is the case?

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Jihyun Cho]

We are miscommunicating.
I understood that you were concerning about users who are still using F9.
And what I want to tell you about is, those
functions(`quail-hangul-switch-hanja', `hangul-to-hanja-conversion')
are doing same job(to input Hanja), but using different ways.
If you think the backward compatibility is a problem, please just
apply the function 'hangul-to-hanja-conversion' in my patch for many
users to want to customize a keymap.
And I have one more asking. There is no bindings for
'Hangul','Hangul_Hanja'. Would you add these bindings?


2009/6/16 Kenichi Handa <handa@m17n.org>:
> In article <9d644d9b0906150521o23e54620v779832cc8df8e12@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:
>
>> > Do you mean that we don't need the separate hanja input
>> > method any more?
>
>> What do you mean the "separate hanja input method"?
>> If it means the method included in Emacs, we need it.
>
> I mean the file leim/quail/hanja.el.
>
>> I agree that F9 should be maintained as conversion key of Hanja.
>> But the method `quail-hangul-switch-hanja' is not a general way in Korea.
>> Korean people don't switch the input mode to use Hanja.
>> We just input a Hangul Letter, then F9 will convert the Letter to Hanja.
>> I think it's more simple than the method 'quail-hangul-switch-hanja'
>> for Korean user.
>
> It seems that we are miscommunicating.  I'm not discussing
> whether "F9 should be maintained as conversion key of
> Hanja."  As your patch doesn't change the f9 binding in
> hangul-im-keymap, I don't have to argue about it.
>
> What I want to know is how important the change of f9
> binding in korean-key-bindings is.
>
>> -    (global [f9]  quail-hangul-switch-hanja nil)
>> +    (global [f9] hangul-to-hanja-conversion nil)
>
> I asked you:
>
>> The key-binding of F9 for quail-hangul-switch-hanja is what
>> suggested long ago by a Korean person (I forgot who was
>> that).  Has the usage of F9 in Korea been changed in these
>> days?
>
> and you replied as this:
>
>> But some people are still using F9 and Shift-Space.
>
> But now you say:
>
>> But the method `quail-hangul-switch-hanja' is not a general way in Korea.
>> Korean people don't switch the input mode to use Hanja.
>
> I'm now confused.
>
> If no one use the facility of quail-hangul-switch-hanja
> nowadays, there's no reason to keep the current f9 binding
> in korean-key-bindings.  But if some people still uses it,
> we should not change it now.
>
> So, which is the case?
>
> ---
> Kenichi Handa
> handa@m17n.org
>

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <9d644d9b0906170106r1955c983jf7309e1a49158c01@mail.gmail.com>, Jihyun Cho <jihyun.jo@gmail.com> writes:

> We are miscommunicating.
> I understood that you were concerning about users who are still using F9.
> And what I want to tell you about is, those
> functions(`quail-hangul-switch-hanja', `hangul-to-hanja-conversion')
> are doing same job(to input Hanja), but using different ways.

Yes, I understand that.

> If you think the backward compatibility is a problem, please just
> apply the function 'hangul-to-hanja-conversion' in my patch for many
> users to want to customize a keymap.
> And I have one more asking. There is no bindings for
> 'Hangul','Hangul_Hanja'. Would you add these bindings?

Then, to summarize the requested changes:

o It doesn't change the previous usage.
o It adds new key-binding for 'Hangul' and 'Hangul_Hanja'
  keys.  They are almost the standard keys for Korean users.
o It modifies hangul-to-hanja-conversion so that it can be called
  even when korean input method is off.
o Currently the special key bindings for Korean is not
  documented.  So, the change does't require updating the
  manual.  But, of course, documenting them somewhere is
  preferable.

In article <jwvmy8ddubv.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I don't understand enough of the subject to judge, really.  Does the
> change require updating the manual?  Does it change previous usage, or
> just add new one?

Please see above.

> We're really close to a release now, so I'd rather not make such changes
> so late in the game.

I understand that, but, for Korean users, I think this
change improves the usability very much.

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Chong Yidong]

Kenichi Handa <handa@m17n.org> writes:

> Then, to summarize the requested changes:
>
> o It adds new key-binding for 'Hangul' and 'Hangul_Hanja'
>   keys.  They are almost the standard keys for Korean users.
> o It modifies hangul-to-hanja-conversion so that it can be called
>   even when korean input method is off.
> o Currently the special key bindings for Korean is not
>   documented.  So, the change does't require updating the
>   manual.  But, of course, documenting them somewhere is
>   preferable.

Adding the key bindings for 'Hangul' and 'Hangul_Hanja' seems harmless,
but it's too late in the release process to add the rest.  If it's
useful to add the binding for 'Hangul' and 'Hangul_Hanja', without the
other changes, we can do that now.  Otherwise, this will have to wait
for 23.2.

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <87ab46swlc.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:

> Adding the key bindings for 'Hangul' and 'Hangul_Hanja' seems harmless,
> but it's too late in the release process to add the rest.  If it's
> useful to add the binding for 'Hangul' and 'Hangul_Hanja', without the
> other changes, we can do that now.  Otherwise, this will have to wait
> for 23.2.

Ok.  I've just committed these changes.

2009-06-18  Kenichi Handa  <handa@m17n.org>

	* language/korea-util.el (korean-key-bindings): Add binding for
	key Hangul.

2009-06-18  Kenichi Handa  <handa@m17n.org>

	* quail/hangul.el (hangul-im-keymap): Add binding of key
	Hangul_Hanja.

I didn't add the following binding because it is useless or
confusing without the change of hangul-to-hanja-conversion.

Jihyun, I'll install the remaining changes as soon as the
branch for 23.2 gets ready.

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <E1MH6UN-0006nh-CV@etlken>, Kenichi Handa <handa@m17n.org> writes:
> I didn't add the following binding because it is useless or
> confusing without the change of hangul-to-hanja-conversion.

Oops, here I mean this binding:

+    (global [Hangul_Hanja] hangul-to-hanja-conversion nil)

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Kenichi Handa]

In article <E1MH6UN-0006nh-CV@etlken>, Kenichi Handa <handa@m17n.org> writes:

> Jihyun, I'll install the remaining changes as soon as the
> branch for 23.2 gets ready.

I've just installed them in the trunk (i.e. for 23.2).

---
Kenichi Handa
handa@m17n.org

Re: [PATCH] adjusting korean key bindings

[Stefan Monnier]

> By the way, Yidong and Stefan, the change don't fit in the
> criteria of what can be intalled now, but, for Korean users,
> I think it's worth taking your time to consider whether or
> not to install it.  Please decide it.  I believe the change
> is quite safe.

I don't understand enough of the subject to judge, really.  Does the
change require updating the manual?  Does it change previous usage, or
just add new one?
We're really close to a release now, so I'd rather not make such changes
so late in the game.


        Stefan