From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Automatic composition case is missing in x_compute_glyph_string_overhangs Date: Thu, 11 Jun 2009 11:35:40 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1244687761 18873 80.91.229.12 (11 Jun 2009 02:36:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Jun 2009 02:36:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 11 04:35:58 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MEa8w-0005JA-Bj for ged-emacs-devel@m.gmane.org; Thu, 11 Jun 2009 04:35:54 +0200 Original-Received: from localhost ([127.0.0.1]:55794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEa8v-0000yC-Sh for ged-emacs-devel@m.gmane.org; Wed, 10 Jun 2009 22:35:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEa8r-0000y7-Bp for emacs-devel@gnu.org; Wed, 10 Jun 2009 22:35:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEa8m-0000t5-Jc for emacs-devel@gnu.org; Wed, 10 Jun 2009 22:35:49 -0400 Original-Received: from [199.232.76.173] (port=49642 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEa8m-0000t2-Dp for emacs-devel@gnu.org; Wed, 10 Jun 2009 22:35:44 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:36659) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEa8l-0006tN-KM for emacs-devel@gnu.org; Wed, 10 Jun 2009 22:35:44 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n5B2ZfqV016908; Thu, 11 Jun 2009 11:35:41 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n5B2ZfWT008480; Thu, 11 Jun 2009 11:35:41 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id n5B2ZeFV021517; Thu, 11 Jun 2009 11:35:41 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1MEa8i-0004df-Qa; Thu, 11 Jun 2009 11:35:40 +0900 In-reply-to: (message from YAMAMOTO Mitsuharu on Thu, 11 Jun 2009 10:57:52 +0900) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111425 Archived-At: In article , YAMAMOTO Mitsuharu writes: > Thanks. Could you also check if the following change is correct? Yes, I committed it too. --- Kenichi Handa handa@m17n.org > Index: src/xdisp.c > =================================================================== > RCS file: /sources/emacs/emacs/src/xdisp.c,v > retrieving revision 1.1283 > diff -c -p -r1.1283 xdisp.c > *** src/xdisp.c 10 Jun 2009 14:15:50 -0000 1.1283 > --- src/xdisp.c 11 Jun 2009 01:51:24 -0000 > *************** x_get_glyph_overhangs (glyph, f, left, r > *** 19926,19932 **** > composition_gstring_width (gstring, glyph->u.cmp.from, > glyph->u.cmp.to + 1, &metrics); > if (metrics.rbearing > metrics.width) > ! *right = metrics.rbearing; > if (metrics.lbearing < 0) > *left = - metrics.lbearing; > } > --- 19926,19932 ---- > composition_gstring_width (gstring, glyph->u.cmp.from, > glyph->u.cmp.to + 1, &metrics); > if (metrics.rbearing > metrics.width) > ! *right = metrics.rbearing - metrics.width; > if (metrics.lbearing < 0) > *left = - metrics.lbearing; > }