From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: fail on osx between 2/4/2009 and 2/5/2009 Date: Tue, 24 Feb 2009 11:55:59 +0900 Message-ID: References: <861vubqc79.fsf@blue.stonehenge.com> <10DD5733-4089-4A60-B090-4CB5E32A0E19@42tools.com> <49917BE9.6020903@gnu.org> <15A24001-137F-469F-8B05-DB31D4E8995D@gmail.com> <86BB7F5A-18D1-4D15-A141-FC721BCC7CB4@gmail.com> <9FCA1DF6-50B7-45BF-8082-A8C365F4ADF7@gmail.com> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1235444155 16651 80.91.229.12 (24 Feb 2009 02:55:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Feb 2009 02:55:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 24 03:57:11 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LbnTr-0004Qf-7k for ged-emacs-devel@m.gmane.org; Tue, 24 Feb 2009 03:57:11 +0100 Original-Received: from localhost ([127.0.0.1]:51317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbnSW-00035n-Pr for ged-emacs-devel@m.gmane.org; Mon, 23 Feb 2009 21:55:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LbnSQ-00035V-Tt for emacs-devel@gnu.org; Mon, 23 Feb 2009 21:55:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LbnSO-00034m-4P for emacs-devel@gnu.org; Mon, 23 Feb 2009 21:55:42 -0500 Original-Received: from [199.232.76.173] (port=54664 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbnSN-00034Y-Jn for emacs-devel@gnu.org; Mon, 23 Feb 2009 21:55:39 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:50528) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbnSM-0005ui-M4 for emacs-devel@gnu.org; Mon, 23 Feb 2009 21:55:39 -0500 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n1O2tW41028674; Tue, 24 Feb 2009 11:55:32 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n1O2tWld010965; Tue, 24 Feb 2009 11:55:32 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id n1O2tWHI012874; Tue, 24 Feb 2009 11:55:32 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1LbnSh-0003HG-8h; Tue, 24 Feb 2009 11:55:59 +0900 In-reply-to: <9FCA1DF6-50B7-45BF-8082-A8C365F4ADF7@gmail.com> (message from Adrian Robert on Thu, 19 Feb 2009 12:30:38 +0200) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109304 Archived-At: In article <9FCA1DF6-50B7-45BF-8082-A8C365F4ADF7@gmail.com>, Adrian Robert writes: > On Feb 18, 2009, at 4:48 AM, Kenichi Handa wrote: > > In article , Kenichi Handa > > writes: >>>> The full list of properties that can appear bundled under the >>>> FONT_EXTRA property that are important for drivers to take into >>>> account in match() and list() should be specified somewhere in >>>> font.h. > > > > I've just added comments in font.h, and augmented the > > docstring for font-spec (in font.c). > > > > Please tell me if there is any unclear part. > Looks clear to me. Should weight/slant/width also be mentioned under > list()? No, because they are not specified in FONT-SPEC. The `list' method must return fonts of all their variations. A proper font is selected in font_list_entities of font.c. > Here is a patch which would add that. Thank you. I updated font.h according to that (except for the last hunk). --- Kenichi Handa handa@m17n.org > *** font.h.~1.28.~ Wed Feb 18 11:51:23 2009 > --- font.h Wed Feb 18 16:54:13 2009 > *************** > *** 68,76 **** > enum font_property_index > { > /* FONT-TYPE is a symbol indicating a font backend; currently > `x', > ! `xft', `ftx' are available on X and gdi on Windows. > ! For Windows, `bdf' and `uniscribe' backends are in progress. > ! For Mac OS X, we need `atm'. */ > FONT_TYPE_INDEX, > /* FONT-FOUNDRY is a foundry name (symbol). */ > --- 68,75 ---- > enum font_property_index > { > /* FONT-TYPE is a symbol indicating a font backend; currently > `x', > ! `xft', `ftx' are available on X, gdi on Windows, and ns under > ! Cocoa / GNUstep. */ > FONT_TYPE_INDEX, > /* FONT-FOUNDRY is a foundry name (symbol). */ > *************** > *** 153,160 **** > /* In a font-spec, the value is an alist of extra information > of a > font such as name, OpenType features, and language coverage. > In addition, in a font-entity, the value may contain a pair > ! (font-entity . INFO) where INFO is an extra infomation to > ! identify a font (font-driver dependent). */ > FONT_EXTRA_INDEX, /* alist alist */ > /* This value is the length of font-spec vector. */ > --- 152,159 ---- > /* In a font-spec, the value is an alist of extra information > of a > font such as name, OpenType features, and language coverage. > In addition, in a font-entity, the value may contain a pair > ! (font-entity . INFO) where INFO is extra information to > identify > ! a font (font-driver dependent). */ > FONT_EXTRA_INDEX, /* alist alist */ > /* This value is the length of font-spec vector. */ > *************** > *** 172,178 **** > FONT_NAME_INDEX = FONT_ENTITY_MAX, > /* Full name of the font (string). It is the name extracted from > ! the opend font, and may be different from the above. It may be > nil if the opened font doesn't give a name. */ > FONT_FULLNAME_INDEX, > --- 171,177 ---- > FONT_NAME_INDEX = FONT_ENTITY_MAX, > /* Full name of the font (string). It is the name extracted from > ! the opened font, and may be different from the above. It > may be > nil if the opened font doesn't give a name. */ > FONT_FULLNAME_INDEX, > *************** > *** 499,505 **** > /* Symbol indicating the type of the font-driver. */ > Lisp_Object type; > ! /* 1 iff the font's foundary, family, and adstyle names are case > sensitve. */ > int case_sensitive; > --- 498,504 ---- > /* Symbol indicating the type of the font-driver. */ > Lisp_Object type; > ! /* 1 iff the font's foundry, family, and adstyle names are case > sensitve. */ > int case_sensitive; > *************** > *** 509,518 **** > /* List fonts exactly matching with FONT_SPEC on FRAME. The value > is a list of font-entities. The font properties to be > considered > ! are: :foundry, :family, :adstyle, :registry, :script, :lang, and > ! :otf. See the function `font-spec' for their meanings. Note > ! that the last three properties are stored in FONT_EXTRA_INDEX > ! slot of FONT_SPEC. > The returned value is a list of font-entities. Each font-entity > has :type property whose value is the same as the above `type'. > --- 508,517 ---- > /* List fonts exactly matching with FONT_SPEC on FRAME. The value > is a list of font-entities. The font properties to be > considered > ! are: :family, :weight, :slant, :width, :foundry, :adstyle, > ! :registry, :script, :lang, and :otf. See the function > ! `font-spec' for their meanings. Note that the last three > ! properties are stored in FONT_EXTRA_INDEX slot of FONT_SPEC. > The returned value is a list of font-entities. Each font-entity > has :type property whose value is the same as the above `type'.