From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: rmail-toggle-header problem Date: Wed, 18 Feb 2009 15:37:16 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1234939045 14953 80.91.229.12 (18 Feb 2009 06:37:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2009 06:37:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 18 07:38:40 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LZg4u-00088P-DX for ged-emacs-devel@m.gmane.org; Wed, 18 Feb 2009 07:38:40 +0100 Original-Received: from localhost ([127.0.0.1]:48206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZg3a-0006d5-84 for ged-emacs-devel@m.gmane.org; Wed, 18 Feb 2009 01:37:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZg3Q-0006cq-Ou for emacs-devel@gnu.org; Wed, 18 Feb 2009 01:37:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZg3P-0006cT-Ku for emacs-devel@gnu.org; Wed, 18 Feb 2009 01:37:08 -0500 Original-Received: from [199.232.76.173] (port=41243 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZg3P-0006cQ-Df for emacs-devel@gnu.org; Wed, 18 Feb 2009 01:37:07 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:40235) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZg3M-0001c5-1Z; Wed, 18 Feb 2009 01:37:04 -0500 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n1I6b02I014725; Wed, 18 Feb 2009 15:37:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n1I6b0V5004096; Wed, 18 Feb 2009 15:37:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id n1I6axMW029039; Wed, 18 Feb 2009 15:36:59 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1LZg3Y-0000YQ-0m; Wed, 18 Feb 2009 15:37:16 +0900 In-reply-to: (message from Glenn Morris on Wed, 18 Feb 2009 00:29:30 -0500) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109174 Archived-At: In article , Glenn Morris writes: > (These things will be more traceable and less likely to be overlooked > if you report them as bugs.) Ah, sorry. I at first started to write to emacs-devel as for the second problem because I'm not sure it's a bug of rmail-toggle-header, rmail-yank-original, or supercite. Then, I noticed the first problem, and added that in the mail. > Kenichi Handa wrote: > > When toggled, there's no empty line between header part and > > body part like this: > > > > [...] > > Sender: emacs-devel-bounces+handa=m17n.org@gnu.org > > Errors-To: emacs-devel-bounces+handa=m17n.org@gnu.org > > X-RMAIL-ATTRIBUTES: -------- > > Hi, > > omake prints progress bar using the usual ^M terminal trick. > > [...] > I think an example rmail file is needed, please. I tried to reproduce > this using the quoted message from emacs-devel but could not. (Note > that rms made some changes in this area very recently.) I found that this problem is fixed by today's update. > > And, the first "From ..." line is also shown. Shouldn't > > that line be hidden? At least, C-c C-y (mail-yank-original) > > signals this error: > > > > Mail header "From harsh..." doesn't conform to RFC 822. skipping... > How are you getting that error? "doesn't conform to RFC 822" only > seems to be found in supercite. My mail-citation-hook is (sc-cite-original). So, yes, the error is from supercite. > Arguably, supercite should be changed instead to be more > forgiving. Then, I propose this change (though I don't know if we need a case-fold-search. *** supercite.el.~1.69.~ 2009-01-05 16:55:22.000000000 +0900 --- supercite.el 2009-02-18 15:35:35.000000000 +0900 *************** *** 704,709 **** --- 704,710 ---- ("^\\S +:.*$" (sc-mail-fetch-field) nil t) ("^$" (list 'abort '(step . 0))) ("^[ \t]+" (sc-mail-append-field)) + ("^From " nil nil t) (sc-mail-warn-if-non-rfc822-p (sc-mail-error-in-mail-field)) (end (setq sc-mail-headers-end (point)))) "Regi frame for glomming mail header information.") --- Kenichi Handa handa@m17n.org