unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: rmail-toggle-header problem
Date: Wed, 18 Feb 2009 15:37:16 +0900	[thread overview]
Message-ID: <E1LZg3Y-0000YQ-0m@etlken> (raw)
In-Reply-To: <gdmyckl3d1.fsf@fencepost.gnu.org> (message from Glenn Morris on Wed, 18 Feb 2009 00:29:30 -0500)

In article <gdmyckl3d1.fsf@fencepost.gnu.org>, Glenn Morris <rgm@gnu.org> writes:

> (These things will be more traceable and less likely to be overlooked
> if you report them as bugs.)

Ah, sorry.  I at first started to write to emacs-devel as
for the second problem because I'm not sure it's a bug of
rmail-toggle-header, rmail-yank-original, or supercite.
Then, I noticed the first problem, and added that in the
mail.

> Kenichi Handa wrote:

> > When toggled, there's no empty line between header part and
> > body part like this:
> >
> > [...]
> > Sender: emacs-devel-bounces+handa=m17n.org@gnu.org
> > Errors-To: emacs-devel-bounces+handa=m17n.org@gnu.org
> > X-RMAIL-ATTRIBUTES: --------
> > Hi,
> > omake prints progress bar using the usual ^M terminal trick.
> > [...]

> I think an example rmail file is needed, please. I tried to reproduce
> this using the quoted message from emacs-devel but could not. (Note
> that rms made some changes in this area very recently.)

I found that this problem is fixed by today's update.

> > And, the first "From ..." line is also shown.  Shouldn't
> > that line be hidden?  At least, C-c C-y (mail-yank-original)
> > signals this error:
> >
> > Mail header "From harsh..." doesn't conform to RFC 822. skipping...

> How are you getting that error? "doesn't conform to RFC 822" only
> seems to be found in supercite.

My mail-citation-hook is (sc-cite-original).  So, yes, the
error is from supercite.  

> Arguably, supercite should be changed instead to be more
> forgiving.

Then, I propose this change (though I don't know if we need
a case-fold-search.

*** supercite.el.~1.69.~	2009-01-05 16:55:22.000000000 +0900
--- supercite.el	2009-02-18 15:35:35.000000000 +0900
***************
*** 704,709 ****
--- 704,710 ----
      ("^\\S +:.*$"                 (sc-mail-fetch-field) nil t)
      ("^$"                         (list 'abort '(step . 0)))
      ("^[ \t]+"                    (sc-mail-append-field))
+     ("^From "                     nil nil t)
      (sc-mail-warn-if-non-rfc822-p (sc-mail-error-in-mail-field))
      (end                          (setq sc-mail-headers-end (point))))
    "Regi frame for glomming mail header information.")

---
Kenichi Handa
handa@m17n.org




  reply	other threads:[~2009-02-18  6:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  2:26 rmail-toggle-header problem Kenichi Handa
2009-02-18  5:29 ` Glenn Morris
2009-02-18  6:37   ` Kenichi Handa [this message]
2009-02-18 12:10 ` Richard M Stallman
2009-02-19 20:28   ` Glenn Morris
2009-02-20  1:35     ` Kenichi Handa
2009-02-20  2:12       ` Glenn Morris
2009-02-20  8:34         ` Eli Zaretskii
2009-02-20  8:29       ` Eli Zaretskii
2009-02-20 12:59         ` Kenichi Handa
2009-02-20 13:30     ` Richard M Stallman
2009-02-20 22:21       ` Chetan Pandya
2009-02-21  2:34         ` Stephen J. Turnbull
2009-02-21  1:18       ` Chetan Pandya
2009-02-21  2:21         ` Stefan Monnier
2009-02-21  3:18       ` Glenn Morris
2009-02-21  9:12         ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20  9:35 Alfred M. Szmidt
2009-02-22  9:25 Xavier Maillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LZg3Y-0000YQ-0m@etlken \
    --to=handa@m17n.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).