From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: 23.0.60; detect attached file coding system, make emacs crash. Date: Thu, 15 Jan 2009 09:39:06 +0900 Message-ID: References: <877i51fd95.fsf@redflag-linux.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1231979969 4404 80.91.229.12 (15 Jan 2009 00:39:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Jan 2009 00:39:29 +0000 (UTC) Cc: dianchengwang@gmail.com, emacs-devel@gnu.org To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 15 01:40:41 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LNGHn-0006gs-0z for ged-emacs-devel@m.gmane.org; Thu, 15 Jan 2009 01:40:39 +0100 Original-Received: from localhost ([127.0.0.1]:41361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNGGW-0007c3-J5 for ged-emacs-devel@m.gmane.org; Wed, 14 Jan 2009 19:39:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNGGR-0007ba-6i for emacs-devel@gnu.org; Wed, 14 Jan 2009 19:39:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNGGO-0007bO-QO for emacs-devel@gnu.org; Wed, 14 Jan 2009 19:39:13 -0500 Original-Received: from [199.232.76.173] (port=47943 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNGGO-0007bL-LY for emacs-devel@gnu.org; Wed, 14 Jan 2009 19:39:12 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:52204) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNGGN-000189-VJ for emacs-devel@gnu.org; Wed, 14 Jan 2009 19:39:12 -0500 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n0F0d61n004415; Thu, 15 Jan 2009 09:39:06 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n0F0d6lT001775; Thu, 15 Jan 2009 09:39:06 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id n0F0d6Qv029454; Thu, 15 Jan 2009 09:39:06 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1LNGGI-000533-6D; Thu, 15 Jan 2009 09:39:06 +0900 In-reply-to: (lekktu@gmail.com) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107881 Archived-At: In article , "Juanma Barranquero" writes: > Er, you say: > > That's not enough. c1 and c2 must be checked here too: > > > > e[c1] = 1; > > o[c2] = 1; > and then > > "Juanma Barranquero" writes: > > >>> Don't you need a test also before lines 1605-1606, where c1 and c2 are >>> used as array indexes? > > > > That's not necessary because if c1 and c2 are non-negative, > > it is assured that they are byte values; i.e. less than 256. > but these lines were 1605-1606... Oops, sorry for the confusion. It seems I was sleepy when I wrote that. I wrote the last part at first, then realized the true problem and wrote the first part, and forgot to remove the last part. --- Kenichi Handa handa@m17n.org