From: Kenichi Handa <handa@m17n.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Memory leak in keyboard variables?
Date: Tue, 16 Dec 2008 13:31:45 +0900 [thread overview]
Message-ID: <E1LCRaz-0005OI-S2@etlken.m17n.org> (raw)
In-Reply-To: <87oczeuo0a.fsf@cyd.mit.edu> (message from Chong Yidong on Sun, 14 Dec 2008 22:16:05 -0500)
In article <87oczeuo0a.fsf@cyd.mit.edu>, Chong Yidong <cyd@stupidchicken.com> writes:
> I think the problem is that font_clear_cache is incorrectly written.
> For some reason, it assumes that the font cache entries have the form
> (font-spec [entity1 entity2...])
> when in fact, they have the form
> (font-spec entity1 entity2...)
> The following patch to font_clear_cache frees 60-70k of memory per
> terminal.
Ah, it seems that your patch is correct.
> Do you know why font_clear_cache was written this way,
In the early version of font-backend codes,
font_driver->list returns a vector. I changed it to return
a list at sometime, but have forgotten to adjust
font_clear_cache.
> and whether there
> could be any other places in the font code that make this incorrect
> assumption?
I've just read through font.c, but the other places look ok.
---
Kenichi Handa
handa@m17n.org
next prev parent reply other threads:[~2008-12-16 4:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 1:26 Memory leak in keyboard variables? Kenichi Handa
2008-12-15 3:16 ` Chong Yidong
2008-12-15 4:06 ` image cache (was: Memory leak in keyboard variables?) Stefan Monnier
2008-12-15 4:12 ` Eli Zaretskii
2008-12-15 15:19 ` image cache Stefan Monnier
2008-12-15 16:08 ` Chong Yidong
2008-12-15 20:09 ` Stefan Monnier
2008-12-16 1:41 ` Miles Bader
2008-12-16 4:56 ` Chetan Pandya
2008-12-16 7:02 ` Chetan Pandya
2008-12-16 4:31 ` Kenichi Handa [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-16 2:14 Memory leak in keyboard variables? Chetan Pandya
2008-12-16 3:33 ` Chong Yidong
2008-12-11 3:03 Chong Yidong
2008-12-11 9:30 ` Andreas Schwab
2008-12-11 15:09 ` Chong Yidong
2008-12-11 20:43 ` Chong Yidong
2008-12-13 14:19 ` Markus Triska
2008-12-13 19:09 ` Chong Yidong
2008-12-16 14:11 ` Chong Yidong
2008-12-17 4:40 ` Stephen J. Turnbull
2008-12-20 1:50 ` Chong Yidong
2008-12-20 15:34 ` Jan Djärv
2008-12-20 17:09 ` Markus Triska
2008-12-20 17:45 ` Dan Nicolaescu
2008-12-20 18:37 ` Dan Nicolaescu
2008-12-20 20:41 ` Chong Yidong
2008-12-11 15:59 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LCRaz-0005OI-S2@etlken.m17n.org \
--to=handa@m17n.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).