From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: composition bug Date: Fri, 19 Sep 2008 11:29:55 +0900 Message-ID: References: <87hc8rn3ws.fsf@cyd.mit.edu> <87r67u3k52.fsf@elegiac.orebokech.com> <87iqt53mk7.fsf@elegiac.orebokech.com> <87zlmcxsq1.fsf@elegiac.orebokech.com> <87zlm86191.fsf@elegiac.orebokech.com> <87prn457u2.fsf@elegiac.orebokech.com> <873ajy603u.fsf@elegiac.orebokech.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1221791435 28046 80.91.229.12 (19 Sep 2008 02:30:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Sep 2008 02:30:35 +0000 (UTC) Cc: cyd@stupidchicken.com, romain@orebokech.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 19 04:31:31 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KgVmF-0000C7-4S for ged-emacs-devel@m.gmane.org; Fri, 19 Sep 2008 04:31:23 +0200 Original-Received: from localhost ([127.0.0.1]:59712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgVlC-0004P5-PC for ged-emacs-devel@m.gmane.org; Thu, 18 Sep 2008 22:30:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KgVl9-0004Oq-6a for emacs-devel@gnu.org; Thu, 18 Sep 2008 22:30:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KgVl3-0004OO-BV for emacs-devel@gnu.org; Thu, 18 Sep 2008 22:30:13 -0400 Original-Received: from [199.232.76.173] (port=59368 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgVl3-0004OL-7x for emacs-devel@gnu.org; Thu, 18 Sep 2008 22:30:09 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:54974) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KgVl2-0008Sv-Cg for emacs-devel@gnu.org; Thu, 18 Sep 2008 22:30:09 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id m8J2U0SK002174; Fri, 19 Sep 2008 11:30:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id m8J2U09f001957; Fri, 19 Sep 2008 11:30:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp2.aist.go.jp with ESMTP id m8J2TtJu019768; Fri, 19 Sep 2008 11:29:55 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1KgVkp-0002uB-7G; Fri, 19 Sep 2008 11:29:55 +0900 In-reply-to: (message from Stefan Monnier on Thu, 18 Sep 2008 02:08:02 -0400) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103956 Archived-At: In article , Stefan Monnier writes: > > I'm always confused by int and EMACS_INT. "struct it" and > > "struct text_pos" in dispextern.h uses "int" for > > buffer/string positions, and xdisp.c calls functions in > > composite.c with those values. So, there exist mixture of > > int and EMACS_INT. Shouldn't all of them use EMACS_INT for > > positions (and perhaps for string length)? > Yes. It's important for buffers (or strings) larger than 2GB. > We probably don't need to worry about strings larger than 2GB for a few > more years, but for buffers it's worthwhile to take it into account. As I don't have a time to work on it at the moment, I added this section in admin/FOR-RELEASE. ** In C, use EMACS_INT for variables and structure members for buffer/string positions. E.g. struct it, struct text_pos. --- Kenichi Handa handa@ni.aist.go.jp