From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: vc-git bug with top-level repositories Date: Fri, 29 Aug 2008 10:09:23 -0400 Message-ID: References: <200808181433.m7IEX8U3028640@sallyv1.ics.uci.edu> <200808181639.m7IGd1kb005968@sallyv1.ics.uci.edu> <200808182031.m7IKVbR7001754@sallyv1.ics.uci.edu> Reply-To: ams@gnu.org NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1220019086 30818 80.91.229.12 (29 Aug 2008 14:11:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Aug 2008 14:11:26 +0000 (UTC) Cc: claus.klingberg@gmail.com, eliz@gnu.org, dann@ics.uci.edu, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 29 16:12:19 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KZ4ho-00025A-0c for ged-emacs-devel@m.gmane.org; Fri, 29 Aug 2008 16:12:04 +0200 Original-Received: from localhost ([127.0.0.1]:58346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZ4gp-00042m-EX for ged-emacs-devel@m.gmane.org; Fri, 29 Aug 2008 10:11:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZ4gl-000409-8M for emacs-devel@gnu.org; Fri, 29 Aug 2008 10:10:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZ4gi-0003tS-Gu for emacs-devel@gnu.org; Fri, 29 Aug 2008 10:10:57 -0400 Original-Received: from [199.232.76.173] (port=33121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZ4gi-0003t6-5q for emacs-devel@gnu.org; Fri, 29 Aug 2008 10:10:56 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:54189) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZ4gi-0002Ei-42 for emacs-devel@gnu.org; Fri, 29 Aug 2008 10:10:56 -0400 Original-Received: from ams by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KZ4fD-0007gy-MU; Fri, 29 Aug 2008 10:09:23 -0400 In-reply-to: (message from Stefan Monnier on Wed, 27 Aug 2008 22:09:21 -0400) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103137 Archived-At: >> How about adding an extra check, where we check the write permissions >> as well for the user and group? That is, if the user and the group >> the user is member of, cannot write to the .git directory then we stop >> traversing... > I don't think this will fly: currently VC works even when you're looking > at a project to which you don't have write access, so neither the files > nor the .git might be writable. > AFAIK, atleast for git, you must have write access, if you do not you > cannot ceate a lock file. So you need write access even just to do things like diff or even just diff-index? That's too bad. So maybe for Git we could use that refinement of my heuristic, but it wouldn't help for other backends. I think for git diff you do not need write permissions, since that doesn't need to be atomic. I know that for some commands you need write access (git status comes to mind).