From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: vc-git bug with top-level repositories Date: Tue, 19 Aug 2008 16:07:33 -0400 Message-ID: References: <200808181433.m7IEX8U3028640@sallyv1.ics.uci.edu> <200808181639.m7IGd1kb005968@sallyv1.ics.uci.edu> <200808182031.m7IKVbR7001754@sallyv1.ics.uci.edu> Reply-To: ams@gnu.org NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1219176582 13129 80.91.229.12 (19 Aug 2008 20:09:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Aug 2008 20:09:42 +0000 (UTC) Cc: dann@ics.uci.edu, emacs-devel@gnu.org To: Claus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 19 22:10:34 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KVXX7-0002fV-KH for ged-emacs-devel@m.gmane.org; Tue, 19 Aug 2008 22:10:26 +0200 Original-Received: from localhost ([127.0.0.1]:60337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVXW9-0006Np-KJ for ged-emacs-devel@m.gmane.org; Tue, 19 Aug 2008 16:09:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVXVg-0006Eb-ON for emacs-devel@gnu.org; Tue, 19 Aug 2008 16:08:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVXVe-0006Do-Pz for emacs-devel@gnu.org; Tue, 19 Aug 2008 16:08:56 -0400 Original-Received: from [199.232.76.173] (port=48057 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVXVe-0006Dj-JY for emacs-devel@gnu.org; Tue, 19 Aug 2008 16:08:54 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:58361) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KVXVe-0001nb-4U for emacs-devel@gnu.org; Tue, 19 Aug 2008 16:08:54 -0400 Original-Received: from ams by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KVXUL-0000OF-QG; Tue, 19 Aug 2008 16:07:33 -0400 In-reply-to: (message from Claus on Tue, 19 Aug 2008 13:01:54 +0200) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102682 Archived-At: So I dug deeper and it seems like the culprit (at least in my situation) is in the function vc-find-root: Thank you for doing this. I'm not yet sure if this is a bug or a feature and will perhaps patch the code for myself once I've found a better solution (or understand why checking the owner would make sense - on Windows anyway). I think that the optimisation as is, is a bug. But not the gist of it. If the test is just to see if it is a git repo, then we can be lazy, and let git figure it out for us; executing `git status' will return non-zero for a git repo. In either case, I think the current code is wrong, you might have a shared repository among users, the initial creator is not the commiter.