unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Alfred M. Szmidt" <ams@gnu.org>
To: Claus <claus.klingberg@gmail.com>
Cc: dann@ics.uci.edu, emacs-devel@gnu.org
Subject: Re: vc-git bug with top-level repositories
Date: Tue, 19 Aug 2008 16:07:33 -0400	[thread overview]
Message-ID: <E1KVXUL-0000OF-QG@fencepost.gnu.org> (raw)
In-Reply-To: <fb5c9a920808190401y3b65e1b7v195de781e2bd00d0@mail.gmail.com> (message from Claus on Tue, 19 Aug 2008 13:01:54 +0200)

   So I dug deeper and it seems like the culprit (at least in my
   situation) is in the function vc-find-root:

Thank you for doing this.

   I'm not yet sure if this is a bug or a feature and will perhaps
   patch the code for myself once I've found a better solution (or
   understand why checking the owner would make sense - on Windows
   anyway).

I think that the optimisation as is, is a bug.  But not the gist of
it.  If the test is just to see if it is a git repo, then we can be
lazy, and let git figure it out for us; executing `git status' will
return non-zero for a git repo.

In either case, I think the current code is wrong, you might have a
shared repository among users, the initial creator is not the
commiter.




  parent reply	other threads:[~2008-08-19 20:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  9:17 vc-git bug with top-level repositories Alfred M. Szmidt
2008-08-18 14:33 ` Dan Nicolaescu
2008-08-18 16:24   ` Claus
2008-08-18 16:39     ` Dan Nicolaescu
2008-08-18 20:10       ` Claus
2008-08-18 20:31         ` Dan Nicolaescu
2008-08-19 11:01           ` Claus
2008-08-19 12:00             ` Paul R
2008-08-19 16:56               ` Dan Nicolaescu
2008-08-19 20:43                 ` Alfred M. Szmidt
2008-08-19 21:34                   ` Andreas Schwab
2008-08-20  2:22                     ` Miles Bader
2008-08-20  9:18                       ` Paul R
2008-08-19 18:46             ` Eli Zaretskii
2008-08-20 14:34               ` Stefan Monnier
2008-08-20 15:51                 ` Eli Zaretskii
     [not found]                   ` <86bpzn4qw2.fsf@lola.quinscape.zz>
2008-08-20 16:11                     ` Eli Zaretskii
2008-08-20 22:44                   ` Alfred M. Szmidt
2008-08-27 15:21                     ` Stefan Monnier
2008-08-27 21:17                       ` Alfred M. Szmidt
2008-08-28  2:09                         ` Stefan Monnier
2008-08-29  0:40                           ` Miles Bader
2008-08-29 14:09                           ` Alfred M. Szmidt
2008-08-27 15:24                   ` Stefan Monnier
2008-08-27 21:16                     ` Alfred M. Szmidt
2008-08-28  2:06                       ` Stefan Monnier
     [not found]                         ` <1219912261.8925.63.camel@ubuntu804desktop.localdomain>
     [not found]                           ` <jwvd4jt87g0.fsf-monnier+emacs@gnu.org>
2008-08-28 19:19                             ` Mathias Megyei
2008-08-29 20:12                               ` Claus
2008-10-25 15:20                               ` Stefan Monnier
2008-10-27 12:43                                 ` Mathias Megyei
2008-08-29 14:05                         ` Alfred M. Szmidt
2008-08-29 15:53                           ` Stefan Monnier
2008-08-19 20:07             ` Alfred M. Szmidt [this message]
2008-08-18 21:05   ` Alfred M. Szmidt
2008-08-18 21:18     ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KVXUL-0000OF-QG@fencepost.gnu.org \
    --to=ams@gnu.org \
    --cc=claus.klingberg@gmail.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).