From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.devel Subject: Re: Face initialization Date: Sun, 06 Jul 2008 14:47:26 -0400 Message-ID: References: <87skunbllv.fsf@stupidchicken.com> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1215370084 31887 80.91.229.12 (6 Jul 2008 18:48:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2008 18:48:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 06 20:48:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KFZI2-0005eN-9H for ged-emacs-devel@m.gmane.org; Sun, 06 Jul 2008 20:48:50 +0200 Original-Received: from localhost ([127.0.0.1]:41155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFZHB-0007j8-8c for ged-emacs-devel@m.gmane.org; Sun, 06 Jul 2008 14:47:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFZH6-0007j3-94 for emacs-devel@gnu.org; Sun, 06 Jul 2008 14:47:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFZH4-0007if-53 for emacs-devel@gnu.org; Sun, 06 Jul 2008 14:47:51 -0400 Original-Received: from [199.232.76.173] (port=43239 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFZH3-0007iT-T7 for emacs-devel@gnu.org; Sun, 06 Jul 2008 14:47:49 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:37675) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KFZH3-0001D4-HL for emacs-devel@gnu.org; Sun, 06 Jul 2008 14:47:49 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KFZGg-0003jd-Uz; Sun, 06 Jul 2008 14:47:26 -0400 In-reply-to: <87skunbllv.fsf@stupidchicken.com> (message from Chong Yidong on Sun, 06 Jul 2008 01:57:48 -0400) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100390 Archived-At: Also, the call to make-face-x-resource-internal seems to be unnecessary. SOMETHING needs to check for those X resources. Is it done elsewhere? Is this call redundant? I don't entirely understand what is going on in this change, but if you think that certain steps are unnecessary, please double check. It is easy to make mistakes in this code. - (if (face-attribute 'default :font t) - (set-face-attribute 'default frame :font - (face-attribute 'default :font t)) - (set-face-attribute 'default frame :family - (face-attribute 'default :family t)) - (set-face-attribute 'default frame :height - (face-attribute 'default :height t)) - (set-face-attribute 'default frame :slant - (face-attribute 'default :slant t)) - (set-face-attribute 'default frame :weight - (face-attribute 'default :weight t)) - (set-face-attribute 'default frame :width - (face-attribute 'default :width t))) The purpose of that code is to initialize `default' for this frame from the frame-independent face attributes. If this is done elsewhere, then maybe this code is not needed, but how about adding comments that explain all the overall logic for giving the faces the right settings?