Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Juanma Barranquero]

On Wed, Jun 25, 2008 at 04:56, Kenichi Handa <handa@m17n.org> wrote:

> -an error is signaled.
> +an error is signalled.

In fact, the single-l variants win over the double-l ones in the Emacs
sources about 4.5:1.

Moreover, "signaled/signaling" seems to be the U.S. spelling, which I
think is preferred in Emacs sources...

  Juanma


(Idle? Moi?)

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Kenichi Handa]

In article <f7ccd24b0806250402q4815b663pa2353fb0cb5b9bf7@mail.gmail.com>, "Juanma Barranquero" <lekktu@gmail.com> writes:

> On Wed, Jun 25, 2008 at 04:56, Kenichi Handa <handa@m17n.org> wrote:
> > -an error is signaled.
> > +an error is signalled.

> In fact, the single-l variants win over the double-l ones in the Emacs
> sources about 4.5:1.

> Moreover, "signaled/signaling" seems to be the U.S. spelling, which I
> think is preferred in Emacs sources...

Ah, I didn't know.  I did the above change because my ispell
told me so, but ok, I've just cancelled that change.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Richard M Stallman]

    > Moreover, "signaled/signaling" seems to be the U.S. spelling, which I
    > think is preferred in Emacs sources...

    Ah, I didn't know.  I did the above change because my ispell
    told me so, but ok, I've just cancelled that change.

If your Ispell dictionary doesn't have `signaled', how about
reporting that bug in the dictionary?

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Kenichi Handa]

In article <E1KBytm-0003eS-9M@fencepost.gnu.org>, Richard M Stallman <rms@gnu.org> writes:

> Moreover, "signaled/signaling" seems to be the U.S. spelling, which I
> think is preferred in Emacs sources...

>     Ah, I didn't know.  I did the above change because my ispell
>     told me so, but ok, I've just cancelled that change.

> If your Ispell dictionary doesn't have `signaled', how about
> reporting that bug in the dictionary?

Actually, M-$ on "signaled" shows this:

----------------------------------------------------------------------
Affix rules generate and capitalize this word as shown below:
	signal+ed
Use option `i' to accept this spelling and put it in your private dictionary.
(0) signalled  (1) signal ed  (3) signal-ed
----------------------------------------------------------------------

I read it as "signalled" is the most correct one.  But, as
I've just typed `i', M-$ doesn't complain about "signaled"
anymore.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Eli Zaretskii]

> From: Kenichi Handa <handa@m17n.org>
> Date: Fri, 27 Jun 2008 09:38:31 +0900
> Cc: lekktu@gmail.com, emacs-devel@gnu.org
> 
> Actually, M-$ on "signaled" shows this:
> 
> ----------------------------------------------------------------------
> Affix rules generate and capitalize this word as shown below:
> 	signal+ed
> Use option `i' to accept this spelling and put it in your private dictionary.
> (0) signalled  (1) signal ed  (3) signal-ed
> ----------------------------------------------------------------------

I didn't see this on my system, and "signaled" isn't in my private
dictionary.  Do you use Ispell or Aspell?

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Agustin Martin]

On Fri, Jun 27, 2008 at 11:55:48AM +0300, Eli Zaretskii wrote:
> > From: Kenichi Handa
> > 
> > Actually, M-$ on "signaled" shows this:
> > 
> > ----------------------------------------------------------------------
> > Affix rules generate and capitalize this word as shown below:
> > 	signal+ed
> > Use option `i' to accept this spelling and put it in your private dictionary.
> > (0) signalled  (1) signal ed  (3) signal-ed
> > ----------------------------------------------------------------------
> 
> I didn't see this on my system, and "signaled" isn't in my private
> dictionary.  Do you use Ispell or Aspell?

In my system (Debian/GNU), with the script I use to help the ispell
maintainer when people report missing words,

$ amd-test-missing-words signaled signalled
* Testing ispell english dicts:
  -  Missing in ibritish: signaled 
  + iamerican: OK
* Testing aspell english dicts:
  -  Missing in british: signaled 
  -  Missing in american: signalled 
* Testing plain english wordlists (look):
  + american-english: OK
  + american-english-large: OK
  + american-english-small: OK
  + american-english-huge: OK
  -  Missing in british-english: signaled
  -  Missing in british-english-large: signaled
  -  Missing in british-english-small: signaled
  -  Missing in british-english-huge: signaled
  -  Missing in canadian-english: signaled
  -  Missing in canadian-english-large: signaled
  -  Missing in canadian-english-small: signaled
  -  Missing in canadian-english-huge: signaled

On the one hand, seems that signalled is missing from aspell-en en_US Debian
dict, but in your case what happens is the opposite. Are you sure you are not
using the British dict?

-- 
Agustin

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Kenichi Handa]

In article <20080627093110.GA26163@agmartin.aq.upm.es>, Agustin Martin <agustin.martin@hispalinux.es> writes:

> On the one hand, seems that signalled is missing from aspell-en en_US Debian
> dict, but in your case what happens is the opposite. Are you sure you are not
> using the British dict?

I don't know.  The values of ispell-dictionary and
ispell-local-dictionary are both nil.  And my locale is
ja_JP.UTF-8.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Kenichi Handa]

In article <ufxqzdzor.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> > Actually, M-$ on "signaled" shows this:
> > 
> > ----------------------------------------------------------------------
> > Affix rules generate and capitalize this word as shown below:
> > 	signal+ed
> > Use option `i' to accept this spelling and put it in your private dictionary.
> > (0) signalled  (1) signal ed  (3) signal-ed
> > ----------------------------------------------------------------------

> I didn't see this on my system, and "signaled" isn't in my private
> dictionary.  Do you use Ispell or Aspell?

The value of ispell-program-name is "ispell".

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Eli Zaretskii]

> From: Kenichi Handa <handa@m17n.org>
> CC: emacs-devel@gnu.org
> Date: Fri, 27 Jun 2008 20:37:31 +0900
> 
> > I didn't see this on my system, and "signaled" isn't in my private
> > dictionary.  Do you use Ispell or Aspell?
> 
> The value of ispell-program-name is "ispell".

Yes, but what is "ispell"?  Is it a shell script that invokes Aspell,
or a binary program?  What does "ispell -vv" show?

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Kenichi Handa]

In article <u3amzdppc.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> Yes, but what is "ispell"?  Is it a shell script that invokes Aspell,
> or a binary program?  What does "ispell -vv" show?

Here is it.

% type ispell
ispell is hashed (/usr/X11R6/bin/ispell)
% file /usr/X11R6/bin/ispell
/usr/X11R6/bin/ispell: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), for GNU/Linux 2.6.1, dynamically linked (uses shared libs), stripped
% ispell -vv
@(#) International Ispell Version 3.1.20 10/10/95, patch 1
@(#) Copyright (c), 1983, by Pace Willisson
@(#) International version Copyright (c) 1987, 1988, 1990-1995,
@(#) by Geoff Kuenning, Granada Hills, CA.  All rights reserved.
@(#)
@(#) Redistribution and use in source and binary forms, with or without
@(#) modification, are permitted provided that the following conditions
@(#) are met:
@(#)
@(#) 1. Redistributions of source code must retain the above copyright
@(#)    notice, this list of conditions and the following disclaimer.
@(#) 2. Redistributions in binary form must reproduce the above
@(#)    copyright notice, this list of conditions and the following
@(#)    disclaimer in the documentation and/or other materials provided
@(#)    with the distribution.
@(#) 3. All modifications to the source code must be clearly marked as
@(#)    such.  Binary redistributions based on modified source code
@(#)    must be clearly marked as modified versions in the documentation
@(#)    and/or other materials provided with the distribution.
@(#) 4. All advertising materials mentioning features or use of this
@(#)    software must display the following acknowledgment:
@(#)      This product includes software developed by Geoff Kuenning and
@(#)      other unpaid contributors.
@(#) 5. The name of Geoff Kuenning may not be used to endorse or promote
@(#)    products derived from this software without specific prior
@(#)    written permission.
@(#)
@(#) THIS SOFTWARE IS PROVIDED BY GEOFF KUENNING AND CONTRIBUTORS ``AS
@(#) IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
@(#) LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
@(#) FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL GEOFF
@(#) KUENNING OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
@(#) INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
@(#) (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
@(#) SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
@(#) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
@(#) STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
@(#) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
@(#) OF THE POSSIBILITY OF SUCH DAMAGE.
Compiled-in options:
	USG
	BAKEXT = ".bak"
	BINDIR = "/usr/bin"
	!BOTTOMCONTEXT
	CBREAK
	CC = "gcc"
	CFLAGS = "-O2 -s -g"
	!COMMANDFORSPACE
	!CONTEXTROUNDUP
	CONTEXTPCT = 10
	COUNTSUFFIX = ".cnt"
	DEFHASH = "default.hash"
	DEFINCSTR = "&Include_File&"
	DEFLANG = "default.aff"
	DEFNOBACKUPFLAG = 0
	DEFPAFF = "words"
	DEFPDICT = ".ispell_"
	DEFTEXFLAG = 0
	EGREPCMD = "/bin/egrep"
	ELISPDIR = "/usr/lib/emacs/site-lisp"
	EMACS = "emacs"
	!EQUAL_COLUMNS
	!GENERATE_LIBRARY_PROTOS
	HAS_RENAME
	HASHSUFFIX = ".hash"
	HOME = "HOME"
	!IGNOREBIB
	INCSTRVAR = "INCLUDE_STRING"
	INPUTWORDLEN = 100
	LANGUAGES = "{british,MASTERDICTS=british.med+,HASHFILES=britishmed+.hash,EXTRADICT=/usr/share/dict/british-english} {american,MASTERDICTS=american.med+,HASHFILES=americanmed+.hash,EXTRADICT=/usr/share/dict/american-english}"
	LIBDIR = "/usr/lib/ispell"
	LIBES = ""
	LINT = "lint"
	LINTFLAGS = ""
	LOOK = "look -df"
	MAKE_SORTTMP = "-T ${TMPDIR-/usr/tmp}"
	MALLOC_INCREMENT = 4088
	MAN1DIR = "/usr/share/man/man1"
	MAN1EXT = ".1"
	MAN4DIR = "/usr/local/man/man4"
	MAN4EXT = ".4"
	MASKBITS = 64
	MASKTYPE = long
	MASKTYPE_WIDTH = 32
	MASTERHASH = "britishmed+.hash"
	MAXAFFIXLEN = 20
	MAXCONTEXT = 10
	MAXINCLUDEFILES = 5
	MAXNAMLEN = 1024
	MAXPATHLEN = 4096
	MAXPCT = 70
	MAXSEARCH = 4
	MAXSTRINGCHARLEN = 10
	MAXSTRINGCHARS = 128
	MAX_CAPS = 10
	MAX_HITS = 10
	MAX_SCREEN_SIZE = 0
	MINCONTEXT = 2
	MINIMENU
	MINWORD = 1
	MSDOS_BINARY_OPEN = 0x0
	MSGLANG = english
	!NO_CAPITALIZATION_SUPPORT
	!NO_STDLIB_H (STDLIB_H)
	!NO8BIT (8BIT)
	NRSPECIAL = "().\*"
	OLDPAFF = "words"
	OLDPDICT = ".ispell_"
	PDICTHOME = (undefined)
	PDICTVAR = "WORDLIST"
	!PIECEMEAL_HASH_WRITES
	!REGEX_LOOKUP
	REGLIB = ""
	SIGNAL_TYPE = void
	SORTPERSONAL = 1000
	STATSUFFIX = ".stat"
	TEMPNAME = "/tmp/ispellXXXXXX"
	TERMLIB = "-lncurses"
	TEXINFODIR = "/usr/share/info"
	TEXSPECIAL = "()[]{}<>\$*.%"
	!TRUNCATEBAK
	!USESH
	WORDS = "/usr/share/dict/words"
	YACC = "yacc"

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Eli Zaretskii]

> From: Kenichi Handa <handa@m17n.org>
> CC: emacs-devel@gnu.org
> Date: Fri, 27 Jun 2008 21:49:01 +0900
> 
> In article <u3amzdppc.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Yes, but what is "ispell"?  Is it a shell script that invokes Aspell,
> > or a binary program?  What does "ispell -vv" show?
> 
> Here is it.
> 
> % type ispell
> ispell is hashed (/usr/X11R6/bin/ispell)
> % file /usr/X11R6/bin/ispell
> /usr/X11R6/bin/ispell: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), for GNU/Linux 2.6.1, dynamically linked (uses shared libs), stripped

So this is indeed Ispell...

> 	LANGUAGES = "{british,MASTERDICTS=british.med+,HASHFILES=britishmed+.hash,EXTRADICT=/usr/share/dict/british-english} {american,MASTERDICTS=american.med+,HASHFILES=americanmed+.hash,EXTRADICT=/usr/share/dict/american-english}"

...and this part says that the British dictionary is your default one.
You could verify this by comparing the files default.hash and
britishmed+.hash (I expect the former to be the hard link to the
latter).  So try changing that to "american" (you can do that in
Emacs, by one of the customizations offered by ispell.el).

Re: [Emacs-diffs] Changes to emacs/src/fns.c,v

[Nick Roberts]

 >     > Moreover, "signaled/signaling" seems to be the U.S. spelling, which I
 >     > think is preferred in Emacs sources...
 > 
 >     Ah, I didn't know.  I did the above change because my ispell
 >     told me so, but ok, I've just cancelled that change.
 > 
 > If your Ispell dictionary doesn't have `signaled', how about
 > reporting that bug in the dictionary?

Stepping outside the confines of Emacs, it's hardly a bug.  It's unfortunate
that American English, not content with introducing it's own spelling of
English words, should also rule that the existing spelling is wrong.  Any
reader of English texts, of course, will have to recognize (sic.) both.

-- 
Nick                                           http://www.inet.net.nz/~nickrob