From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Window-groups Date: Mon, 23 Jun 2008 10:14:42 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1214230657 16479 80.91.229.12 (23 Jun 2008 14:17:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Jun 2008 14:17:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 23 16:18:22 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KAms9-0002yP-OH for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 16:18:22 +0200 Original-Received: from localhost ([127.0.0.1]:39844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAmrK-00074h-D8 for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 10:17:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KAmol-0005ji-Je for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KAmoi-0005gz-J4 for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:51 -0400 Original-Received: from [199.232.76.173] (port=40056 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAmoi-0005gk-Av for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:48 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33305) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KAmoi-0003z9-GV for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:48 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KAmoc-00067c-Kv; Mon, 23 Jun 2008 10:14:42 -0400 In-reply-to: (joakim@verona.se) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99782 Archived-At: Please stick to our coding style. Please follow the conventions of spacing and indentation that are used throughout the code. case DELETE_OTHER_WINDOWS: - if (!EQ (window, obj)) + if (!EQ (window, obj) ) There shouldn't be a space between two closeparens. + if(!NILP(Fwindow_parameter(window, Qgroup))) Please put spaces before all those openparens. Likewise in the many similar cases. The only time an openparen should have no preceding space is when it follows another openparen or an openbracket or a unary operator. + foreach_window_1 (XWINDOW (FRAME_ROOT_WINDOW (f)), fn, user_data,allwindows); Please put a space after every comma. + else{ Please put the open brace on a separate line. Please do not mess up the code by introducing variation in these style questions. Please don't leave it to someone else to fix these things.