From: Richard M Stallman <rms@gnu.org>
To: joakim@verona.se
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Window-groups
Date: Mon, 23 Jun 2008 10:14:42 -0400 [thread overview]
Message-ID: <E1KAmoc-00067c-Kv@fencepost.gnu.org> (raw)
In-Reply-To: <m31w2p2srj.fsf@verona.se> (joakim@verona.se)
Please stick to our coding style. Please follow the conventions of
spacing and indentation that are used throughout the code.
case DELETE_OTHER_WINDOWS:
- if (!EQ (window, obj))
+ if (!EQ (window, obj) )
There shouldn't be a space between two closeparens.
+ if(!NILP(Fwindow_parameter(window, Qgroup)))
Please put spaces before all those openparens. Likewise in the many
similar cases. The only time an openparen should have no preceding
space is when it follows another openparen or an openbracket or a
unary operator.
+ foreach_window_1 (XWINDOW (FRAME_ROOT_WINDOW (f)), fn, user_data,allwindows);
Please put a space after every comma.
+ else{
Please put the open brace on a separate line.
Please do not mess up the code by introducing variation in these style
questions. Please don't leave it to someone else to fix these things.
next prev parent reply other threads:[~2008-06-23 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 19:07 [PATCH] Window-groups joakim
2008-06-23 14:14 ` Richard M Stallman
2008-06-23 14:14 ` Richard M Stallman
2008-06-23 14:14 ` Richard M Stallman [this message]
2008-06-23 14:29 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KAmoc-00067c-Kv@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).