From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Underlining text including U+00F6, U+00E4 Date: Sat, 24 May 2008 08:32:16 +0900 Message-ID: References: <20080522125825.8F2F2889A35@mt-computer.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1211585571 13865 80.91.229.12 (23 May 2008 23:32:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 May 2008 23:32:51 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, markus.triska@gmx.at To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 24 01:33:27 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JzglK-0002x8-H9 for ged-emacs-devel@m.gmane.org; Sat, 24 May 2008 01:33:26 +0200 Original-Received: from localhost ([127.0.0.1]:55614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzgkZ-0007tc-M0 for ged-emacs-devel@m.gmane.org; Fri, 23 May 2008 19:32:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JzgkU-0007qX-Mf for emacs-devel@gnu.org; Fri, 23 May 2008 19:32:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JzgkT-0007oD-CJ for emacs-devel@gnu.org; Fri, 23 May 2008 19:32:34 -0400 Original-Received: from [199.232.76.173] (port=36378 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzgkT-0007o1-3M for emacs-devel@gnu.org; Fri, 23 May 2008 19:32:33 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:59380) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JzgkT-00046S-DD for emacs-devel@gnu.org; Fri, 23 May 2008 19:32:33 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]:34351) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Jzgj4-0003Y2-3z for emacs-pretest-bug@gnu.org; Fri, 23 May 2008 19:31:06 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JzgkM-00045b-NH for emacs-pretest-bug@gnu.org; Fri, 23 May 2008 19:32:32 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:50789) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JzgkM-00045J-2z for emacs-pretest-bug@gnu.org; Fri, 23 May 2008 19:32:26 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id m4NNWHB0006852; Sat, 24 May 2008 08:32:17 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id m4NNWHQV014019; Sat, 24 May 2008 08:32:17 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id m4NNWGVZ015414; Sat, 24 May 2008 08:32:16 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1JzgkC-0005TM-3X; Sat, 24 May 2008 08:32:16 +0900 In-reply-to: (message from YAMAMOTO Mitsuharu on Fri, 23 May 2008 20:40:47 +0900) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97627 gmane.emacs.pretest.bugs:22437 Archived-At: In article , YAMAMOTO Mitsuharu writes: > Isn't `position' supposed to be relative to the baseline? If so, > these lines in xterm.c seems to be wrong. > 2727 if (x_underline_at_descent_line) > 2728 position = (s->height - thickness) - s->ybase; > 2748 if (s->y + s->height <= s->ybase + position) > 2749 position = s->y + s->height - 1; Oops, thank you for pointing out that. You are right. But, as I'm now at home, and can't commit a fix. I'll fix it next week, or if you can, please go ahead. --- Kenichi Handa handa@ni.aist.go.jp