From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Memory leak Date: Mon, 19 May 2008 20:13:15 +0900 Message-ID: References: <85lk2b1829.fsf@lola.goethe.zz> <482CD48E.3020601@gmail.com> <482D8332.5030908@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1211195648 6269 80.91.229.12 (19 May 2008 11:14:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2008 11:14:08 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org, lennart.borgman@gmail.com, monnier@IRO.UMontreal.CA, jasonr@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 19 13:14:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jy3K1-0000ev-Vo for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 13:14:30 +0200 Original-Received: from localhost ([127.0.0.1]:53143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jy3JH-0008LM-QT for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 07:13:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jy3JB-0008KZ-Fg for emacs-devel@gnu.org; Mon, 19 May 2008 07:13:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jy3JA-0008K3-Ba for emacs-devel@gnu.org; Mon, 19 May 2008 07:13:36 -0400 Original-Received: from [199.232.76.173] (port=49958 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jy3JA-0008Jy-1L for emacs-devel@gnu.org; Mon, 19 May 2008 07:13:36 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:61904) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jy3J0-0001o5-Ha; Mon, 19 May 2008 07:13:27 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id m4JBDJw0029730; Mon, 19 May 2008 20:13:19 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id m4JBDI9k014036; Mon, 19 May 2008 20:13:18 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp2.aist.go.jp with ESMTP id m4JBDFnc025043; Mon, 19 May 2008 20:13:15 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1Jy3Ip-0004xU-GG; Mon, 19 May 2008 20:13:15 +0900 In-reply-to: (message from YAMAMOTO Mitsuharu on Mon, 19 May 2008 17:45:03 +0900) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97388 Archived-At: In article , YAMAMOTO Mitsuharu writes: >>>>>> On Mon, 19 May 2008 17:05:42 +0900, Kenichi Handa said: > > I've just installed a fix in font-cache handling. > It seems like the `free_entity' entry in `struct font_driver' no > longer makes sense because you tried to remove the memory leaks by > avoiding Lisp_Save_Value in font entities instead of calling > free_entity at some proper timings. Is that right? Not exactly. When I deleted ftfont_free_entity, it was in my mind to change also ftfont_list to avoid using Lisp_Save_Value, but I just forgot to implement that change. The free_entity callback is still called in font_clear_cache if a font-driver provides that function. --- Kenichi Handa handa@ni.aist.go.jp