From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: font-backend branch Date: Fri, 02 May 2008 19:55:49 +0900 Message-ID: References: <48190539.4010508@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1209725779 22356 80.91.229.12 (2 May 2008 10:56:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 May 2008 10:56:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 02 12:56:54 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jrswe-00039i-Kh for ged-emacs-devel@m.gmane.org; Fri, 02 May 2008 12:56:52 +0200 Original-Received: from localhost ([127.0.0.1]:54818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jrsvx-0000N1-CL for ged-emacs-devel@m.gmane.org; Fri, 02 May 2008 06:56:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jrsvs-0000Mt-Sj for emacs-devel@gnu.org; Fri, 02 May 2008 06:56:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jrsvq-0000ML-Ci for emacs-devel@gnu.org; Fri, 02 May 2008 06:56:04 -0400 Original-Received: from [199.232.76.173] (port=48016 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jrsvq-0000MI-4g for emacs-devel@gnu.org; Fri, 02 May 2008 06:56:02 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jrsvj-0004PI-OM; Fri, 02 May 2008 06:55:56 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id m42Atoi2028700; Fri, 2 May 2008 19:55:50 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id m42Atora013176; Fri, 2 May 2008 19:55:50 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp2.aist.go.jp with ESMTP id m42Atn90002631; Fri, 2 May 2008 19:55:49 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1Jrsvd-0007WA-A3; Fri, 02 May 2008 19:55:49 +0900 In-reply-to: <48190539.4010508@gnu.org> (message from Jason Rumney on Thu, 01 May 2008 00:48:09 +0100) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96318 Archived-At: In article <48190539.4010508@gnu.org>, Jason Rumney writes: > The new code seems to be making a poor choice of font for Latin-1 > characters, it is choosing a symbol font which does not contain the > characters for me. This was triggering a bug that is also present in the > trunk which caused the crash that Juanma experienced. The choice of font > for other Latin characters is also not optimal, as the font used for > ASCII contains most of these characters, but in the font-backend branch > other fonts are chosen. To understand why a correct font can't be used on Windows, I must track the code of fontset by gdb, but at the moment, I can't build Emacs correctly on Windows even with these gcc and gmake: C:\cygwin\home\handa\emacs-fb\nt>make --version GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. This program built for i386-pc-mingw32 C:\cygwin\home\handa\emacs-fb\nt>gcc --version gcc (GCC) 3.4.5 (mingw special) Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > In addition to the bug mentioned above, I got another crash while > displaying etc/HELLO which was caused by using s->face->font in > w32font_draw. Changing it to use s->font works, but I have no idea what > the difference is between these two, and why s->face->font would be NULL > while s->font points to a valid font. I found that I made a silly mistake when I modified w32term.c. So, I've just installed the attached change. But, anyway, w32font_draw should use s->font instead of s->face->font because the latter may not be correct when a text is shown with mouse-face. --- Kenichi Handa handa@ni.aist.go.jp *** w32term.c.~1.285.2.1.~ 2008-04-30 10:45:07.000000000 +0900 --- w32term.c 2008-05-02 17:09:25.000000000 +0900 *************** *** 1900,1906 **** x += g->pixel_width; } } ! { int boff = s->font->baseline_offset; struct font *font = s->font; --- 1900,1906 ---- x += g->pixel_width; } } ! else { int boff = s->font->baseline_offset; struct font *font = s->font;