23.0.60; uid problems on w32

23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

I have got at bug report from Thierry Daucourt through

   http://www.emacswiki.org/cgi-bin/wiki/EmacsW32

It looks like this could be a bug in Emacs. The crucial part of that bug 
report are the values investigated at the end of 
`server-ensure-safe-dir' where the user get the following for 
file-attributes and user-id:

  attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0 
drwxrwxrwx
  nil 34842 (7173 . 33003))
  nth 2 attrs **-14706**
  user id **50830**

He also checked with Cygwin which gave other values than the two 
different above for the uid:

  $ ls -ld server/
  drwxr-xr-x+ 2 my_user mkgroup-l-d 0 Mar 29 14:35 server/
  $ id
  uid=**60830**(my_user) gid=10545(mkgroup-l-d) 
groups=0(root),544(Administrators),545(Users),10545(mkgroup-l-d)


If I do not misunderstand him he has got these values from the unpatched 
version below.

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
  of 2008-03-25

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> I have got at bug report from Thierry Daucourt through
>
>   http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>
> It looks like this could be a bug in Emacs. The crucial part of that 
> bug report are the values investigated at the end of 
> `server-ensure-safe-dir' where the user get the following for 
> file-attributes and user-id:
>
>  attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0 
> drwxrwxrwx
>  nil 34842 (7173 . 33003))
>  nth 2 attrs **-14706**
>  user id **50830**

It appears the directory in question was created by a different user.
Do you have the original report? There may be more information in there.

>
> He also checked with Cygwin which gave other values than the two 
> different above for the uid:

I've got no idea what Cygwin does to emulate posix uids on Windows, so 
it is not surprising that it gets different results.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> I have got at bug report from Thierry Daucourt through
>>
>>   http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>>
>> It looks like this could be a bug in Emacs. The crucial part of that 
>> bug report are the values investigated at the end of 
>> `server-ensure-safe-dir' where the user get the following for 
>> file-attributes and user-id:
>>
>>  attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0 
>> drwxrwxrwx
>>  nil 34842 (7173 . 33003))
>>  nth 2 attrs **-14706**
>>  user id **50830**
> 
> It appears the directory in question was created by a different user.
> Do you have the original report? There may be more information in there.

This is what I got at the moment. I have asked for what Windows Explorer 
shows too. If you want more information please see the web page.

>> He also checked with Cygwin which gave other values than the two 
>> different above for the uid:
> 
> I've got no idea what Cygwin does to emulate posix uids on Windows, so 
> it is not surprising that it gets different results.

I tested with Cygwin on my pc and it looks like expected there. All uid 
values are equal: (nth 2 attrs), (user-uid) in server-ensure-safe-dir 
and the output from cygwin id. ls -l shows the same name as cygwin id.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> This is what I got at the moment. I have asked for what Windows 
> Explorer shows too. If you want more information please see the web page.

If you have more information, please send it here.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> This is what I got at the moment. I have asked for what Windows 
>> Explorer shows too. If you want more information please see the web page.
> 
> If you have more information, please send it here.

I have sent all information I have found relevant. If I get more I will 
send it here.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 03:07:42 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> Cc: emacs-pretest-bug@gnu.org
> 
> I tested with Cygwin on my pc and it looks like expected there. All uid 
> values are equal: (nth 2 attrs), (user-uid) in server-ensure-safe-dir 
> and the output from cygwin id. ls -l shows the same name as cygwin id.

What do you mean by ``tested with Cygwin''?  Was it a Cygwin build of
Emacs or something else?

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Sun, 30 Mar 2008 03:07:42 +0200
>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>> Cc: emacs-pretest-bug@gnu.org
>>
>> I tested with Cygwin on my pc and it looks like expected there. All uid 
>> values are equal: (nth 2 attrs), (user-uid) in server-ensure-safe-dir 
>> and the output from cygwin id. ls -l shows the same name as cygwin id.
> 
> What do you mean by ``tested with Cygwin''?  Was it a Cygwin build of
> Emacs or something else?

Sorry. I meant that I tested "ls -l" and "id" in Cygwin. Emacs is a w32 
build done with gcc.

Re: 23.0.60; uid problems on w32

[Stefan Monnier]

>> I have got at bug report from Thierry Daucourt through
>> 
>> http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>> 
>> It looks like this could be a bug in Emacs. The crucial part of that bug
>> report are the values investigated at the end of `server-ensure-safe-dir'
>> where the user get the following for file-attributes and user-id:
>> 
>> attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797)
>> 0 drwxrwxrwx
>> nil 34842 (7173 . 33003))
>> nth 2 attrs **-14706**
>> user id **50830**

> It appears the directory in question was created by a different user.

Are you sure?  (+ 50830 14706) == 65536, so the two numbers are
equal module 2^16.  I.e. one is "signed int16" and the other is
"unsigned int16".


        Stefan

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sun, 30 Mar 2008 00:14:35 -0400
> Cc: emacs-pretest-bug@gnu.org,
> 	"Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>
> 
> >> attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797)
> >> 0 drwxrwxrwx
> >> nil 34842 (7173 . 33003))
> >> nth 2 attrs **-14706**
> >> user id **50830**
> 
> > It appears the directory in question was created by a different user.
> 
> Are you sure?  (+ 50830 14706) == 65536, so the two numbers are
> equal module 2^16.  I.e. one is "signed int16" and the other is
> "unsigned int16".

Actually, one (in `struct passwd') is `signed int', the other (in
`struct stat') is `signed short'.  Darn that MS-supplied stat.h!

Yes, this is probably the reason.

Jason, do we have any good reasons to use `struct stat' as declared on
the system header?  If not, I'd say let's roll our own, and be done
with this ugliness.  (It will also help us stop the bit-juggling we do
to squeeze a 48-bit file index into a 16-bit st_ino.

I'm still clueless about why Cygwin shows 60830, while we show 50830.
Ideas, anyone?

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Eli Zaretskii wrote:
> Actually, one (in `struct passwd') is `signed int', the other (in
> `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
>
> Yes, this is probably the reason.
>
> Jason, do we have any good reasons to use `struct stat' as declared on
> the system header?

Not that I'm aware, but I'm probably less familiar with that code than 
you are.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 15:02:27 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-pretest-bug@gnu.org, 
>  lennart.borgman@gmail.com
> 
> Eli Zaretskii wrote:
> > Actually, one (in `struct passwd') is `signed int', the other (in
> > `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
> >
> > Yes, this is probably the reason.
> >
> > Jason, do we have any good reasons to use `struct stat' as declared on
> > the system header?
> 
> Not that I'm aware, but I'm probably less familiar with that code than 
> you are.

OK, I will add this to my todo.  Thanks.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Eli Zaretskii wrote:
>> Eli Zaretskii wrote:
>>     
>>> Actually, one (in `struct passwd') is `signed int', the other (in
>>> `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
>>>       
>
> OK, I will add this to my todo.  Thanks.
>   

I have just checked in a hack to Ffile_attributes that casts the uid in 
the stat structure to unsigned short on windows to make it consistent 
with getuid.
You'll need to remove this hack if/when you make the above more 
comprehensive change. I think the current %= 60001 in several places in 
w32.c where uid and gid are initialised will be able to be removed once 
you have made this change too.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 15:28:15 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org, 
>  lennart.borgman@gmail.com
> 
> I have just checked in a hack to Ffile_attributes that casts the uid in 
> the stat structure to unsigned short on windows to make it consistent 
> with getuid.

Thanks.

> You'll need to remove this hack if/when you make the above more 
> comprehensive change.

Will do.

> I think the current %= 60001 in several places in 
> w32.c where uid and gid are initialised will be able to be removed once 
> you have made this change too.

Yes, agreed.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 22:29:25 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-pretest-bug@gnu.org, lennart.borgman@gmail.com,
> 	monnier@iro.umontreal.ca
> 
> > I think the current %= 60001 in several places in 
> > w32.c where uid and gid are initialised will be able to be removed once 
> > you have made this change too.
> 
> Yes, agreed.

Done (on the trunk).

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 15:28:15 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org, 
>  lennart.borgman@gmail.com
> 
> Eli Zaretskii wrote:
> >> Eli Zaretskii wrote:
> >>     
> >>> Actually, one (in `struct passwd') is `signed int', the other (in
> >>> `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
> >>>       
> >
> > OK, I will add this to my todo.  Thanks.
> >   
> 
> I have just checked in a hack to Ffile_attributes that casts the uid in 
> the stat structure to unsigned short on windows to make it consistent 
> with getuid.
> You'll need to remove this hack if/when you make the above more 
> comprehensive change.

You did that on the release branch.  I don't think we should begin
using our own sys/stat.h on the branch, so this change will probably
stay there.

We should probably backport to the branch another similar change in
dired.c, the one that forces inode numbers to be positive; it is now
only on the trunk.  Any objections?

Re: 23.0.60; uid problems on w32

[Stefan Monnier]

> We should probably backport to the branch another similar change in
> dired.c, the one that forces inode numbers to be positive; it is now
> only on the trunk.  Any objections?

Sounds good to me,


        Stefan

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Jason Rumney <jasonr@gnu.org>,  emacs-pretest-bug@gnu.org,  lennart.borgman@gmail.com
> Date: Sat, 05 Apr 2008 14:40:27 -0400
> 
> > We should probably backport to the branch another similar change in
> > dired.c, the one that forces inode numbers to be positive; it is now
> > only on the trunk.  Any objections?
> 
> Sounds good to me,

Done.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 15:02:27 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-pretest-bug@gnu.org, 
>  lennart.borgman@gmail.com
> 
> Eli Zaretskii wrote:
> > Actually, one (in `struct passwd') is `signed int', the other (in
> > `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
> >
> > Yes, this is probably the reason.
> >
> > Jason, do we have any good reasons to use `struct stat' as declared on
> > the system header?
> 
> Not that I'm aware, but I'm probably less familiar with that code than 
> you are.

Okay, I've committed to the trunk several changes to remove dependence
on the CRT definition of `struct stat'.  There's now a new file
nt/inc/sys/stat.h that is used instead.  Windows users, please try
this and report any problems you see, especially if you use MSVC to
compile Emacs, as I don't have Visual Studio installed and could not
test with it.

As the result of these changes, file-attributes and its ilk will now
return a 3-member cons cell when the inode number does not fit into a
32-bit datum; see the doc string of file-attributes for details.  If
someone thinks this could mean trouble for Lisp code that uses
file-attributes, please tell the details.  (I already fixed ls-lisp.el
to handle this, so this one is not the problem.)

The user-visible changes due to this (limited to Windows) are:

 . inode numbers are now very large (as this is what Windows reports);
   try "C-u C-x d i RET RET", i.e. invoke Dired with -ali as switches
   to the (emulated) `ls'.  Also, inodes should never be negative, and
   they should be identical to what "ls -i" reports from the command
   line.

 . uid and gid are no longer restricted to 16-bit numbers, and should
   never be negative; try "C-u C-x d DEL n RET RET", i.e. invoke Dired
   with -an as switches to `ls' emulation.

Note that I didn't yet add to our emulation of `stat' support for
Windows native owner's user and group id of files; this will be done
later, when all the dust from this change settles.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Eli Zaretskii wrote:
> I'm still clueless about why Cygwin shows 60830, while we show 50830.
> Ideas, anyone?
>   

Cygwin adds 10000 to domain uid and gids to avoid clashes with local ids.

http://cygwin.com/ml/cygwin-developers/2001-04/msg00048.html
http://cygwin.com/ml/cygwin-patches/2001-q2/msg00043.html

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 15:48:06 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-pretest-bug@gnu.org, 
>  lennart.borgman@gmail.com
> 
> Eli Zaretskii wrote:
> > I'm still clueless about why Cygwin shows 60830, while we show 50830.
> > Ideas, anyone?
> >   
> 
> Cygwin adds 10000 to domain uid and gids to avoid clashes with local ids.

Thanks, this unlocks the mystery.  (Sounds like 10K is not large
enough, though, since if the uid can be as large as 50830, it can
easily be 10K larger as well.)

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Eli Zaretskii wrote:
>> I'm still clueless about why Cygwin shows 60830, while we show 50830.
>> Ideas, anyone?
>>   
> 
> Cygwin adds 10000 to domain uid and gids to avoid clashes with local ids.
> 
> http://cygwin.com/ml/cygwin-developers/2001-04/msg00048.html
> http://cygwin.com/ml/cygwin-patches/2001-q2/msg00043.html

But that does not happen in my case where id is 1003 both in 
server-ensure-safe-dir and cygwin id.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 17:27:59 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> CC: Eli Zaretskii <eliz@gnu.org>, 
>  Stefan Monnier <monnier@iro.umontreal.ca>,
>  emacs-pretest-bug@gnu.org
> 
> Jason Rumney wrote:
> > Eli Zaretskii wrote:
> >> I'm still clueless about why Cygwin shows 60830, while we show 50830.
> >> Ideas, anyone?
> >>   
> > 
> > Cygwin adds 10000 to domain uid and gids to avoid clashes with local ids.
> > 
> > http://cygwin.com/ml/cygwin-developers/2001-04/msg00048.html
> > http://cygwin.com/ml/cygwin-patches/2001-q2/msg00043.html
> 
> But that does not happen in my case where id is 1003 both in 
> server-ensure-safe-dir and cygwin id.

That's because your uid is of a local user, not of a domain user.

Domain users are defined by a prefix in the SID that is different from
the prefix of the local machine.  The way we (and Cygwin) map SIDs to
a uid is by throwing away the prefix and keeping only the last part --
the so-called RID, the relative ID -- which is okay as long as the
prefix is identical for all users.  But once users defined in the
domain server come into play, you could have 2 different users -- one
local, the other domain user -- with the same RID.  That is what
Cygwin is trying to avoid.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Sun, 30 Mar 2008 17:27:59 +0200
>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>> CC: Eli Zaretskii <eliz@gnu.org>, 
>>  Stefan Monnier <monnier@iro.umontreal.ca>,
>>  emacs-pretest-bug@gnu.org
>>
>> Jason Rumney wrote:
>>> Eli Zaretskii wrote:
>>>> I'm still clueless about why Cygwin shows 60830, while we show 50830.
>>>> Ideas, anyone?
>>>>   
>>> Cygwin adds 10000 to domain uid and gids to avoid clashes with local ids.
>>>
>>> http://cygwin.com/ml/cygwin-developers/2001-04/msg00048.html
>>> http://cygwin.com/ml/cygwin-patches/2001-q2/msg00043.html
>> But that does not happen in my case where id is 1003 both in 
>> server-ensure-safe-dir and cygwin id.
> 
> That's because your uid is of a local user, not of a domain user.

Thanks.

> Domain users are defined by a prefix in the SID that is different from
> the prefix of the local machine.  The way we (and Cygwin) map SIDs to
> a uid is by throwing away the prefix and keeping only the last part --
> the so-called RID, the relative ID -- which is okay as long as the
> prefix is identical for all users.  But once users defined in the
> domain server come into play, you could have 2 different users -- one
> local, the other domain user -- with the same RID.  That is what
> Cygwin is trying to avoid.

But why is the prefix thrown away?

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 22:33:58 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
> 
> > Domain users are defined by a prefix in the SID that is different from
> > the prefix of the local machine.  The way we (and Cygwin) map SIDs to
> > a uid is by throwing away the prefix and keeping only the last part --
> > the so-called RID, the relative ID -- which is okay as long as the
> > prefix is identical for all users.  But once users defined in the
> > domain server come into play, you could have 2 different users -- one
> > local, the other domain user -- with the same RID.  That is what
> > Cygwin is trying to avoid.
> 
> But why is the prefix thrown away?

Because it's too large to fit in any reasonably wide variable.  For
example, the full SID of my user account on the machine where I'm
typing this is comprised of 7 numbers:

      1 5 21 790525478 299502267 682003330 1004

This SID is unique in the entire world, i.e. no other user or group or
any other object on any Windows system can ever have such a SID.
However, using an array for a uid is very inconvenient and will
probably break many Posix programs that assume a scalar data type.
And if we were to generate a scalar out of these numbers (each one of
them is a 32-bit word), it would be too wide for current machines.  So
we exploit the fact that on a given computer, the first 4 components
of the SID are common to all accounts, and use only the last one which
is different for each user.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Sun, 30 Mar 2008 22:33:58 +0200
>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
>>
>>> Domain users are defined by a prefix in the SID that is different from
>>> the prefix of the local machine.  The way we (and Cygwin) map SIDs to
>>> a uid is by throwing away the prefix and keeping only the last part --
>>> the so-called RID, the relative ID -- which is okay as long as the
>>> prefix is identical for all users.  But once users defined in the
>>> domain server come into play, you could have 2 different users -- one
>>> local, the other domain user -- with the same RID.  That is what
>>> Cygwin is trying to avoid.
>> But why is the prefix thrown away?
> 
> Because it's too large to fit in any reasonably wide variable.  For
> example, the full SID of my user account on the machine where I'm
> typing this is comprised of 7 numbers:
> 
>       1 5 21 790525478 299502267 682003330 1004
> 
> This SID is unique in the entire world, i.e. no other user or group or
> any other object on any Windows system can ever have such a SID.
> However, using an array for a uid is very inconvenient and will
> probably break many Posix programs that assume a scalar data type.
> And if we were to generate a scalar out of these numbers (each one of
> them is a 32-bit word), it would be too wide for current machines.  So
> we exploit the fact that on a given computer, the first 4 components
> of the SID are common to all accounts, and use only the last one which
> is different for each user.

Maybe it would help to use a full internal representation in Emacs that 
are simplified when talking with external applications?

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 22:54:56 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
> 
> Maybe it would help to use a full internal representation in Emacs that 
> are simplified when talking with external applications?

There are places in Emacs as well that expect Posix behavior.  And
there's some merit in being compatible with Cygwin, too.

Anyway, if someone wants to volunteer to do what you want, I won't
object.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Eli Zaretskii wrote:
>> Date: Sun, 30 Mar 2008 22:54:56 +0200
>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
>>
>> Maybe it would help to use a full internal representation in Emacs that 
>> are simplified when talking with external applications?
>>     
>
> There are places in Emacs as well that expect Posix behavior.  And
> there's some merit in being compatible with Cygwin, too.
>
> Anyway, if someone wants to volunteer to do what you want, I won't
> object.
>   

There is a function user-real-uid that may be able to be extended to 
contain the full id. Currently it is documented as returning a float or 
int, neither of which will contain a SID without losing precision. We'd 
have to check the users first. If elisp had a bignum type, it would be 
the best choice, as a cons cell will require different code for 
processing it. But before embarking on this, I'd like to see a case that 
actually needs it, as there are many other areas where we could be 
spending our limited resources.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Eli Zaretskii wrote:
>>> Date: Sun, 30 Mar 2008 22:54:56 +0200
>>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>>> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
>>>
>>> Maybe it would help to use a full internal representation in Emacs 
>>> that are simplified when talking with external applications?
>>>     
>>
>> There are places in Emacs as well that expect Posix behavior.  And
>> there's some merit in being compatible with Cygwin, too.
>>
>> Anyway, if someone wants to volunteer to do what you want, I won't
>> object.
>>   
> 
> There is a function user-real-uid that may be able to be extended to 
> contain the full id. Currently it is documented as returning a float or 
> int, neither of which will contain a SID without losing precision. We'd 
> have to check the users first. If elisp had a bignum type, it would be 
> the best choice, as a cons cell will require different code for 
> processing it. But before embarking on this, I'd like to see a case that 
> actually needs it, as there are many other areas where we could be 
> spending our limited resources.

You are really right that we have to consider where to use our limited 
resource. One reason to do this change however might be that it concerns 
security things (file owner). But I am not sure it actually matters.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> One reason to do this change however might be that it concerns 
> security things (file owner). But I am not sure it actually matters.

Windows does not have a concept of file ownership. It has access control 
lists for files on NTFS drives, but they do not distinguish between the 
owner or creator of a file and other users who may have access to the 
file. That is why Emacs considers all files to be owned by the current 
user. Cygwin has some mapping of ACLs to posix ownership, but that is 
more for bidirectional use by Cygwin to retain its own idea of posix 
ownership. Files created outside Cygwin may end up with some arbritrary 
default similar to what Emacs does (I haven't studied the Cygwin code, 
so I don't know the exact details of what they do).

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> One reason to do this change however might be that it concerns 
>> security things (file owner). But I am not sure it actually matters.
> 
> Windows does not have a concept of file ownership. It has access control 
> lists for files on NTFS drives, but they do not distinguish between the 
> owner or creator of a file and other users who may have access to the 
> file. That is why Emacs considers all files to be owned by the current 
> user. Cygwin has some mapping of ACLs to posix ownership, but that is 
> more for bidirectional use by Cygwin to retain its own idea of posix 
> ownership. Files created outside Cygwin may end up with some arbritrary 
> default similar to what Emacs does (I haven't studied the Cygwin code, 
> so I don't know the exact details of what they do).


Are you sure windows does not have file ownership? If you look at the 
properties for a file, click on the "Security" tab and then then 
"Advanced" there is a tab saying owner.

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> Are you sure windows does not have file ownership? If you look at the 
> properties for a file, click on the "Security" tab and then then 
> "Advanced" there is a tab saying owner.

Yes, you're right. I am currently using an XP Home system, which doesn't 
have that "Security" tab, so I was going by the output of cacls, which 
for many files lists only groups as having permissions, no individual users.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 17:04:34 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: Eli Zaretskii <eliz@gnu.org>, monnier@iro.umontreal.ca, 
>  emacs-pretest-bug@gnu.org
> 
> Lennart Borgman (gmail) wrote:
> > Are you sure windows does not have file ownership? If you look at the 
> > properties for a file, click on the "Security" tab and then then 
> > "Advanced" there is a tab saying owner.
> 
> Yes, you're right. I am currently using an XP Home system, which doesn't 
> have that "Security" tab

Right.  But NTFS security is still in place, of course, it's just that
you can't see it via the Windows Explorer.

> so I was going by the output of cacls, which for many files lists
> only groups as having permissions, no individual users.

Is that group Administrators, perhaps?  Files that belong to the
Administrator the user are frequently shown as belonging to the
_group_ Administrators.  (Yes, Windows can have objects that are owned
by groups, not users.)

Re: 23.0.60; uid problems on w32

[Razi Shaban]

If this tab is not apparent, you need to go to Folder Options and
disable "Simple File Sharing."

--
Razi


On 3/31/08, Lennart Borgman (gmail) <lennart.borgman@gmail.com> wrote:
> Jason Rumney wrote:
>  > Lennart Borgman (gmail) wrote:
>  >> One reason to do this change however might be that it concerns
>  >> security things (file owner). But I am not sure it actually matters.
>  >
>  > Windows does not have a concept of file ownership. It has access control
>  > lists for files on NTFS drives, but they do not distinguish between the
>  > owner or creator of a file and other users who may have access to the
>  > file. That is why Emacs considers all files to be owned by the current
>  > user. Cygwin has some mapping of ACLs to posix ownership, but that is
>  > more for bidirectional use by Cygwin to retain its own idea of posix
>  > ownership. Files created outside Cygwin may end up with some arbritrary
>  > default similar to what Emacs does (I haven't studied the Cygwin code,
>  > so I don't know the exact details of what they do).
>
>
>  Are you sure windows does not have file ownership? If you look at the
>  properties for a file, click on the "Security" tab and then then
>  "Advanced" there is a tab saying owner.
>
>
>

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 09:41:42 +0100
> From: Jason Rumney <jasonr@gnu.org>
> CC: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>, 
>  monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
> 
> There is a function user-real-uid that may be able to be extended to 
> contain the full id. Currently it is documented as returning a float or 
> int, neither of which will contain a SID without losing precision. We'd 
> have to check the users first. If elisp had a bignum type, it would be 
> the best choice, as a cons cell will require different code for 
> processing it. But before embarking on this, I'd like to see a case that 
> actually needs it, as there are many other areas where we could be 
> spending our limited resources.

I'm not sure such an endeavor would be justified.  After all, it's
quite possible to have two users on two Posix machines that have the
same uid, right?  So this problem is not unique to Windows.

Cygwin added the offset because they had a specific problem in the
mkpasswd program: it would create 2 user accounts for 2 different
users with the same uid.  Emacs doesn't have such a problem: we don't
create user accounts.  All we need to do is return a uid and user name
for each SID we get, and perhaps also handle the case where two
different SIDs map to the same uid, so that we don't return incorrect
user name for a given uid or vice versa.  This can be done by caching
the full SIDs internally (I have somewhere a version of `stat' that
does precisely that, which I wrote for my private port of GNU `ls').

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Mon, 31 Mar 2008 09:41:42 +0100
>> From: Jason Rumney <jasonr@gnu.org>
>> CC: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>, 
>>  monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
>>
>> There is a function user-real-uid that may be able to be extended to 
>> contain the full id. Currently it is documented as returning a float or 
>> int, neither of which will contain a SID without losing precision. We'd 
>> have to check the users first. If elisp had a bignum type, it would be 
>> the best choice, as a cons cell will require different code for 
>> processing it. But before embarking on this, I'd like to see a case that 
>> actually needs it, as there are many other areas where we could be 
>> spending our limited resources.
> 
> I'm not sure such an endeavor would be justified.  After all, it's
> quite possible to have two users on two Posix machines that have the
> same uid, right?  So this problem is not unique to Windows.
> 
> Cygwin added the offset because they had a specific problem in the
> mkpasswd program: it would create 2 user accounts for 2 different
> users with the same uid.  Emacs doesn't have such a problem: we don't
> create user accounts.  All we need to do is return a uid and user name
> for each SID we get, and perhaps also handle the case where two
> different SIDs map to the same uid, so that we don't return incorrect
> user name for a given uid or vice versa.  This can be done by caching
> the full SIDs internally (I have somewhere a version of `stat' that
> does precisely that, which I wrote for my private port of GNU `ls').

I do not understand. When the full SID is gone how can you distunguish 
between all SIDs mapping to a uid?

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 21:47:43 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> CC: Jason Rumney <jasonr@gnu.org>, monnier@iro.umontreal.ca, 
>  emacs-pretest-bug@gnu.org
> 
> > All we need to do is return a uid and user name
> > for each SID we get, and perhaps also handle the case where two
> > different SIDs map to the same uid, so that we don't return incorrect
> > user name for a given uid or vice versa.  This can be done by caching
> > the full SIDs internally (I have somewhere a version of `stat' that
> > does precisely that, which I wrote for my private port of GNU `ls').
> 
> I do not understand. When the full SID is gone how can you distunguish 
> between all SIDs mapping to a uid?

It's not gone, it is cached internally by the implementation of `stat'
I wrote.  It is just not exposed to the callers.

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Mon, 31 Mar 2008 21:47:43 +0200
>> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
>> CC: Jason Rumney <jasonr@gnu.org>, monnier@iro.umontreal.ca, 
>>  emacs-pretest-bug@gnu.org
>>
>>> All we need to do is return a uid and user name
>>> for each SID we get, and perhaps also handle the case where two
>>> different SIDs map to the same uid, so that we don't return incorrect
>>> user name for a given uid or vice versa.  This can be done by caching
>>> the full SIDs internally (I have somewhere a version of `stat' that
>>> does precisely that, which I wrote for my private port of GNU `ls').
>> I do not understand. When the full SID is gone how can you distunguish 
>> between all SIDs mapping to a uid?
> 
> It's not gone, it is cached internally by the implementation of `stat'
> I wrote.  It is just not exposed to the callers.

Eh, sorry. I meant "how can you from the uid choose the SID from all 
those SIDs mapping to this uid"?

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 22:42:02 +0200
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> CC: jasonr@gnu.org, monnier@iro.umontreal.ca, emacs-pretest-bug@gnu.org
> 
> Eh, sorry. I meant "how can you from the uid choose the SID from all 
> those SIDs mapping to this uid"?

You can't, but that's not needed, since, as I wrote earlier, such
situations happen on Unix as well, and so Posix programs don't expect
unique uid's.

What I meant was that you can correctly map a SID to a user or group
name, even if some users/groups are not from the local machine (e.g.,
because some of the files are remote files given in the
\\server\share\foo UNC format).

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sun, 30 Mar 2008 00:54:49 +0000
> From: Jason Rumney <jasonr@gnu.org>
> Cc: emacs-pretest-bug@gnu.org
> 
> Lennart Borgman (gmail) wrote:
> > I have got at bug report from Thierry Daucourt through
> >
> >   http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
> >
> > It looks like this could be a bug in Emacs. The crucial part of that 
> > bug report are the values investigated at the end of 
> > `server-ensure-safe-dir' where the user get the following for 
> > file-attributes and user-id:
> >
> >  attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0 
> > drwxrwxrwx
> >  nil 34842 (7173 . 33003))
> >  nth 2 attrs **-14706**
> >  user id **50830**
> 
> It appears the directory in question was created by a different user.

Emacs currently doesn't query the filesystem about the true owner of
the files; instead, it gives each file uid and gid of the current
user, as determined at startup.  So even if the directory was created
by someone else, Emacs will currently pretend it belongs to the
current user.  Thus, both values should match exactly.

> I've got no idea what Cygwin does to emulate posix uids on Windows, so 
> it is not surprising that it gets different results.

AFAIK, Cygwin uses the same RID values that we now use in
init_user_info on the trunk.  Except that we also do this:

	      /* Restrict to conventional uid range for normal users.  */
	      the_passwd.pw_uid %= 60001;

Do you have any idea why this is done?  I'm inclined to remove this
line, unless we have a good reason to keep it.

I thought that perhaps this modulo operation can explain why Cygwin
shows 60830 whereas we show 50830, but it looks like modulo 60001
cannot explain this, can it?

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Sat, 29 Mar 2008 23:09:07 +0100
> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
> Cc: 
> 
> I have got at bug report from Thierry Daucourt through
> 
>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32

Please ask that user to report problems here and participate in this
discussion.  I don't have access to a Windows box where UID is such a
large number, and talking through an intermediary is very inefficient.

> It looks like this could be a bug in Emacs. The crucial part of that bug 
> report are the values investigated at the end of 
> `server-ensure-safe-dir' where the user get the following for 
> file-attributes and user-id:
> 
>   attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0 
> drwxrwxrwx
>   nil 34842 (7173 . 33003))
>   nth 2 attrs **-14706**
>   user id **50830**

Which versions of src/w32.c and src/dired.c were used in the build of
EmacsW32 that this user used?  There were changes made there recently,
so it's important to know precisely what code was used.

> He also checked with Cygwin which gave other values than the two 
> different above for the uid:
> 
>   $ ls -ld server/
>   drwxr-xr-x+ 2 my_user mkgroup-l-d 0 Mar 29 14:35 server/
>   $ id
>   uid=**60830**(my_user) gid=10545(mkgroup-l-d) 
> groups=0(root),544(Administrators),545(Users),10545(mkgroup-l-d)

What do you mean by ``also checked with Cygwin''?  Does it mean he
checked with Cygwin build of Emacs, or just that `ls' and `id' used
above were Cygwin builds?

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
 >> Date: Sat, 29 Mar 2008 23:09:07 +0100
 >> From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
 >> Cc:
 >>
 >> I have got at bug report from Thierry Daucourt through
 >>
 >>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
 >
 > Please ask that user to report problems here and participate in this
 > discussion.  I don't have access to a Windows box where UID is such a
 > large number, and talking through an intermediary is very inefficient.

I have asked him on the web page to join.

 >> It looks like this could be a bug in Emacs. The crucial part of that 
bug
 >> report are the values investigated at the end of
 >> `server-ensure-safe-dir' where the user get the following for
 >> file-attributes and user-id:
 >>
 >>   attrs (t 1 -14706 513 (18414 17797) (18414 17797) (18414 17797) 0
 >> drwxrwxrwx
 >>   nil 34842 (7173 . 33003))
 >>   nth 2 attrs **-14706**
 >>   user id **50830**
 >
 > Which versions of src/w32.c and src/dired.c were used in the build of
 > EmacsW32 that this user used?  There were changes made there recently,
 > so it's important to know precisely what code was used.

Emacs 23 from CVS checked out 2008-03-25 built with gcc (downloaded from 
my site, built with gcc).

 >> He also checked with Cygwin which gave other values than the two
 >> different above for the uid:
 >>
 >>   $ ls -ld server/
 >>   drwxr-xr-x+ 2 my_user mkgroup-l-d 0 Mar 29 14:35 server/
 >>   $ id
 >>   uid=**60830**(my_user) gid=10545(mkgroup-l-d)
 >> groups=0(root),544(Administrators),545(Users),10545(mkgroup-l-d)
 >
 > What do you mean by ``also checked with Cygwin''?  Does it mean he
 > checked with Cygwin build of Emacs, or just that `ls' and `id' used
 > above were Cygwin builds?

No other Emacs is involved than the one above. ls and id are Cygwin builds.

Re: Re: 23.0.60; uid problems on w32

[thdox]

>-- Lennart Borgman (gmail) wrote : 
>Eli Zaretskii wrote:
> >> I have got at bug report from Thierry D. through
> >>
> >>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
> >
> > Please ask that user to report problems here and participate in this
> > discussion.  I don't have access to a Windows box where UID is such a
> > large number, and talking through an intermediary is very inefficient.

>I have asked him on the web page to join.

I joined. If can I help by testing something, any patch, etc...

Thierry

--
This message was sent on behalf of thdox@free.fr at openSubscriber.com
http://www.opensubscriber.com/message/emacs-devel@gnu.org/8904095.html

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Mon, 31 Mar 2008 17:52:05 -0400
> From: thdox@free.fr
> 
> >-- Lennart Borgman (gmail) wrote : 
> >Eli Zaretskii wrote:
> > >> I have got at bug report from Thierry D. through
> > >>
> > >>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
> > >
> > > Please ask that user to report problems here and participate in this
> > > discussion.  I don't have access to a Windows box where UID is such a
> > > large number, and talking through an intermediary is very inefficient.
> 
> >I have asked him on the web page to join.
> 
> I joined. If can I help by testing something, any patch, etc...

Can you test the latest CVS? the problem you reported should be fixed
there (by Jason).

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Eli Zaretskii wrote:
>> Date: Mon, 31 Mar 2008 17:52:05 -0400
>> From: thdox@free.fr
>>
>>> -- Lennart Borgman (gmail) wrote : 
>>> Eli Zaretskii wrote:
>>>>> I have got at bug report from Thierry D. through
>>>>>
>>>>>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>>>> Please ask that user to report problems here and participate in this
>>>> discussion.  I don't have access to a Windows box where UID is such a
>>>> large number, and talking through an intermediary is very inefficient.
>>> I have asked him on the web page to join.
>> I joined. If can I help by testing something, any patch, etc...
> 
> Can you test the latest CVS? the problem you reported should be fixed
> there (by Jason).


Thierry, I have just uploaded a (patched) test version here:

   http://ourcomments.org/Emacs/DL/EmacsW32/test/

I think that the patches does not affect the problem we have been 
working with here.

Re: 23.0.60; uid problems on w32

[thdox]

Lennart Borgman (gmail) a écrit :
> Eli Zaretskii wrote:
>>> Date: Mon, 31 Mar 2008 17:52:05 -0400
>>> From: thdox@free.fr
>>>
>>>> -- Lennart Borgman (gmail) wrote : Eli Zaretskii wrote:
>>>>>> I have got at bug report from Thierry D. through
>>>>>>
>>>>>>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>>>>> Please ask that user to report problems here and participate in this
>>>>> discussion.  I don't have access to a Windows box where UID is such a
>>>>> large number, and talking through an intermediary is very 
>>>>> inefficient.
>>>> I have asked him on the web page to join.
>>> I joined. If can I help by testing something, any patch, etc...
>>
>> Can you test the latest CVS? the problem you reported should be fixed
>> there (by Jason).
>
>
> Thierry, I have just uploaded a (patched) test version here:
>
>   http://ourcomments.org/Emacs/DL/EmacsW32/test/
>
> I think that the patches does not affect the problem we have been 
> working with here.
>
>
Lennart, I confirm that the version I uploaded from your site do not 
solve the uid issue. Any other test I could do to make things progress ?
Thierry

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

thdox wrote:
> 
> 
> Lennart Borgman (gmail) a écrit :
>> Eli Zaretskii wrote:
>>>> Date: Mon, 31 Mar 2008 17:52:05 -0400
>>>> From: thdox@free.fr
>>>>
>>>>> -- Lennart Borgman (gmail) wrote : Eli Zaretskii wrote:
>>>>>>> I have got at bug report from Thierry D. through
>>>>>>>
>>>>>>>    http://www.emacswiki.org/cgi-bin/wiki/EmacsW32
>>>>>> Please ask that user to report problems here and participate in this
>>>>>> discussion.  I don't have access to a Windows box where UID is such a
>>>>>> large number, and talking through an intermediary is very 
>>>>>> inefficient.
>>>>> I have asked him on the web page to join.
>>>> I joined. If can I help by testing something, any patch, etc...
>>>
>>> Can you test the latest CVS? the problem you reported should be fixed
>>> there (by Jason).
>>
>>
>> Thierry, I have just uploaded a (patched) test version here:
>>
>>   http://ourcomments.org/Emacs/DL/EmacsW32/test/
>>
>> I think that the patches does not affect the problem we have been 
>> working with here.
>>
>>
> Lennart, I confirm that the version I uploaded from your site do not 
> solve the uid issue. Any other test I could do to make things progress ?
> Thierry

Sorry. I have noticed some troubles with this patched version (I try to 
test them before moving them from the test area to the download area - 
so I will not move this version there).

I just started to make an unpatched version. Just wait two hours and it 
will be in the download area. I hope.

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Wed, 02 Apr 2008 20:14:48 +0200
> From: thdox <thdox@free.fr>
> CC: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> > Thierry, I have just uploaded a (patched) test version here:
> >
> >   http://ourcomments.org/Emacs/DL/EmacsW32/test/
> >
> > I think that the patches does not affect the problem we have been 
> > working with here.
> >
> >
> Lennart, I confirm that the version I uploaded from your site do not 
> solve the uid issue.

That's because Jason installed his fix only on the release branch, not
on the trunk.

> Any other test I could do to make things progress ?

Could you please try the latest trunk?  This problem is supposed to be
fixed there, along with a similar problem with inode numbers.

TIA

Re: 23.0.60; uid problems on w32

[Jason Rumney]

Eli Zaretskii wrote:
> That's because Jason installed his fix only on the release branch, not
> on the trunk.

If it hasn't been merged yet, it might be best to make a spurious change 
in the same place on the trunk, to ensure that the next merge the Miles 
does will fail.

Re: 23.0.60; uid problems on w32

[thdox]

>>> Thierry, I have just uploaded a (patched) test version here:
>>>
>>>   http://ourcomments.org/Emacs/DL/EmacsW32/test/
>>>
>>> I think that the patches does not affect the problem we have been 
>>> working with here.
>>>
>>>       
>> Lennart, I confirm that the version I uploaded from your site do not 
>> solve the uid issue.
>>     
>
> That's because Jason installed his fix only on the release branch, not
> on the trunk.
>
>   
>> Any other test I could do to make things progress ?
>>     
>
> Could you please try the latest trunk?  This problem is supposed to be
> fixed there, along with a similar problem with inode numbers.
>
> TIA
>
>
>   
Lennart, could you please provide me a compiled version with the patch? 
Thank you very much.

Thierry

Re: 23.0.60; uid problems on w32

[thdox]

Lennart, the last build you provide me by private email corrects the 
issue with uid.
By this email I wanted to make it known and close this thread of email.
Lennart & others, I wanted to thank you for the fix.
Lennart, I will wait for the next Emacs+EmacsW32 build to test other 
issues I described in emacswiki.

Best regards,

Thierry


>
>>>> Thierry, I have just uploaded a (patched) test version here:
>>>>
>>>>   http://ourcomments.org/Emacs/DL/EmacsW32/test/
>>>>
>>>> I think that the patches does not affect the problem we have been 
>>>> working with here.
>>>>
>>>>       
>>> Lennart, I confirm that the version I uploaded from your site do not 
>>> solve the uid issue.
>>>     
>>
>> That's because Jason installed his fix only on the release branch, not
>> on the trunk.
>>
>>  
>>> Any other test I could do to make things progress ?
>>>     
>>
>> Could you please try the latest trunk?  This problem is supposed to be
>> fixed there, along with a similar problem with inode numbers.
>>
>> TIA
>>
>>
>>   
> Lennart, could you please provide me a compiled version with the 
> patch? Thank you very much.
>
> Thierry
>

Re: 23.0.60; uid problems on w32

[Lennart Borgman (gmail)]

Thanks Thierry,

I will upload new versions as soon as I have been able to understand 
some problems with mumamo I have seen there now.


thdox wrote:
> Lennart, the last build you provide me by private email corrects the 
> issue with uid.
> By this email I wanted to make it known and close this thread of email.
> Lennart & others, I wanted to thank you for the fix.
> Lennart, I will wait for the next Emacs+EmacsW32 build to test other 
> issues I described in emacswiki.
> 
> Best regards,
> 
> Thierry
> 
> 
>>
>>>>> Thierry, I have just uploaded a (patched) test version here:
>>>>>
>>>>>   http://ourcomments.org/Emacs/DL/EmacsW32/test/
>>>>>
>>>>> I think that the patches does not affect the problem we have been 
>>>>> working with here.
>>>>>
>>>>>       
>>>> Lennart, I confirm that the version I uploaded from your site do not 
>>>> solve the uid issue.
>>>>     
>>>
>>> That's because Jason installed his fix only on the release branch, not
>>> on the trunk.
>>>
>>>  
>>>> Any other test I could do to make things progress ?
>>>>     
>>>
>>> Could you please try the latest trunk?  This problem is supposed to be
>>> fixed there, along with a similar problem with inode numbers.
>>>
>>> TIA
>>>
>>>
>>>   
>> Lennart, could you please provide me a compiled version with the 
>> patch? Thank you very much.
>>
>> Thierry
>>
> 
> 

Re: 23.0.60; uid problems on w32

[Eli Zaretskii]

> Date: Tue, 08 Apr 2008 01:12:13 +0200
> From: thdox <thdox@free.fr>
> CC: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> Lennart, the last build you provide me by private email corrects the 
> issue with uid.
> By this email I wanted to make it known and close this thread of email.
> Lennart & others, I wanted to thank you for the fix.

Thanks for helping us diagnose and fix this problem.