From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Cannot isearch for non-ascii chars with emacs -nw -Q Date: Thu, 28 Feb 2008 14:03:35 +0900 Message-ID: References: <87oda4d6h8.fsf@fastmail.fm> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1204175047 31042 80.91.229.12 (28 Feb 2008 05:04:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 05:04:07 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, thorn+news@fastmail.fm To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 06:04:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUawV-0007sz-Td for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 06:04:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUavz-0002NE-KB for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 00:03:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUavw-0002Mp-2c for emacs-devel@gnu.org; Thu, 28 Feb 2008 00:03:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUavv-0002Mb-JE for emacs-devel@gnu.org; Thu, 28 Feb 2008 00:03:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUavv-0002MX-EG for emacs-devel@gnu.org; Thu, 28 Feb 2008 00:03:51 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUavu-0001jT-W1 for emacs-devel@gnu.org; Thu, 28 Feb 2008 00:03:51 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JUavu-0001jb-Rh for emacs-pretest-bug@gnu.org; Thu, 28 Feb 2008 00:03:50 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JUavr-0001iX-2P for emacs-pretest-bug@gnu.org; Thu, 28 Feb 2008 00:03:50 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUavq-0001i5-Ee for emacs-pretest-bug@gnu.org; Thu, 28 Feb 2008 00:03:46 -0500 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id m1S53d4N020491; Thu, 28 Feb 2008 14:03:39 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id m1S53cue000278; Thu, 28 Feb 2008 14:03:38 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id m1S53Zg4028820; Thu, 28 Feb 2008 14:03:35 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1JUavf-0002Ln-SR; Thu, 28 Feb 2008 14:03:35 +0900 In-reply-to: (message from Stefan Monnier on Wed, 27 Feb 2008 23:05:54 -0500) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90695 gmane.emacs.pretest.bugs:21330 Archived-At: In article , Stefan Monnier writes: >>> > It seems that something is broken in isearch-x.el (although >>> > unicode merge didn't change it). I'm now investigating. > > I found that when isearch-printing-char is called, > > last-command-char is already what decoded by > > encoded-kbd-mode. > That's good, right? I hope so. > > But, when I wrote isearch-x.el, last-command-char was the first byte > > of utf-8 sequence. So, isearch-x.el pushed back that byte in > > unread-command-events and re-read the whole utf-8 sequence. > I see your patch doesn't remove this use of unread-command-events. > Is it still needed? This part in isearch-process-search-multibyte-characters (isearch-x.el) is still necessary because it seems that the user key is not yet handled by an input method. (if isearch-input-method-function ...) but the following part is not necessary any more (but not harmful even if it is there). (if (and (not str) (keyboard-coding-system)) (setq unread-command-events (cons 'with-keyboard-coding (cons last-char unread-command-events)) str (read-string prompt nil 'junk-hist))) I'll delete that part after confirming it is ok. >>> Now that we've moved the keyboard decoding to input-event-map, > > Ah! Is that the change I wrote above? > I don't see why that change would have such an effect. > Actually, it seems that this "new" behavior is already present in the 22 > branch, maybe even in Emacs-22.1. But, it was before the release of 21 when I modified isearch-x last time. > > Yes. I think it can be done by adding less than 100 lines > > of C code (mostly for handling meta-key) in > > tty_read_avail_input and removing most of encoded-kb.el (we > > still need the code of calling set-input-mode property). > Might worth trying, I'll work on it after the current problems of font selection are all solved. --- Kenichi Handa handa@ni.aist.go.jp