unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* display_mode_element change
@ 2008-02-27 19:44 Romain Francoise
  2008-02-28  2:57 ` Kenichi Handa
  0 siblings, 1 reply; 3+ messages in thread
From: Romain Francoise @ 2008-02-27 19:44 UTC (permalink / raw)
  To: emacs-devel; +Cc: Kenichi Handa

The buffer name in the modeline used to be displayed in bold, but
since the following change it is no longer the case:

2008-02-21  Kenichi Handa  <handa@ni.aist.go.jp>

	* xdisp.c (decode_mode_spec): New arg string.
	(display_mode_element): Adjust for the above change.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: display_mode_element change
  2008-02-27 19:44 display_mode_element change Romain Francoise
@ 2008-02-28  2:57 ` Kenichi Handa
  2008-02-28  4:37   ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Kenichi Handa @ 2008-02-28  2:57 UTC (permalink / raw)
  To: Romain Francoise; +Cc: emacs-devel

In article <878x16fakk.fsf@elegiac.orebokech.com>, Romain Francoise <romain@orebokech.com> writes:

> The buffer name in the modeline used to be displayed in bold, but
> since the following change it is no longer the case:

> 2008-02-21  Kenichi Handa  <handa@ni.aist.go.jp>

> 	* xdisp.c (decode_mode_spec): New arg string.
> 	(display_mode_element): Adjust for the above change.

This change was to display, for instance, Indic buffer name
correctly, but, I found that display_string doesn't use a
face in mode-line-format when LISP_STRING is given.  As I
don't have a good idea to make display_string use that face
for LISP_STRING at the moment, I cancelled that change.

Displaying Indic buffer name correctly should be fixed when
we change the composition not to use a text property.

---
Kenichi Handa
handa@ni.aist.go.jp




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: display_mode_element change
  2008-02-28  2:57 ` Kenichi Handa
@ 2008-02-28  4:37   ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2008-02-28  4:37 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: Romain Francoise, emacs-devel

> This change was to display, for instance, Indic buffer name
> correctly, but, I found that display_string doesn't use a
> face in mode-line-format when LISP_STRING is given.  As I
> don't have a good idea to make display_string use that face
> for LISP_STRING at the moment, I cancelled that change.

I guess we need to merge the text-properties from `elt'
into the string before passing it to display_string.


        Stefan




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-28  4:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-27 19:44 display_mode_element change Romain Francoise
2008-02-28  2:57 ` Kenichi Handa
2008-02-28  4:37   ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).