From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: (aset UNIBYTE-STRING MULTIBYTE-CHAR) Date: Wed, 13 Feb 2008 17:01:00 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1202940212 8348 80.91.229.12 (13 Feb 2008 22:03:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2008 22:03:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 13 23:03:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JPPhi-0005w5-Bp for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2008 23:03:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPPhE-0004Jc-Ok for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2008 17:03:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JPPf3-0003Lj-Q3 for emacs-devel@gnu.org; Wed, 13 Feb 2008 17:01:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JPPf3-0003LK-5S for emacs-devel@gnu.org; Wed, 13 Feb 2008 17:01:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPPf2-0003LA-P1 for emacs-devel@gnu.org; Wed, 13 Feb 2008 17:01:00 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JPPf2-0006D3-Hg for emacs-devel@gnu.org; Wed, 13 Feb 2008 17:01:00 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1JPPf2-0007tp-4P; Wed, 13 Feb 2008 17:01:00 -0500 In-reply-to: (message from Kenichi Handa on Wed, 13 Feb 2008 11:36:27 +0900) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88986 Archived-At: In emacs-unicode-2 branch, there was a discussion about the rightness of aset changing the multibyteness of a string, and I changed the code to signal an error in the above case. But, I got reports claiming that the change breaks some of already existing Elisp packages. We should investigate what packages these are, what they are doing that uses this, and how hard it is to fix them. Based on that we can decide. It is ok to break a few things in a way that is easy to fix. But it is not terribly hard to make this case work once again, given that all strings are indirect. At worst, one can make a new string with the modified contents, then swap the `data' pointers between the new string and the old one. That would be better than breaking lots of packages.