unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@ni.aist.go.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mindcooler@gmail.com, emacs-devel@gnu.org
Subject: Re: Still cannot build native windows version of emacs 23.*
Date: Tue, 12 Feb 2008 20:14:44 +0900	[thread overview]
Message-ID: <E1JOt64-0002Wy-GD@etlken.m17n.org> (raw)
In-Reply-To: <uve4yqq2j.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Feb 2008 14:20:20 +0200)

In article <uve4yqq2j.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> I took a quick look.  The warning comes from this code in
> mule-cmds.el, part of the function set-locale-environment:

> 	(when (get-language-info current-language-environment 'coding-priority)
> 	  (let ((codeset (locale-info 'codeset))
> 		(coding-system (car (coding-system-priority-list))))
> 	    (when codeset
> 	      (let ((cs (coding-system-aliases coding-system))
> 		    result)
> 		(while (and cs (not result))
> 		  (setq result
> 			(locale-charset-match-p (symbol-name (pop cs))
> 						(locale-info 'codeset))))
> 		(unless result
> 		  (message "Warning: Default coding system `%s' disagrees with
>   system codeset `%s' for this locale." coding-system codeset))))))))

> As far as I could see, `(locale-info 'codeset)' on Windows returns the
> codepage that corresponds to the current language, e.g. cp1252 for a
> Western-European locale.  But this codepage is not in the list
> returned by coding-system-priority-list; thus the warning.

> I don't really understand the rationale for this test and the warning;
> Handa-san, could you please shed some light on it?  What does this
> code try to find out, and what is the meaning of the warning?

As this part was not written by me, I'm not sure what the
actual rationale is.  It seems that these are the changelogs
for that part (from lisp/ChangeLog.unicode).

2002-10-27  Dave Love  <fx@gnu.org>
[...]
	* international/mule-cmds.el (wid-edit): Require when compiling.
	(set-locale-environment): Check locale against coding system
	aliases too.

2002-10-09  Dave Love  <fx@gnu.org>
[...]
	(set-locale-environment): Warn if coding system doesn't agree
	with system locale.

The code checks exactly what the message says, but as the
code is in the function set-locale-environment, if the most
preferred coding system is different from what the locale
suggests, I think, the latter should be preferred without
warning.

---
Kenichi Handa
handa@ni.aist.go.jp




  reply	other threads:[~2008-02-12 11:14 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 15:52 Still cannot build native windows version of emacs 23.* Eric Lilja
2008-02-03 19:50 ` Eli Zaretskii
2008-02-03 20:01   ` Eric Lilja
2008-02-04  4:06     ` Eli Zaretskii
2008-02-04  9:41       ` Eric Lilja
2008-02-04 11:02         ` Jason Rumney
2008-02-04 11:36           ` Eric Lilja
2008-02-04 11:48             ` Jason Rumney
2008-02-04 11:54               ` Eric Lilja
2008-02-04 12:13                 ` Juanma Barranquero
2008-02-04 20:56                   ` Eli Zaretskii
2008-02-04 20:45           ` Eli Zaretskii
2008-02-04 21:14             ` Eric Lilja
2008-02-04 21:23               ` Eli Zaretskii
2008-02-04 21:28                 ` Eric Lilja
2008-02-05  4:09                   ` Eli Zaretskii
2008-02-05  9:15                     ` Eric Lilja
2008-02-05 20:13                       ` Eli Zaretskii
2008-02-05 23:22                         ` Eric Lilja
2008-02-06  4:15                           ` Eli Zaretskii
2008-02-06  4:38                             ` Eric Lilja
2008-02-06 19:34                               ` Eli Zaretskii
2008-02-06 22:10                                 ` Eric Lilja
2008-02-07  4:13                                   ` Eli Zaretskii
2008-02-07  4:17                                     ` Eric Lilja
2008-02-07 19:03                                       ` Eric Lilja
2008-02-08 15:04                                         ` Eli Zaretskii
2008-02-08 15:12                                           ` Eric Lilja
2008-02-08 15:32                                             ` Eli Zaretskii
2008-02-08 21:27                                               ` Lennart Borgman (gmail)
2008-02-08 22:51                                                 ` Lennart Borgman (gmail)
2008-02-09  1:51                                                   ` Lennart Borgman (gmail)
2008-02-09  8:54                                                 ` Eli Zaretskii
2008-02-09  9:36                                                 ` Eli Zaretskii
2008-02-09 11:25                                                   ` Lennart Borgman (gmail)
2008-02-09 11:44                                                     ` Lennart Borgman (gmail)
2008-02-09 11:46                                                       ` Eric Lilja
2008-02-09 12:02                                                       ` Jason Rumney
2008-02-09 22:20                                                         ` Lennart Borgman (gmail)
2008-02-09 22:28                                                           ` Jason Rumney
2008-02-09 22:31                                                             ` Lennart Borgman (gmail)
2008-02-09  9:33                                               ` Eli Zaretskii
2008-02-09 10:35                                                 ` Eric Lilja
2008-02-09 10:50                                                   ` Eli Zaretskii
2008-02-09 12:20                                                     ` Eli Zaretskii
2008-02-12 11:14                                                       ` Kenichi Handa [this message]
2008-02-04 22:12             ` Andreas Schwab
2008-02-04 22:16               ` Eric Lilja
2008-02-04 20:47         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JOt64-0002Wy-GD@etlken.m17n.org \
    --to=handa@ni.aist.go.jp \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mindcooler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).