[PATCH] erc.el: Change C-x C-q to C-c C-x

[PATCH] erc.el: Change C-x C-q to C-c C-x

[Jari Aalto]

The rcirc.el whish is the default M-x irc in Emacs uses C-c C-x for
quit, which i think is quite logical (cf. C-x C-c for Emacs quit).

To unify the ERC with rcirc, it might be good idea to use same
keybindings.

2008-01-31  Jari Aalto  <jari.aalto AT cante.net>

        * erc.el (erc-mode-map): Change `erc-quit-server' from
        C-x C-q to C-c C-x to make the quit key uniform with
        rcirc.el

 erc/erc.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/erc/erc.el b/erc/erc.el
index 686a60a..2f2199d 100644
--- a/erc/erc.el
+++ b/erc/erc.el
@@ -1106,7 +1106,7 @@ which the local user typed."
     (define-key map "\C-c\C-n" 'erc-channel-names)
     (define-key map "\C-c\C-o" 'erc-get-channel-mode-from-keypress)
     (define-key map "\C-c\C-p" 'erc-part-from-channel)
-    (define-key map "\C-c\C-q" 'erc-quit-server)
+    (define-key map "\C-c\C-x" 'erc-quit-server)
     (define-key map "\C-c\C-r" 'erc-remove-text-properties-region)
     (define-key map "\C-c\C-t" 'erc-set-topic)
     (define-key map "\C-c\C-u" 'erc-kill-input)

Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Michael Olson]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Jari Aalto <jari.aalto@cante.net> writes:

> The rcirc.el whish is the default M-x irc in Emacs uses C-c C-x for
> quit, which i think is quite logical (cf. C-x C-c for Emacs quit).
>
> To unify the ERC with rcirc, it might be good idea to use same
> keybindings.

As long as the key is not used for something else in ERC, I'm generally
OK with doing that.

> 2008-01-31  Jari Aalto  <jari.aalto AT cante.net>
>
>         * erc.el (erc-mode-map): Change `erc-quit-server' from
>         C-x C-q to C-c C-x to make the quit key uniform with
>         rcirc.el

I'm checking in something similar.  I don't want to replace the C-c C-q
keybinding, since people may be used to that.  But I don't mind adding a
new binding for C-c C-x.

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
          Programmer -- Hobbies: Lisp, HCoop          | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Jari Aalto]

* Thu 2008-01-31 Michael Olson <mwolson@gnu.org> gmane.emacs.devel
* Message-Id: 877ihpvmac.fsf@grepfind.mwolson.org
>> To unify the ERC with rcirc, it might be good idea to use same
>> keybindings.
>> 2008-01-31  Jari Aalto  <jari.aalto AT cante.net>
>>
>>         * erc.el (erc-mode-map): Change `erc-quit-server' from
>>         C-x C-q to C-c C-x to make the quit key uniform with
>>         rcirc.el
>
> I'm checking in something similar.  I don't want to replace the C-c C-q
> keybinding, since people may be used to that.  But I don't mind adding a
> new binding for C-c C-x.

The keybinding C-c C-q in rcirc.el is bound to IRC /query command. If
ERC adds similar functionality in the future, that key could be feed to
it.

Jari

Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Leo]

On 2008-01-31 19:15 +0000, Michael Olson wrote:
>> To unify the ERC with rcirc, it might be good idea to use same
>> keybindings.

This is extremely important.

> As long as the key is not used for something else in ERC, I'm
>generally
> OK with doing that.

-- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

          Use the best OS -- http://www.fedoraproject.org/

Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Richard Stallman]

    The rcirc.el whish is the default M-x irc in Emacs uses C-c C-x for
    quit, which i think is quite logical (cf. C-x C-c for Emacs quit).

To unify the two is a good idea, but maybe C-c C-q is better.
I say maybe because I'm not really sure.  But I could imagine
that having a C-c C-x binding could lead to typing C-x C-c
by mistake.

Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Jari Aalto]

* Fri 2008-02-01 Richard Stallman <rms@gnu.org> gmane.emacs.erc.general
* Message-Id: E1JKpTt-0007Vg-JU@fencepost.gnu.org
>     The rcirc.el whish is the default M-x irc in Emacs uses C-c C-x for
>     quit, which i think is quite logical (cf. C-x C-c for Emacs quit).
>
> To unify the two is a good idea, but maybe C-c C-q is better.
> I say maybe because I'm not really sure.  But I could imagine
> that having a C-c C-x binding could lead to typing C-x C-c
> by mistake.

The motivation to use C-c C-x is two fold:

- It resembles C-x C-c (this is both plus and minus)
- The C-c C-q can then be used for IRC /query command (rcirc.el does this).

Jari

Re: Re: [PATCH] erc.el: Change C-x C-q to C-c C-x

[Exal de Jesus Garcia Carrillo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Em sexta,  1 fevereiro 2008, Richard Stallman escreveu :

>     The rcirc.el whish is the default M-x irc in Emacs uses C-c C-x for
>     quit, which i think is quite logical (cf. C-x C-c for Emacs quit).
>
> To unify the two is a good idea, but maybe C-c C-q is better.
> I say maybe because I'm not really sure.  But I could imagine
> that having a C-c C-x binding could lead to typing C-x C-c
> by mistake.

Exactly what I think, indeed this has happened to me on Gnus mail
reader, I have re-binding the `q' for quit and have do it not interactive
and some times I have quit when I really dont want it.

Perhaps make the erc quit interactively also?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iD8DBQFHo/zeoZmxoVJRtGIRAo07AJ9O4RBSYtfZSnloCfIOWt0Epug72QCghykn
rUMzPYhCz8lSwRXFbotUS8E=
=5O1V
-----END PGP SIGNATURE-----