* Wrong file mentioned for variable definition
@ 2007-12-22 14:27 Eli Zaretskii
2007-12-22 14:36 ` Andreas Schwab
2007-12-22 21:08 ` Richard Stallman
0 siblings, 2 replies; 4+ messages in thread
From: Eli Zaretskii @ 2007-12-22 14:27 UTC (permalink / raw)
To: emacs-devel
In today's CVS on the Emacs 22 branch, "C-h v file-name-history RET"
brings this:
file-name-history is a variable defined in `files.el'.
But in fact file-name-history is defined in fileio.c, while files.el
has only a defvar for it, presumably to avoid a warning from the byte
compiler. I think this is a misfeature.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Wrong file mentioned for variable definition
2007-12-22 14:27 Wrong file mentioned for variable definition Eli Zaretskii
@ 2007-12-22 14:36 ` Andreas Schwab
2007-12-22 16:39 ` Eli Zaretskii
2007-12-22 21:08 ` Richard Stallman
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2007-12-22 14:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> In today's CVS on the Emacs 22 branch, "C-h v file-name-history RET"
> brings this:
>
> file-name-history is a variable defined in `files.el'.
>
> But in fact file-name-history is defined in fileio.c,
No, it isn't. Only a pointer to the symbol is defined, not the
variable.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Wrong file mentioned for variable definition
2007-12-22 14:36 ` Andreas Schwab
@ 2007-12-22 16:39 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2007-12-22 16:39 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
> From: Andreas Schwab <schwab@suse.de>
> Cc: emacs-devel@gnu.org
> Date: Sat, 22 Dec 2007 15:36:54 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > In today's CVS on the Emacs 22 branch, "C-h v file-name-history RET"
> > brings this:
> >
> > file-name-history is a variable defined in `files.el'.
> >
> > But in fact file-name-history is defined in fileio.c,
>
> No, it isn't. Only a pointer to the symbol is defined, not the
> variable.
Right you are. Sorry for the noise.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Wrong file mentioned for variable definition
2007-12-22 14:27 Wrong file mentioned for variable definition Eli Zaretskii
2007-12-22 14:36 ` Andreas Schwab
@ 2007-12-22 21:08 ` Richard Stallman
1 sibling, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2007-12-22 21:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
In today's CVS on the Emacs 22 branch, "C-h v file-name-history RET"
brings this:
file-name-history is a variable defined in `files.el'.
But in fact file-name-history is defined in fileio.c, while files.el
has only a defvar for it, presumably to avoid a warning from the byte
compiler.
The real definition is in files.el because that's where it gets the
doc string. fileio.c just creates the symbol and sets it to nil;
it does not define it as a variable.
So the help command is giving you correct info.
If you want to change this to do the defvar in fileio.c instead,
that is ok with me.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-22 21:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-22 14:27 Wrong file mentioned for variable definition Eli Zaretskii
2007-12-22 14:36 ` Andreas Schwab
2007-12-22 16:39 ` Eli Zaretskii
2007-12-22 21:08 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).