From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: TODO item: the mark and overlay in revert-buffer
Date: Sun, 09 Dec 2007 18:18:55 -0500 [thread overview]
Message-ID: <E1J1VQF-0002mB-GA@fencepost.gnu.org> (raw)
In-Reply-To: <871wa16q0n.fsf@actcom.com> (message from Yoni Rabkin Katzenell on Wed, 05 Dec 2007 18:54:32 +0200)
Would someone please install this, then ack?
(And thank him.)
From: Yoni Rabkin Katzenell <yoni-r@actcom.com>
To: emacs-devel@gnu.org
Date: Wed, 05 Dec 2007 18:54:32 +0200
Message-ID: <871wa16q0n.fsf@actcom.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: TODO item: the mark and overlay in revert-buffer
--=-=-=
Hello, I am using GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, X toolkit,
Xaw3d scroll bars) of 2007-12-05
/etc/TODO says: revert-buffer should eliminate overlays and the mark.
This patch should do that. It removes the mark, mark-ring and all
overlays after `before-revert-hook' is run and before
`after-revert-hook' is run.
Additionally, the patch changes the doc-string to be more explicit about
how other modes use revert-buffer via 'revert-buffer-function'.
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=2007-12-05-revert.patch
Content-Description: revert-buffer patch
*** old/files.el 2007-12-05 18:03:59.000000000 +0200
--- new/files.el 2007-12-05 18:03:54.000000000 +0200
***************
*** 4204,4213 ****
With a prefix argument, offer to revert from latest auto-save file, if
that is more recent than the visited file.
! This command also works for special buffers that contain text which
! doesn't come from a file, but reflects some other data base instead:
! for example, Dired buffers and `buffer-list' buffers. In these cases,
! it reconstructs the buffer contents from the appropriate data base.
When called from Lisp, the first argument is IGNORE-AUTO; only offer
to revert from the auto-save file when this is nil. Note that the
--- 4204,4215 ----
With a prefix argument, offer to revert from latest auto-save file, if
that is more recent than the visited file.
! This command also implements an interface for special buffers
! that contain text which doesn't come from a file, but reflects
! some other data instead (e.g. Dired buffers, `buffer-list'
! buffers). This is done via the variable
! `revert-buffer-function'. In these cases, it should reconstruct
! the buffer contents from the appropriate data.
When called from Lisp, the first argument is IGNORE-AUTO; only offer
to revert from the auto-save file when this is nil. Note that the
***************
*** 4323,4329 ****
(insert-file-contents file-name (not auto-save-p)
nil nil t))
(insert-file-contents file-name (not auto-save-p)
! nil nil t)))))
;; Recompute the truename in case changes in symlinks
;; have changed the truename.
(setq buffer-file-truename
--- 4325,4335 ----
(insert-file-contents file-name (not auto-save-p)
nil nil t))
(insert-file-contents file-name (not auto-save-p)
! nil nil t))
! ;; Reset the mark and remove all overlays.
! (setq mark-active nil
! mark-ring nil)
! (remove-overlays))))
;; Recompute the truename in case changes in symlinks
;; have changed the truename.
(setq buffer-file-truename
--=-=-=
--
"Cut your own wood and it will warm you twice"
--=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
--=-=-=--
next prev parent reply other threads:[~2007-12-09 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 16:54 TODO item: the mark and overlay in revert-buffer Yoni Rabkin Katzenell
2007-12-09 23:18 ` Richard Stallman [this message]
2007-12-11 1:31 ` Vinicius Jose Latorre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1J1VQF-0002mB-GA@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).