From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: recenter-top-bottom Date: Sun, 11 Nov 2007 18:54:47 -0500 Message-ID: References: <20071111082739.GA1038@muc.de> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1194825846 29588 80.91.229.12 (12 Nov 2007 00:04:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Nov 2007 00:04:06 +0000 (UTC) Cc: drew.adams@oracle.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 01:04:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IrMmf-0001By-No for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2007 01:04:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrMmT-0000c6-R5 for ged-emacs-devel@m.gmane.org; Sun, 11 Nov 2007 19:03:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrMmM-0000S7-ST for emacs-devel@gnu.org; Sun, 11 Nov 2007 19:03:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrMmL-0000Oo-8w for emacs-devel@gnu.org; Sun, 11 Nov 2007 19:03:50 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrMmL-0000Od-1a for emacs-devel@gnu.org; Sun, 11 Nov 2007 19:03:49 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IrMdc-0006I4-9f for emacs-devel@gnu.org; Sun, 11 Nov 2007 18:54:48 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IrMdb-00018D-J5; Sun, 11 Nov 2007 18:54:47 -0500 In-reply-to: <20071111082739.GA1038@muc.de> (message from Alan Mackenzie on Sun, 11 Nov 2007 08:27:39 +0000) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82999 Archived-At: > (cond ((and (eq this-command last-command) (not arg)) > (setq this-command 'recenter-top-bottom-1) <=============== PLEASE DON'T DO THIS!!!! This is an abuse of `\(this\|last\)-command', and will surely cause some other emacs function, present or future, to fail. Changing the value of these variables is the recommended way to do this sort of thing. This is what they were made for. In particular, the contents of these variables have always been executable commands. They have been, but I am not sure it matters -- does anything want to funcall them? They are normally used for eq comparisons like these, and the different facilities that use them don't interfere because they check for different symbols. The one thing to check is that the feature now being designed to record the commands and their arguments works in a way that is not broken by functions such as kill-region, which set this-command.