* bad-package-check
@ 2007-11-02 18:15 Ulrich Mueller
2007-11-02 22:56 ` bad-package-check Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Ulrich Mueller @ 2007-11-02 18:15 UTC (permalink / raw)
To: emacs-devel
Hi,
Emacs 22.1.50 now displays a warning when loading the semantic.el that
comes with cedet-1.0_pre3. This is in spite of the semantic bug being
fixed in the Gentoo version long time ago. In this special case it is
no problem, since it is easy to upgrade to a newer cedet version.
However, shouldn't the version regexps in general be sandwiched
between \` and \' pairs? Then distros could stick an extra version
string on, and the check wouldn't trigger anymore.
Also, it shouldn't match version strings like "12.0pre3".
Ulrich
--- lisp/simple.el~ 2007-11-02 18:31:23.828369000 +0100
+++ lisp/simple.el 2007-11-02 18:34:27.800303335 +0100
@@ -5633,7 +5633,7 @@
(defconst bad-packages-alist
;; Not sure exactly which semantic versions have problems.
;; Definitely 2.0pre3, probably all 2.0pre's before this.
- '((semantic semantic-version "2\\.0pre[1-3]"
+ '((semantic semantic-version "\\`2\\.0pre[1-3]\\'"
"The version of `semantic' loaded does not work in Emacs 22.
It can cause constant high CPU load.
Upgrade to at least Semantic 2.0pre4 (distributed with CEDET 1.0pre4).")
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: bad-package-check 2007-11-02 18:15 bad-package-check Ulrich Mueller @ 2007-11-02 22:56 ` Glenn Morris 2007-11-03 7:12 ` bad-package-check Ulrich Mueller 0 siblings, 1 reply; 5+ messages in thread From: Glenn Morris @ 2007-11-02 22:56 UTC (permalink / raw) To: Ulrich Mueller; +Cc: emacs-devel Ulrich Mueller wrote: > However, shouldn't the version regexps in general be sandwiched > between \` and \' pairs? Yes. You should probably complete a copyright assignment for Emacs. Are you willing to do that? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bad-package-check 2007-11-02 22:56 ` bad-package-check Glenn Morris @ 2007-11-03 7:12 ` Ulrich Mueller 2007-11-03 20:40 ` bad-package-check Glenn Morris 2007-11-04 0:11 ` bad-package-check Richard Stallman 0 siblings, 2 replies; 5+ messages in thread From: Ulrich Mueller @ 2007-11-03 7:12 UTC (permalink / raw) To: Glenn Morris; +Cc: emacs-devel >>>>> On Fri, 02 Nov 2007, Glenn Morris wrote: > You should probably complete a copyright assignment for Emacs. > Are you willing to do that? I already did, in December 1993. ;-) Is this no longer valid? Ulrich ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bad-package-check 2007-11-03 7:12 ` bad-package-check Ulrich Mueller @ 2007-11-03 20:40 ` Glenn Morris 2007-11-04 0:11 ` bad-package-check Richard Stallman 1 sibling, 0 replies; 5+ messages in thread From: Glenn Morris @ 2007-11-03 20:40 UTC (permalink / raw) To: Ulrich Mueller; +Cc: emacs-devel Ulrich Mueller wrote: > I already did, in December 1993. ;-) Is this no longer valid? Oh, I see. No, that's fine. It was listed under "Muller" rather than "Mueller", so I missed it. Sorry for the confusion. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bad-package-check 2007-11-03 7:12 ` bad-package-check Ulrich Mueller 2007-11-03 20:40 ` bad-package-check Glenn Morris @ 2007-11-04 0:11 ` Richard Stallman 1 sibling, 0 replies; 5+ messages in thread From: Richard Stallman @ 2007-11-04 0:11 UTC (permalink / raw) To: Ulrich Mueller; +Cc: rgm, emacs-devel I already did, in December 1993. ;-) Is this no longer valid? It is valid, but it only covered the changes you had made as of that time. Would you like to sign something to cover your future changes? ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-04 0:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-11-02 18:15 bad-package-check Ulrich Mueller 2007-11-02 22:56 ` bad-package-check Glenn Morris 2007-11-03 7:12 ` bad-package-check Ulrich Mueller 2007-11-03 20:40 ` bad-package-check Glenn Morris 2007-11-04 0:11 ` bad-package-check Richard Stallman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).