unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1]
@ 2007-10-26  9:46 Richard Stallman
  2007-10-26 17:34 ` Dan Nicolaescu
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2007-10-26  9:46 UTC (permalink / raw)
  To: esr; +Cc: emacs-devel

I sent this message three times to ESR, and never got a response.
Would someone else please fix deal with these problems, then ack?


Can you please fix these bugs, then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE,
	UNPARSEABLE_RELAY autolearn=failed version=3.1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type;
	bh=BfiJxZJHM/B++ZT3T79Kq349pkNNna8RGbNvRYovm5Q=;
	b=ka+sPk9fjgyIpK4/6s9h1z/iLGZel4lpDDlwbL8YhV56HTe9Um5hDJLzRwEMRI27mkCvurq+E4/Q87fcVclNViLiVxOMTPT2ek2ghHTsnP8N9Wv63dD86F/uNdxfgsxZA5NG20m8zQETY+PvOJJWZc0QSzbSgPYL8QdQ9pzs6Us=
Date: Tue, 2 Oct 2007 15:31:31 -0400
From: "Guru Gandharv" <veekae@gmail.com>
To: bug-gnu-emacs@gnu.org
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_17733_22620424.1191353491870"
Subject: bug in vc-state functions in Emacs v 22.1

- ------=_Part_17733_22620424.1191353491870
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

In batch mode vc related commands doesn't work as expected. In editor
mode it partially works, if we do a vc-<backend>-state before we do vc-state
it gives correct state and a 'vc-recompute-state' gives correct state in any
order.
I verified the latest Emacs CVS source and the behavior is still same. It
works fine with vc version shipped with Emacs v21.3.

*Problem *Illustration: <parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh>

$ cvs status myfile.sh|grep Status
File: myfile.sh           Status: Needs Patch
$ <parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh>

$ <parimiv@sx86qa3.nyc:/u/parimiv/tmp> cat get-vc-state.el
(require 'vc-cvs)
(require 'vc)
(message "%s" (emacs-version))
(if (> emacs-major-version 21)
    (message "%s" (vc-recompute-state "/tmp/myfile.sh"))
    (message "%s" (vc-state "/tmp/myfile.sh")))
(message "%s" (vc-cvs-state "/tmp/myfile.sh"))
(message "%s" (vc-state "/tmp/myfile.sh"))
$

$ <parimiv@sx86qa3.nyc:/u/parimiv/tmp> emacs-22.1 -batch -l get-vc-state.el
GNU Emacs 22.1.1 (i386-pc-solaris2.10, GTK+ Version 2.4.9)
 of 2007-09-27 on sx86qa3.nyc.deshaw.com
up-to-date
up-to-date
up-to-date
<parimiv@sx86qa3.nyc:/u/parimiv/tmp>$
<parimiv@sx86qa3.nyc:/u/parimiv/tmp> emacs-21.3
- -batch -l get-vc-state.el
GNU Emacs 21.3.1 (i386-pc-solaris2.10, Motif Version 2.1.0)
 of 2005-05-14 on sx86qa1.nyc.deshaw.com
up-to-date
needs-patch
needs-patch
<parimiv@sx86qa3.nyc:/u/parimiv/tmp>$ <parimiv@sx86qa3.nyc:/u/parimiv/tmp>

- ------=_Part_17733_22620424.1191353491870
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<div>In batch mode vc related commands doesn&#39;t work as expected. In editor mode&nbsp;it partially works, if we do a vc-&lt;backend&gt;-state before we do vc-state it gives correct state and a &#39;vc-recompute-state&#39; gives correct state in any order. 
<br>I verified the latest Emacs CVS source and the behavior is still same. It works fine with vc version shipped with Emacs v21.3.</div>
<div>&nbsp;</div>
<div><u>Problem </u><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh"><font color="#000000">Illustration:</font></a></div>
<div>&nbsp;</div>
<div>$&nbsp;cvs status myfile.sh|grep Status<br>File: myfile.sh&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Status: Needs Patch<br><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh">$</a><br>&nbsp;</div>
<div><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a>&nbsp;cat get-vc-state.el<br>(require &#39;vc-cvs)<br>(require &#39;vc)<br>(message &quot;%s&quot; (emacs-version))<br>(if (&gt; emacs-major-version 21)<br>&nbsp;&nbsp; &nbsp;(message &quot;%s&quot; (vc-recompute-state &quot;/tmp/myfile.sh&quot;))
<br>&nbsp;&nbsp; &nbsp;(message &quot;%s&quot; (vc-state &quot;/tmp/myfile.sh&quot;)))<br>(message &quot;%s&quot; (vc-cvs-state &quot;/tmp/myfile.sh&quot;))<br>(message &quot;%s&quot; (vc-state &quot;/tmp/myfile.sh&quot;))<br>$</div>
<div>&nbsp;</div>
<div><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">&nbsp;emacs-22.1 -batch -l get-vc-state.el<br>GNU Emacs 22.1.1 (i386-pc-solaris2.10, GTK+ Version 2.4.9)<br>&nbsp;of 2007-09-27 on sx86qa3.nyc.deshaw.com
<br>up-to-date<br>up-to-date<br>up-to-date<br></a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">&nbsp;emacs-21.3 -batch -l get-vc-state.el<br>GNU Emacs 21.3.1 (i386-pc-solaris2.10, Motif Version 2.1.0)
<br>&nbsp;of 2005-05-14 on sx86qa1.nyc.deshaw.com<br>up-to-date<br>needs-patch<br>needs-patch<br></a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><br>&nbsp;</div>

- ------=_Part_17733_22620424.1191353491870--
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1]
  2007-10-26  9:46 [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1] Richard Stallman
@ 2007-10-26 17:34 ` Dan Nicolaescu
  2007-10-27 13:57   ` Richard Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Nicolaescu @ 2007-10-26 17:34 UTC (permalink / raw)
  To: rms; +Cc: esr, emacs-devel

Richard Stallman <rms@gnu.org> writes:

  > I sent this message three times to ESR, and never got a response.
  > Would someone else please fix deal with these problems, then ack?

I can't reproduce this. 

GNU Emacs 21.4.1 (i386-redhat-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2006-03-07 on hs20-bc1-6.build.redhat.com
up-to-date
up-to-date
up-to-date

The bug report used 21.3, I tried it with 21.4. AFAIR the only
difference between the 2 is some security bug that had nothing to do
with VC.



  > Can you please fix these bugs, then ack?
  > 
  > From: "Guru Gandharv" <veekae@gmail.com>
  > Subject: bug in vc-state functions in Emacs v 22.1
  > To: bug-gnu-emacs@gnu.org
  > Date: Tue, 2 Oct 2007 15:31:31 -0400
  > 
  > - ------=_Part_17733_22620424.1191353491870
  > Content-Type: text/plain; charset=ISO-8859-1
  > Content-Transfer-Encoding: 7bit
  > Content-Disposition: inline
  > 
  > In batch mode vc related commands doesn't work as expected. In editor
  > mode it partially works, if we do a vc-<backend>-state before we do vc-state
  > it gives correct state and a 'vc-recompute-state' gives correct state in any
  > order.
  > I verified the latest Emacs CVS source and the behavior is still same. It
  > works fine with vc version shipped with Emacs v21.3.
  > 
  > *Problem *Illustration: <parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh>
  > 
  > $ cvs status myfile.sh|grep Status
  > File: myfile.sh           Status: Needs Patch
  > $ <parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh>
  > 
  > $ <parimiv@sx86qa3.nyc:/u/parimiv/tmp> cat get-vc-state.el
  > (require 'vc-cvs)
  > (require 'vc)
  > (message "%s" (emacs-version))
  > (if (> emacs-major-version 21)
  >     (message "%s" (vc-recompute-state "/tmp/myfile.sh"))
  >     (message "%s" (vc-state "/tmp/myfile.sh")))
  > (message "%s" (vc-cvs-state "/tmp/myfile.sh"))
  > (message "%s" (vc-state "/tmp/myfile.sh"))
  > $
  > 
  > $ <parimiv@sx86qa3.nyc:/u/parimiv/tmp> emacs-22.1 -batch -l get-vc-state.el
  > GNU Emacs 22.1.1 (i386-pc-solaris2.10, GTK+ Version 2.4.9)
  >  of 2007-09-27 on sx86qa3.nyc.deshaw.com
  > up-to-date
  > up-to-date
  > up-to-date
  > <parimiv@sx86qa3.nyc:/u/parimiv/tmp>$
  > <parimiv@sx86qa3.nyc:/u/parimiv/tmp> emacs-21.3
  > - -batch -l get-vc-state.el
  > GNU Emacs 21.3.1 (i386-pc-solaris2.10, Motif Version 2.1.0)
  >  of 2005-05-14 on sx86qa1.nyc.deshaw.com
  > up-to-date
  > needs-patch
  > needs-patch
  > <parimiv@sx86qa3.nyc:/u/parimiv/tmp>$ <parimiv@sx86qa3.nyc:/u/parimiv/tmp>
  > 
  > - ------=_Part_17733_22620424.1191353491870
  > Content-Type: text/html; charset=ISO-8859-1
  > Content-Transfer-Encoding: 7bit
  > Content-Disposition: inline
  > 
  > <div>In batch mode vc related commands doesn&#39;t work as expected. In editor mode&nbsp;it partially works, if we do a vc-&lt;backend&gt;-state before we do vc-state it gives correct state and a &#39;vc-recompute-state&#39; gives correct state in any order. 
  > <br>I verified the latest Emacs CVS source and the behavior is still same. It works fine with vc version shipped with Emacs v21.3.</div>
  > <div>&nbsp;</div>
  > <div><u>Problem </u><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh"><font color="#000000">Illustration:</font></a></div>
  > <div>&nbsp;</div>
  > <div>$&nbsp;cvs status myfile.sh|grep Status<br>File: myfile.sh&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Status: Needs Patch<br><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/work/cos/xrsh">$</a><br>&nbsp;</div>
  > <div><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a>&nbsp;cat get-vc-state.el<br>(require &#39;vc-cvs)<br>(require &#39;vc)<br>(message &quot;%s&quot; (emacs-version))<br>(if (&gt; emacs-major-version 21)<br>&nbsp;&nbsp; &nbsp;(message &quot;%s&quot; (vc-recompute-state &quot;/tmp/myfile.sh&quot;))
  > <br>&nbsp;&nbsp; &nbsp;(message &quot;%s&quot; (vc-state &quot;/tmp/myfile.sh&quot;)))<br>(message &quot;%s&quot; (vc-cvs-state &quot;/tmp/myfile.sh&quot;))<br>(message &quot;%s&quot; (vc-state &quot;/tmp/myfile.sh&quot;))<br>$</div>
  > <div>&nbsp;</div>
  > <div><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">&nbsp;emacs-22.1 -batch -l get-vc-state.el<br>GNU Emacs 22.1.1 (i386-pc-solaris2.10, GTK+ Version 2.4.9)<br>&nbsp;of 2007-09-27 on sx86qa3.nyc.deshaw.com
  > <br>up-to-date<br>up-to-date<br>up-to-date<br></a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">&nbsp;emacs-21.3 -batch -l get-vc-state.el<br>GNU Emacs 21.3.1 (i386-pc-solaris2.10, Motif Version 2.1.0)
  > <br>&nbsp;of 2005-05-14 on sx86qa1.nyc.deshaw.com<br>up-to-date<br>needs-patch<br>needs-patch<br></a><a href="mailto:parimiv@sx86qa3.nyc:/u/parimiv/tmp">$</a><br>&nbsp;</div>
  > 
  > - ------=_Part_17733_22620424.1191353491870--
  > ----------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1]
  2007-10-26 17:34 ` Dan Nicolaescu
@ 2007-10-27 13:57   ` Richard Stallman
  2007-10-28  2:30     ` Dan Nicolaescu
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2007-10-27 13:57 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: esr, emacs-devel

    I can't reproduce this. 

    GNU Emacs 21.4.1 (i386-redhat-linux-gnu, X toolkit, Xaw3d scroll bars)
     of 2006-03-07 on hs20-bc1-6.build.redhat.com
    up-to-date
    up-to-date
    up-to-date

    The bug report used 21.3, I tried it with 21.4. AFAIR the only
    difference between the 2 is some security bug that had nothing to do
    with VC.

Whether it fails in Emacs 21 is not really important since we do not
maintain that any more.  What matters is, does this fail in Emacs 22?
And does it fail in the trunk?

Could you check those two?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1]
  2007-10-27 13:57   ` Richard Stallman
@ 2007-10-28  2:30     ` Dan Nicolaescu
  2007-10-29  0:11       ` Richard Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Nicolaescu @ 2007-10-28  2:30 UTC (permalink / raw)
  To: rms; +Cc: esr, emacs-devel

Richard Stallman <rms@gnu.org> writes:

  >     I can't reproduce this. 
  > 
  >     GNU Emacs 21.4.1 (i386-redhat-linux-gnu, X toolkit, Xaw3d scroll bars)
  >      of 2006-03-07 on hs20-bc1-6.build.redhat.com
  >     up-to-date
  >     up-to-date
  >     up-to-date
  > 
  >     The bug report used 21.3, I tried it with 21.4. AFAIR the only
  >     difference between the 2 is some security bug that had nothing to do
  >     with VC.
  > 
  > Whether it fails in Emacs 21 is not really important since we do not
  > maintain that any more.  What matters is, does this fail in Emacs 22?
  > And does it fail in the trunk?
  > 
  > Could you check those two?

I don't see anything wrong with either of those.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1]
  2007-10-28  2:30     ` Dan Nicolaescu
@ 2007-10-29  0:11       ` Richard Stallman
  0 siblings, 0 replies; 5+ messages in thread
From: Richard Stallman @ 2007-10-29  0:11 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: esr, emacs-devel

Thanks for checking.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-10-29  0:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-26  9:46 [veekae@gmail.com: bug in vc-state functions in Emacs v 22.1] Richard Stallman
2007-10-26 17:34 ` Dan Nicolaescu
2007-10-27 13:57   ` Richard Stallman
2007-10-28  2:30     ` Dan Nicolaescu
2007-10-29  0:11       ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).