From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Problems setting byte-compile-warnings to t Date: Fri, 26 Oct 2007 22:28:53 -0400 Message-ID: References: <9p8x5qiwik.fsf@fencepost.gnu.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1193452231 28298 80.91.229.12 (27 Oct 2007 02:30:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2007 02:30:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 27 04:30:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IlbRW-00067j-I5 for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2007 04:30:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IlbRN-00046j-Os for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2007 22:30:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IlbQ0-0002R8-2t for emacs-devel@gnu.org; Fri, 26 Oct 2007 22:28:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IlbPy-0002Pr-Sz for emacs-devel@gnu.org; Fri, 26 Oct 2007 22:28:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IlbPy-0002PG-CU for emacs-devel@gnu.org; Fri, 26 Oct 2007 22:28:54 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IlbPy-0002nz-2d for emacs-devel@gnu.org; Fri, 26 Oct 2007 22:28:54 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IlbPx-0008VA-BD; Fri, 26 Oct 2007 22:28:53 -0400 In-reply-to: <9p8x5qiwik.fsf@fencepost.gnu.org> (message from Glenn Morris on Thu, 25 Oct 2007 19:50:59 -0400) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81819 Archived-At: Looking at it some more, the value of byte-compile-warnings set by byte-compile-close-variables gets clobbered when byte-compile-insert-header is called. It changes the buffer to " *Compiler Input", where the buffer local value shadows the value in the let-binding. It is true that it changes the current buffer, and that is ugly. Perhaps we should make it use with-current-buffer. But as soon as it returns, you get to (with-current-buffer inbuffer ...) followed by (and filename (byte-compile-fix-header filename inbuffer outbuffer)))) and that function does with-current-buffer too. So where is the code that is affected by the change in the current buffer made by byte-compile-insert-header? Is it in the caller of byte-compile-from-buffer? I don't see how that could happen, since the byte-compile-close-variables form has already exited there. Is it inside byte-compile-insert-header itself? I don't see where in that function it could be.