From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Change in face-spec-set Date: Fri, 19 Oct 2007 13:42:20 -0400 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1192815856 9979 80.91.229.12 (19 Oct 2007 17:44:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2007 17:44:16 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 19 19:44:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IivtR-0002fL-0Q for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2007 19:44:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IivtJ-0002pG-Km for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2007 13:44:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iivra-00029z-44 for emacs-devel@gnu.org; Fri, 19 Oct 2007 13:42:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IivrZ-00029Y-Dd for emacs-devel@gnu.org; Fri, 19 Oct 2007 13:42:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IivrZ-00029P-91 for emacs-devel@gnu.org; Fri, 19 Oct 2007 13:42:21 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IivrZ-0001rl-4R for emacs-devel@gnu.org; Fri, 19 Oct 2007 13:42:21 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IivrY-00032b-Gj; Fri, 19 Oct 2007 13:42:20 -0400 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81238 Archived-At: I wrote the following patch to fix one of the bugs in `face-spec-set' which was introduced by my first change there. Other changes have been made subsequently, and I don't know whether this patch is still needed, or whether any problems remain there. Can someone tell me the situation? diff -c -c -r1.381 faces.el *** faces.el 18 Oct 2007 19:02:22 -0000 1.381 --- faces.el 19 Oct 2007 17:25:59 -0000 *************** *** 1472,1477 **** --- 1472,1483 ---- ;; When we reset the face based on its spec, then it is unmodified ;; as far as Custom is concerned. (put (or (get face 'face-alias) face) 'face-modified nil) + ;; Clear all the new-frame defaults for this face. + ;; face-spec-reset-face won't do it right. + (let ((facevec (cdr (assq face face-new-frame-defaults)))) + (dotimes (i (length facevec)) + (unless (= i 0) + (aset facevec i 'unspecified)))) ;; Set each frame according to the rules implied by SPEC. (dolist (frame (frame-list)) (face-spec-set face spec frame))))