unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: Change in face-spec-set
Date: Fri, 19 Oct 2007 13:42:20 -0400	[thread overview]
Message-ID: <E1IivrY-00032b-Gj@fencepost.gnu.org> (raw)

I wrote the following patch to fix one of the bugs in `face-spec-set'
which was introduced by my first change there.  Other changes have
been made subsequently, and I don't know whether this patch is still
needed, or whether any problems remain there.  Can someone tell me
the situation?

diff -c -c -r1.381 faces.el
*** faces.el	18 Oct 2007 19:02:22 -0000	1.381
--- faces.el	19 Oct 2007 17:25:59 -0000
***************
*** 1472,1477 ****
--- 1472,1483 ----
      ;; When we reset the face based on its spec, then it is unmodified
      ;; as far as Custom is concerned.
      (put (or (get face 'face-alias) face) 'face-modified nil)
+     ;; Clear all the new-frame defaults for this face.
+     ;; face-spec-reset-face won't do it right.
+     (let ((facevec (cdr (assq face face-new-frame-defaults))))
+       (dotimes (i (length facevec))
+ 	(unless (= i 0)
+ 	  (aset facevec i 'unspecified))))
      ;; Set each frame according to the rules implied by SPEC.
      (dolist (frame (frame-list))
        (face-spec-set face spec frame))))

             reply	other threads:[~2007-10-19 17:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 17:42 Richard Stallman [this message]
2007-10-19 20:10 ` Change in face-spec-set Glenn Morris
2007-10-19 21:12   ` Glenn Morris
2007-10-20 23:47     ` Johan Bockgård
2007-10-20 14:57   ` Richard Stallman
2007-10-27 23:41   ` Richard Stallman
2007-10-29  6:39     ` Glenn Morris
2007-10-29 14:02       ` Johan Bockgård
2007-10-29 23:35       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IivrY-00032b-Gj@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).