unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: Kurt.Hornik@wu-wien.ac.at, emacs-devel@gnu.org,
	gail@tnp-online.de, jwe@bevo.che.wisc.edu
Subject: Re: [gail@tnp-online.de: octave-mod.el: wrong indentation for "IF",  "FOR", etc.]
Date: Fri, 12 Oct 2007 11:59:33 -0400	[thread overview]
Message-ID: <E1IgMvF-0001Gc-Ps@fencepost.gnu.org> (raw)
In-Reply-To: <yp8x69xh1f.fsf@fencepost.gnu.org> (message from Glenn Morris on Thu, 11 Oct 2007 21:23:08 -0400)

    > +(defun octave-re-search-backward-kw (regexp)
    > +  (let ((case-fold-search nil))
    > +    (re-search-backward regexp nil 'move inc)))

    It seems ugly to (ab)use the variable `inc' in this way.

That is true.  It is not clean to inherit a variable
from a calling function without defvar'ing it, and for that
it should have a longer name.

      parent reply	other threads:[~2007-10-12 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1If3fk-0003hN-Nr@fencepost.gnu.org>
     [not found] ` <18188.40056.604794.828796@mithrandir.hornik.net>
2007-10-10 15:38   ` [gail@tnp-online.de: octave-mod.el: wrong indentation for "IF", "FOR", etc.] John W. Eaton
2007-10-11  5:20     ` Richard Stallman
2007-10-12  1:23     ` Glenn Morris
2007-10-12  1:57       ` John W. Eaton
2007-10-12 15:59       ` Richard Stallman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IgMvF-0001Gc-Ps@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=Kurt.Hornik@wu-wien.ac.at \
    --cc=emacs-devel@gnu.org \
    --cc=gail@tnp-online.de \
    --cc=jwe@bevo.che.wisc.edu \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).