From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: isearch multiple buffers Date: Tue, 09 Oct 2007 16:03:10 -0400 Message-ID: References: <87odfcggvl.fsf@jurta.org> <87myut77c2.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1191960397 26596 80.91.229.12 (9 Oct 2007 20:06:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 20:06:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 22:06:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfLKZ-0005y5-Gz for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 22:05:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfLKT-0007ei-TL for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 16:05:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfLJM-0006W3-Px for emacs-devel@gnu.org; Tue, 09 Oct 2007 16:04:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfLJK-0006Tt-TK for emacs-devel@gnu.org; Tue, 09 Oct 2007 16:04:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfLJK-0006Ti-PW for emacs-devel@gnu.org; Tue, 09 Oct 2007 16:04:10 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfLJK-0003Sk-BJ for emacs-devel@gnu.org; Tue, 09 Oct 2007 16:04:10 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IfLIM-0004Tx-Qd; Tue, 09 Oct 2007 16:03:10 -0400 In-reply-to: <87myut77c2.fsf@jurta.org> (message from Juri Linkov on Mon, 08 Oct 2007 22:18:18 +0300) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80480 Archived-At: > I don't think that is the right UI for this feature. I think the > search should fail when it can't find another occurrence in the > current buffer. Then if you type C-s again it should go to the next > buffer which has an occurrence, and search there. The patch I proposed implements exactly the same behavior as you described. In that case, it needs more comments in the code so that people can see this is what it does. > The documentation of `isearch-buffers-next-buffer-function' should > clearly state what it means to search multiple buffers. (defvar isearch-buffers-next-buffer-function nil "Function to call to get the next buffer to search. When this variable is set to a function that returns a buffer, then after typing another C-s or C-r at a failing search, the search goes to the next buffer in the series and continues searching for the next occurrence. The first argument of this function is the current buffer where the search is currently searching. It defines the base buffer relative to which this function should find the next buffer. When the isearch direction is backward (when isearch-forward is nil), this function should return the previous buffer to search. If the second argument of this function WRAP is non-nil, then it should return the first buffer in the series; and for the backward search, it should return the last buffer in the series.") That is clear. Good. (defvar isearch-buffers-current-buffer nil "The buffer where the search is currently searching. The value is nil when the search still is in the initial buffer.") That is clear too. Please write up the NEWS text, wait 4 days for other comments and suggestions, then install it.