From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: tooltip frame uses (class mono) when processing defface specs Date: Mon, 08 Oct 2007 21:14:46 -0400 Message-ID: References: <863axadi7d.fsf@macs.hw.ac.uk> <87sl4mx4dw.fsf@laptop.shootybangbang.com> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1191892856 12143 80.91.229.12 (9 Oct 2007 01:20:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 01:20:56 +0000 (UTC) Cc: emacs-devel@gnu.org, bojohan+news@dd.chalmers.se To: jpw@pobox.com (John Paul Wallington) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 03:20:54 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1If3mH-00074Z-8u for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 03:20:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1If3mB-0008AH-R6 for ged-emacs-devel@m.gmane.org; Mon, 08 Oct 2007 21:20:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1If3hL-0005qW-JM for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:15:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1If3hJ-0005pC-VM for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:15:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1If3hJ-0005ov-D9 for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:15:45 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1If3hK-0006LC-2k for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:15:46 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1If3gM-0003nS-BN; Mon, 08 Oct 2007 21:14:46 -0400 In-reply-to: <87sl4mx4dw.fsf@laptop.shootybangbang.com> (jpw@pobox.com) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80446 Archived-At: It looks plausible, but it has a drawback that it makes tooltip frames work one way, while ordinary frames work a different way. That is added complexity. Can you investigate how things happen for ordinary frames, and then see why they fail to happen the same way for tooltip frames? That might show the way to write a fix that would cause both kinds of frames to be handled the same way. One style point: + else if (FRAME_X_DISPLAY_INFO (f)->visual->class == GrayScale || + FRAME_X_DISPLAY_INFO (f)->visual->class == StaticGray) Please break the line before the binary operator, not after.