unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: jpw@pobox.com (John Paul Wallington)
Cc: emacs-devel@gnu.org, bojohan+news@dd.chalmers.se
Subject: Re: tooltip frame uses (class mono) when processing defface specs
Date: Mon, 08 Oct 2007 21:14:46 -0400	[thread overview]
Message-ID: <E1If3gM-0003nS-BN@fencepost.gnu.org> (raw)
In-Reply-To: <87sl4mx4dw.fsf@laptop.shootybangbang.com> (jpw@pobox.com)

It looks plausible, but it has a drawback that it makes tooltip
frames work one way, while ordinary frames work a different way.
That is added complexity.

Can you investigate how things happen for ordinary frames, and then
see why they fail to happen the same way for tooltip frames?  That
might show the way to write a fix that would cause both kinds of
frames to be handled the same way.

One style point:

    +    else if (FRAME_X_DISPLAY_INFO (f)->visual->class == GrayScale ||
    +	     FRAME_X_DISPLAY_INFO (f)->visual->class == StaticGray)

Please break the line before the binary operator, not after.

  parent reply	other threads:[~2007-10-09  1:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 11:10 tooltip frame uses (class mono) when processing defface specs Joe Wells
2007-09-19 11:23 ` Joe Wells
2007-09-20 16:35 ` Richard Stallman
2007-09-20 17:32   ` Joe Wells
2007-09-20 18:14 ` Johan Bockgård
2007-09-20 21:31   ` Joe Wells
2007-09-21 22:32   ` Richard Stallman
2007-09-29 16:11   ` Richard Stallman
2007-10-07 13:10   ` Richard Stallman
2007-10-07 16:42     ` John Paul Wallington
2007-10-08 18:10       ` Glenn Morris
2007-10-09  1:14       ` Richard Stallman [this message]
2007-10-12  1:26         ` Glenn Morris
2007-10-12 15:59           ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1If3gM-0003nS-BN@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=bojohan+news@dd.chalmers.se \
    --cc=emacs-devel@gnu.org \
    --cc=jpw@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).