23.0.50; add-change-log-entry-other-window and Perl modes.

23.0.50; add-change-log-entry-other-window and Perl modes.

[Matt Hodges]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

In GNU Emacs 23.0.50.4 (i686-pc-linux-gnu, GTK+ Version 2.10.13)
 of 2007-09-14 on escpc40
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--with-gtk''

add-change-log-entry-other-window stopped detecting the current
subroutine in perl/cperl-mode due to, I think, this change:

    revision 1.189
    date: 2007-07-20 21:30:51 +0100;  author: monnier;  state: Exp;  lines: +15 -15;  commitid: 9SIF7GuRLekDZxqs;
    (add-change-log-entry, add-log-current-defun, change-log-merge):
    Use derived-mode-p rather than checking major-mode directly.

The attached patch seems to fix it.

Thanks,
Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: add-log.el patch. --]
[-- Type: text/x-patch, Size: 833 bytes --]

--- add-log.el	10 Sep 2007 08:53:06 +0100	1.195
+++ add-log.el	20 Sep 2007 09:44:54 +0100	
@@ -802,6 +802,11 @@
   "*Modes that look like TeX to `add-log-current-defun'.")
 
 ;;;###autoload
+(defvar add-log-perl-like-modes
+  '(perl-mode cperl-mode)
+  "*Modes that look like Perl to `add-log-current-defun'.")
+
+;;;###autoload
 (defun add-log-current-defun ()
   "Return name of function definition point is in, or nil.
 
@@ -1016,7 +1021,7 @@
 		((derived-mode-p 'texinfo-mode)
 		 (if (re-search-backward "^@node[ \t]+\\([^,\n]+\\)" nil t)
 		     (match-string-no-properties 1)))
-		((derived-mode-p '(perl-mode cperl-mode))
+		((apply 'derived-mode-p add-log-perl-like-modes)
 		 (if (re-search-backward "^sub[ \t]+\\([^({ \t\n]+\\)" nil t)
 		     (match-string-no-properties 1)))
 		;; Emacs's autoconf-mode installs its own

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: 23.0.50; add-change-log-entry-other-window and Perl modes.

[Stefan Monnier]

> add-change-log-entry-other-window stopped detecting the current
> subroutine in perl/cperl-mode due to, I think, this change:

Sorry for the thinko.  Should be fixed now,


        Stefan

Re: 23.0.50; add-change-log-entry-other-window and Perl modes.

[Richard Stallman]

Thanks for the fix.  I don't think we need to add that variable;
just fixing the call to derived-mode-p is enough.