unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Bug in browse-url.el
@ 2007-09-21 12:23 Richard Stallman
  2007-09-21 12:33 ` Michaël Cadilhac
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Stallman @ 2007-09-21 12:23 UTC (permalink / raw)
  To: emacs-devel

A look at the callers of browse-url-url-encode-chars led me to guess
that this change is needed.  But is it correct?

*** browse-url.el	17 Sep 2007 18:21:10 -0400	1.63
--- browse-url.el	20 Sep 2007 15:30:19 -0400	
***************
*** 622,628 ****
  (defun browse-url-url-encode-chars (text chars)
    "URL-encode the chars in TEXT that match CHARS.
  CHARS is a regexp-like character alternative (e.g., \"[,)$]\")."
!   (let ((encoded-url (copy-sequence url))
  	(s 0))
      (while (setq s (string-match chars encoded-url s))
        (setq encoded-url
--- 622,628 ----
  (defun browse-url-url-encode-chars (text chars)
    "URL-encode the chars in TEXT that match CHARS.
  CHARS is a regexp-like character alternative (e.g., \"[,)$]\")."
!   (let ((encoded-url (copy-sequence text))
  	(s 0))
      (while (setq s (string-match chars encoded-url s))
        (setq encoded-url

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug in browse-url.el
  2007-09-21 12:23 Bug in browse-url.el Richard Stallman
@ 2007-09-21 12:33 ` Michaël Cadilhac
  0 siblings, 0 replies; 2+ messages in thread
From: Michaël Cadilhac @ 2007-09-21 12:33 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel


[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

Richard Stallman <rms@gnu.org> writes:

> A look at the callers of browse-url-url-encode-chars led me to guess
> that this change is needed.  But is it correct?

Yes, it is, but this change has already been made on the 19th.

Thanks.

-- 
 |   Michaël `Micha' Cadilhac       |  I cannot reproduce this bug,          |
 |   http://michael.cadilhac.name   |    but I have installed a change       |
 |   JID/MSN:                       |      which I think will fix it.        |
 `----  michael.cadilhac@gmail.com  |          -- Kim F. Storm          -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-21 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-21 12:23 Bug in browse-url.el Richard Stallman
2007-09-21 12:33 ` Michaël Cadilhac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).