From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: 23.0.50; face-problems with multy-tty
Date: Sun, 16 Sep 2007 23:59:15 -0400
Message-ID: <E1IX7lT-0007ny-4w@fencepost.gnu.org>
References: <87ejhcmgp2.fsf@baldur.tsdh.de>
	<200709062116.l86LGWnO000262@oogie-boogie.ics.uci.edu>
	<yoijmyvzb897.fsf@gamma02.me.chalmers.se>
	<E1ITjtg-0004oz-KH@fencepost.gnu.org>
	<yoijzlzy9n2m.fsf@gamma02.me.chalmers.se>
	<E1IU6HX-0002Sj-VZ@fencepost.gnu.org>
	<yoij7imuk0un.fsf@gamma02.me.chalmers.se>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1190001661 10030 80.91.229.12 (17 Sep 2007 04:01:01 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 17 Sep 2007 04:01:01 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 17 06:01:00 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IX7n9-0007jy-Hy
	for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2007 06:00:59 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1IX7n8-0005yT-JD
	for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2007 00:00:58 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IX7m1-0005VZ-I1
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:49 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IX7m0-0005Ue-3I
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:49 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IX7lz-0005UX-OI
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:47 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1IX7ly-0002CV-Nq
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:46 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1IX7lT-0007ny-4w; Sun, 16 Sep 2007 23:59:15 -0400
In-reply-to: <yoij7imuk0un.fsf@gamma02.me.chalmers.se>
	(bojohan+news@dd.chalmers.se)
X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:79075
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/79075>

    The old code boiled down to calling `set-face-attribute' with a null
    FRAME argument. This sets a new frame default that is the same for all
    frames (via face-new-frame-defaults). That is not what we want.

    The new code calls set-face-attribute locally for each frame. It does
    not set a default in face-new-frame-defaults. This DTRT unless a default
    exists in face-new-frame-defaults (or an X resource exists for the
    face).

You are basically right.  It's just that I think the change you made
really needs to be inside face-spec-set.  That way, face-spec-set will
DTRT _also_.

I made that change.